Skip to content

branch-3.1: [fix](filecache) fix crash when clear file cache #56170 #56584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 10, 2025
Merged

branch-3.1: [fix](filecache) fix crash when clear file cache #56170 #56584

morrySnow merged 1 commit into from
Oct 10, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 28, 2025

Cherry-picked from #56170

@freemandealer
[fix](filecache) fix crash when clear file cache (#56170)
5528b4a 
_need_update_lru_blocks holds the reference of the block which will be
cleared by api/op=clear thus causing use-after-free
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot requested a review from morrySnow as a code owner September 28, 2025 13:40
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 28, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 28, 2025

TPC-H: Total hot run time: 32704 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5528b4a0c30d685a8fd5159da213b4d63cc51f3c, data reload: false

------ Round 1 ----------------------------------
q1	17618	5449	5423	5423
q2	2018	403	296	296
q3	12150	1283	743	743
q4	10222	885	459	459
q5	7879	2417	2136	2136
q6	179	165	132	132
q7	911	749	618	618
q8	9330	1458	1177	1177
q9	5307	5027	4895	4895
q10	6782	2292	1848	1848
q11	465	279	258	258
q12	338	351	206	206
q13	17806	3594	2997	2997
q14	232	224	218	218
q15	522	462	465	462
q16	419	431	364	364
q17	588	878	355	355
q18	7020	6524	6384	6384
q19	1219	979	547	547
q20	339	335	213	213
q21	2815	2203	1949	1949
q22	1098	1049	1024	1024
Total cold run time: 105257 ms
Total hot run time: 32704 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5515	5501	5482	5482
q2	234	333	235	235
q3	2214	2639	2330	2330
q4	1368	1812	1406	1406
q5	4447	4942	4992	4942
q6	169	167	134	134
q7	2095	2028	1810	1810
q8	2688	2842	2773	2773
q9	7340	7392	7341	7341
q10	3032	3214	2766	2766
q11	577	543	539	539
q12	679	775	662	662
q13	3422	3762	3159	3159
q14	296	298	278	278
q15	530	471	467	467
q16	453	510	432	432
q17	1251	1756	1277	1277
q18	7709	7482	7300	7300
q19	768	1182	1107	1107
q20	2013	2082	1934	1934
q21	5425	4839	4457	4457
q22	1120	1111	1061	1061
Total cold run time: 53345 ms
Total hot run time: 51892 ms

@doris-robot
Copy link

doris-robot commented Sep 28, 2025

TPC-DS: Total hot run time: 193253 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5528b4a0c30d685a8fd5159da213b4d63cc51f3c, data reload: false

query1	943	413	405	405
query2	6157	1969	2001	1969
query3	8692	208	206	206
query4	33734	23898	23301	23301
query5	3688	619	485	485
query6	294	213	187	187
query7	4213	500	340	340
query8	320	251	257	251
query9	9402	2609	2621	2609
query10	464	330	268	268
query11	17908	15432	15209	15209
query12	162	121	107	107
query13	1577	558	417	417
query14	8888	7430	7568	7430
query15	238	197	176	176
query16	8140	692	513	513
query17	1541	783	616	616
query18	2185	421	339	339
query19	233	215	173	173
query20	128	131	123	123
query21	215	136	112	112
query22	4781	4641	4397	4397
query23	35080	34075	34112	34075
query24	7363	2752	2739	2739
query25	572	520	452	452
query26	1137	300	177	177
query27	2174	482	361	361
query28	5839	2247	2210	2210
query29	798	603	489	489
query30	248	196	159	159
query31	1056	903	824	824
query32	93	62	61	61
query33	505	380	327	327
query34	767	874	529	529
query35	806	819	731	731
query36	1018	1049	1004	1004
query37	119	101	74	74
query38	4107	4047	3971	3971
query39	1522	1480	1518	1480
query40	223	127	109	109
query41	50	53	47	47
query42	138	111	111	111
query43	532	543	499	499
query44	1355	846	839	839
query45	188	189	178	178
query46	898	1089	675	675
query47	1939	2004	1922	1922
query48	431	433	354	354
query49	831	507	442	442
query50	692	705	444	444
query51	7362	7367	7160	7160
query52	103	106	94	94
query53	239	274	191	191
query54	574	560	473	473
query55	86	82	81	81
query56	280	283	263	263
query57	1307	1292	1205	1205
query58	248	230	236	230
query59	3179	3306	3060	3060
query60	316	286	283	283
query61	113	116	129	116
query62	804	768	715	715
query63	248	216	202	202
query64	4734	1014	661	661
query65	3392	3309	3313	3309
query66	943	421	321	321
query67	16295	15883	15580	15580
query68	7787	823	534	534
query69	488	322	266	266
query70	1193	1120	1159	1120
query71	378	310	271	271
query72	5792	3751	3816	3751
query73	632	750	356	356
query74	9680	9446	8928	8928
query75	3212	3142	2699	2699
query76	3092	1186	797	797
query77	526	389	277	277
query78	10329	10443	9698	9698
query79	4270	851	597	597
query80	834	545	446	446
query81	495	269	224	224
query82	594	121	89	89
query83	182	165	146	146
query84	298	98	84	84
query85	786	366	313	313
query86	386	311	308	308
query87	4375	4421	4277	4277
query88	5014	2446	2354	2354
query89	417	333	297	297
query90	1776	194	196	194
query91	140	140	110	110
query92	66	58	52	52
query93	2323	881	538	538
query94	677	421	319	319
query95	356	285	274	274
query96	491	603	290	290
query97	3236	3311	3216	3216
query98	232	218	199	199
query99	1542	1416	1369	1369
Total cold run time: 296206 ms
Total hot run time: 193253 ms

@doris-robot
Copy link

doris-robot commented Sep 28, 2025

ClickBench: Total hot run time: 28.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5528b4a0c30d685a8fd5159da213b4d63cc51f3c, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.53	0.54	0.54
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.50	0.50
query10	0.55	0.55	0.54
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.61	0.59	0.59
query14	0.78	0.81	0.81
query15	0.85	0.83	0.83
query16	0.38	0.39	0.38
query17	1.06	1.03	1.03
query18	0.23	0.23	0.22
query19	1.86	1.85	1.90
query20	0.01	0.01	0.01
query21	15.39	0.96	0.62
query22	0.74	0.80	0.68
query23	15.03	1.39	0.56
query24	3.01	1.74	0.74
query25	0.30	0.20	0.09
query26	0.28	0.15	0.15
query27	0.05	0.04	0.06
query28	13.36	0.96	0.44
query29	12.57	3.96	3.22
query30	0.26	0.11	0.06
query31	2.82	0.58	0.38
query32	3.23	0.54	0.46
query33	3.02	3.05	3.00
query34	16.76	5.20	4.51
query35	4.52	4.55	4.67
query36	0.66	0.51	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.37 s
Total hot run time: 28.79 s

@morrySnow morrySnow merged commit ed2ed5b into branch-3.1 Oct 10, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-56170-branch-3.1 branch October 10, 2025 09:19
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @freemandealer