Skip to content

branch-4.0: [fix](outfile) fix small file output with bz2 compression #56368 #56495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CalvinKirs merged 1 commit into from
Sep 26, 2025
Merged

branch-4.0: [fix](outfile) fix small file output with bz2 compression #56368 #56495

CalvinKirs merged 1 commit into from
Sep 26, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 26, 2025

Cherry-picked from #56368

@morningman
[fix](outfile) fix small file output with bz2 compression (#56368)
3560a66 
### What problem does this PR solve?

When export small data with bz2 compression, it may return
BZ_OUTBUFF_FULL,
because the pre allocated output buffer is too small.
This PR fix this by adding a fix size to avoid this problem
@Thearas
Copy link
Contributor

Thearas commented Sep 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 26, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 26, 2025

ClickBench: Total hot run time: 29.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3560a667c71bcf555bc0d594784e538ca48756d2, data reload: true

query1	0.04	0.03	0.02
query2	0.11	0.04	0.05
query3	0.27	0.08	0.07
query4	1.74	0.11	0.11
query5	0.27	0.25	0.25
query6	1.27	0.67	0.65
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.61	0.51	0.52
query10	0.58	0.57	0.57
query11	0.18	0.10	0.11
query12	0.16	0.12	0.11
query13	0.64	0.60	0.62
query14	0.79	0.81	0.82
query15	0.88	0.84	0.85
query16	0.40	0.40	0.38
query17	1.02	1.05	1.04
query18	0.20	0.20	0.19
query19	1.97	1.84	1.82
query20	0.02	0.01	0.01
query21	15.46	0.93	0.58
query22	0.80	1.05	0.66
query23	15.30	1.38	0.60
query24	4.89	0.47	0.26
query25	0.20	0.04	0.05
query26	0.54	0.15	0.14
query27	0.06	0.05	0.04
query28	11.73	1.53	0.92
query29	12.70	3.86	3.19
query30	0.30	0.13	0.11
query31	3.01	0.60	0.37
query32	3.33	0.62	0.50
query33	3.30	3.32	3.27
query34	17.77	5.79	5.01
query35	5.08	5.11	5.07
query36	0.75	0.55	0.53
query37	0.11	0.06	0.06
query38	0.06	0.03	0.03
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.08	0.02	0.02
query42	0.05	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.01 s
Total hot run time: 29.81 s

@CalvinKirs CalvinKirs merged commit f2d5f2a into branch-4.0 Sep 26, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @CalvinKirs @dataroaring @morningman