Skip to content

branch-3.1: [feature](udf) Support for IP types in Java UDF #44871 #56346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 25, 2025
Merged

branch-3.1: [feature](udf) Support for IP types in Java UDF #44871 #56346

morrySnow merged 1 commit into from
Sep 25, 2025

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Sep 23, 2025 •
edited by morrySnow
Loading

picked from #44871

@Mryange Mryange requested a review from morrySnow as a code owner September 23, 2025 07:16
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Sep 23, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 23, 2025

TPC-H: Total hot run time: 32600 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit afa084b32ccfdf438be3a7315b3b2cdd3e7793db, data reload: false

------ Round 1 ----------------------------------
q1	17624	5474	5336	5336
q2	2031	425	298	298
q3	12037	1238	750	750
q4	10505	882	454	454
q5	9512	2392	2180	2180
q6	189	164	131	131
q7	910	748	604	604
q8	9320	1432	1126	1126
q9	5285	4952	4897	4897
q10	6776	2292	1804	1804
q11	473	282	268	268
q12	341	353	211	211
q13	17800	3577	2997	2997
q14	238	239	204	204
q15	524	488	461	461
q16	430	437	376	376
q17	601	874	381	381
q18	7133	6491	6378	6378
q19	1220	954	550	550
q20	334	353	216	216
q21	2832	2205	2009	2009
q22	1080	1060	969	969
Total cold run time: 107195 ms
Total hot run time: 32600 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5457	5458	5752	5458
q2	240	327	232	232
q3	2277	2608	2319	2319
q4	1319	1769	1369	1369
q5	4369	4988	5051	4988
q6	159	159	124	124
q7	2058	1928	1849	1849
q8	2641	2882	2728	2728
q9	7273	7245	7198	7198
q10	3094	3221	2755	2755
q11	584	507	502	502
q12	685	791	627	627
q13	3384	3768	3159	3159
q14	280	317	266	266
q15	528	456	469	456
q16	440	492	425	425
q17	1228	1742	1272	1272
q18	7698	7432	7269	7269
q19	828	1210	1032	1032
q20	2009	2047	1934	1934
q21	5327	4892	4529	4529
q22	1121	1121	1002	1002
Total cold run time: 52999 ms
Total hot run time: 51493 ms

@doris-robot
Copy link

doris-robot commented Sep 23, 2025

TPC-DS: Total hot run time: 192764 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit afa084b32ccfdf438be3a7315b3b2cdd3e7793db, data reload: false

query1	967	414	413	413
query2	6119	1972	1928	1928
query3	8678	198	196	196
query4	33736	23848	23693	23693
query5	3851	582	448	448
query6	289	204	187	187
query7	4199	494	309	309
query8	312	249	259	249
query9	9322	2627	2606	2606
query10	463	326	261	261
query11	18083	15533	15163	15163
query12	160	113	109	109
query13	1564	551	426	426
query14	10603	7603	6644	6644
query15	267	196	173	173
query16	8065	713	530	530
query17	1577	768	622	622
query18	2179	420	333	333
query19	249	191	173	173
query20	138	125	122	122
query21	205	126	111	111
query22	4570	4573	4544	4544
query23	34971	34599	33933	33933
query24	7453	2717	2744	2717
query25	556	528	446	446
query26	824	286	180	180
query27	2183	492	374	374
query28	5447	2283	2247	2247
query29	684	612	472	472
query30	249	216	166	166
query31	1015	884	835	835
query32	80	58	55	55
query33	488	377	316	316
query34	756	864	529	529
query35	773	815	743	743
query36	1027	1057	968	968
query37	120	97	68	68
query38	4031	4017	4036	4017
query39	1504	1455	1458	1455
query40	205	124	109	109
query41	49	47	47	47
query42	125	108	105	105
query43	516	522	493	493
query44	1414	846	853	846
query45	189	178	175	175
query46	902	1086	688	688
query47	1946	2002	1940	1940
query48	409	431	360	360
query49	737	504	404	404
query50	689	702	440	440
query51	7478	7532	7237	7237
query52	104	99	93	93
query53	237	265	194	194
query54	571	559	495	495
query55	82	80	83	80
query56	289	277	268	268
query57	1273	1263	1226	1226
query58	236	218	224	218
query59	3267	3249	3068	3068
query60	303	292	291	291
query61	125	111	116	111
query62	788	767	716	716
query63	231	200	200	200
query64	3503	1008	683	683
query65	3374	3316	3242	3242
query66	771	400	313	313
query67	16211	16035	15608	15608
query68	7310	830	555	555
query69	494	307	266	266
query70	1181	1100	1113	1100
query71	393	299	276	276
query72	5847	3696	3970	3696
query73	639	743	351	351
query74	10588	9190	9228	9190
query75	3243	3139	2646	2646
query76	3276	1176	783	783
query77	613	369	284	284
query78	10375	10338	9577	9577
query79	3515	858	603	603
query80	631	546	441	441
query81	513	260	221	221
query82	589	116	89	89
query83	168	160	148	148
query84	287	106	83	83
query85	769	357	307	307
query86	388	303	301	301
query87	4332	4350	4284	4284
query88	5100	2426	2436	2426
query89	418	331	297	297
query90	1776	190	194	190
query91	138	143	108	108
query92	66	63	55	55
query93	2145	895	554	554
query94	660	411	312	312
query95	345	290	280	280
query96	493	615	289	289
query97	3206	3279	3125	3125
query98	229	221	195	195
query99	1574	1399	1321	1321
Total cold run time: 295082 ms
Total hot run time: 192764 ms

@doris-robot
Copy link

doris-robot commented Sep 23, 2025

ClickBench: Total hot run time: 28.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit afa084b32ccfdf438be3a7315b3b2cdd3e7793db, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.02	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.11
query5	0.53	0.48	0.52
query6	1.12	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.02
query9	0.57	0.50	0.52
query10	0.56	0.56	0.56
query11	0.14	0.12	0.11
query12	0.14	0.11	0.11
query13	0.63	0.59	0.60
query14	0.78	0.79	0.79
query15	0.85	0.83	0.82
query16	0.37	0.41	0.39
query17	1.08	1.10	0.99
query18	0.24	0.23	0.23
query19	1.90	1.88	1.82
query20	0.02	0.01	0.02
query21	15.41	0.94	0.58
query22	0.74	0.80	0.58
query23	15.19	1.43	0.57
query24	3.27	1.13	0.93
query25	0.29	0.08	0.07
query26	0.26	0.14	0.15
query27	0.05	0.05	0.04
query28	13.42	1.07	0.43
query29	12.54	3.90	3.25
query30	0.25	0.08	0.06
query31	2.83	0.60	0.38
query32	3.25	0.53	0.46
query33	3.02	3.01	3.02
query34	16.51	5.20	4.51
query35	4.53	4.54	4.54
query36	0.64	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.64 s
Total hot run time: 28.72 s

@doris-robot
Copy link

doris-robot commented Sep 23, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.57% (12784/28053)
Line Coverage 36.39% (114003/313255)
Region Coverage 34.01% (65188/191664)
Branch Coverage 31.04% (34211/110218)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.08% (18231/27590)
Line Coverage 57.66% (180058/312289)
Region Coverage 55.38% (106580/192441)
Branch Coverage 49.74% (55077/110732)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.08% (18231/27590)
Line Coverage 57.66% (180058/312289)
Region Coverage 55.38% (106580/192441)
Branch Coverage 49.74% (55077/110732)

@morrySnow morrySnow changed the title [feature](udf) Support for IP types in Java UDF. (#44871) branch-3.1: [feature](udf) Support for IP types in Java UDF #44871 Sep 25, 2025
@morrySnow morrySnow merged commit 553f742 into apache:branch-3.1 Sep 25, 2025
21 of 24 checks passed
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mryange @hello-stephen @doris-robot @morrySnow