Skip to content

branch-3.1: [fix](iceberg) Fix classloader usage in the Iceberg system table scanner #56150 #56220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 25, 2025
Merged

branch-3.1: [fix](iceberg) Fix classloader usage in the Iceberg system table scanner #56150 #56220

morrySnow merged 1 commit into from
Sep 25, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 19, 2025

Cherry-picked from #56150

@github-actions github-actions bot requested a review from morrySnow as a code owner September 19, 2025 04:49
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 19, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

TPC-H: Total hot run time: 32614 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4ed059460dcb623414a70acce4f6373eb24a327a, data reload: false

------ Round 1 ----------------------------------
q1	17595	5475	5405	5405
q2	2029	399	271	271
q3	12153	1232	732	732
q4	10192	867	453	453
q5	7662	2399	2086	2086
q6	182	164	130	130
q7	893	747	610	610
q8	9339	1434	1150	1150
q9	5219	4950	4884	4884
q10	6757	2240	1815	1815
q11	477	286	272	272
q12	329	358	210	210
q13	17774	3581	3053	3053
q14	220	220	222	220
q15	528	471	478	471
q16	428	433	374	374
q17	620	856	378	378
q18	7042	6412	6382	6382
q19	1218	952	544	544
q20	317	332	204	204
q21	2991	2203	1959	1959
q22	1026	1011	1019	1011
Total cold run time: 104991 ms
Total hot run time: 32614 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5512	5492	5477	5477
q2	230	331	233	233
q3	2208	2653	2322	2322
q4	1387	1827	1405	1405
q5	4484	4888	4974	4888
q6	166	164	130	130
q7	2067	1960	1813	1813
q8	2620	2854	2713	2713
q9	7301	7242	7209	7209
q10	3036	3353	2818	2818
q11	546	494	497	494
q12	655	765	619	619
q13	3396	3767	3216	3216
q14	292	292	276	276
q15	527	460	469	460
q16	450	479	430	430
q17	1213	1710	1263	1263
q18	7659	7551	7314	7314
q19	799	881	1142	881
q20	1989	2072	1911	1911
q21	5395	4997	4718	4718
q22	1086	1078	1004	1004
Total cold run time: 53018 ms
Total hot run time: 51594 ms

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

TPC-DS: Total hot run time: 192067 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4ed059460dcb623414a70acce4f6373eb24a327a, data reload: false

query1	936	399	424	399
query2	6234	1929	1797	1797
query3	8689	205	195	195
query4	33581	23851	23562	23562
query5	3694	605	446	446
query6	276	200	205	200
query7	4225	499	319	319
query8	311	244	255	244
query9	9390	2634	2588	2588
query10	469	317	255	255
query11	18109	15390	15112	15112
query12	156	105	103	103
query13	1568	534	416	416
query14	9623	7450	6741	6741
query15	251	191	175	175
query16	8111	661	486	486
query17	1547	751	594	594
query18	2137	428	337	337
query19	219	197	167	167
query20	134	118	120	118
query21	213	127	110	110
query22	4610	4574	4527	4527
query23	35460	34598	33833	33833
query24	7925	2716	2756	2716
query25	547	504	446	446
query26	1156	288	179	179
query27	2224	525	368	368
query28	5209	2244	2232	2232
query29	783	612	456	456
query30	255	193	163	163
query31	1021	957	829	829
query32	96	62	57	57
query33	508	382	320	320
query34	758	900	555	555
query35	820	822	746	746
query36	1015	1079	967	967
query37	106	90	65	65
query38	4040	4070	3998	3998
query39	1539	1502	1479	1479
query40	206	129	109	109
query41	49	53	48	48
query42	124	104	103	103
query43	499	525	486	486
query44	1326	840	857	840
query45	189	177	171	171
query46	879	1062	676	676
query47	1961	1986	1950	1950
query48	424	426	347	347
query49	775	493	396	396
query50	667	680	434	434
query51	7400	7319	7323	7319
query52	108	106	98	98
query53	230	262	187	187
query54	548	551	472	472
query55	83	80	89	80
query56	259	272	261	261
query57	1272	1272	1241	1241
query58	247	221	228	221
query59	3113	3132	2930	2930
query60	289	282	279	279
query61	122	117	113	113
query62	777	756	708	708
query63	224	188	193	188
query64	4545	1010	676	676
query65	3420	3297	3358	3297
query66	1003	412	322	322
query67	16522	15722	15610	15610
query68	7468	841	553	553
query69	484	310	268	268
query70	1204	1137	1132	1132
query71	377	301	264	264
query72	5770	3752	3932	3752
query73	634	750	355	355
query74	9969	9450	8955	8955
query75	3222	3142	2700	2700
query76	3031	1145	784	784
query77	470	358	283	283
query78	10312	10453	9583	9583
query79	3386	848	609	609
query80	735	536	444	444
query81	508	255	224	224
query82	582	125	90	90
query83	155	160	143	143
query84	233	95	76	76
query85	780	379	299	299
query86	396	303	304	303
query87	4331	4322	4194	4194
query88	4890	2431	2412	2412
query89	405	338	293	293
query90	1771	189	193	189
query91	142	134	124	124
query92	68	56	51	51
query93	2352	894	572	572
query94	688	422	312	312
query95	340	282	269	269
query96	494	605	290	290
query97	3179	3277	3179	3179
query98	230	209	204	204
query99	1353	1377	1299	1299
Total cold run time: 295165 ms
Total hot run time: 192067 ms

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

ClickBench: Total hot run time: 28.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4ed059460dcb623414a70acce4f6373eb24a327a, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.02	0.03
query3	0.25	0.07	0.07
query4	1.65	0.10	0.10
query5	0.53	0.54	0.51
query6	1.15	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.50
query10	0.56	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.59
query14	0.77	0.78	0.81
query15	0.85	0.83	0.82
query16	0.38	0.37	0.39
query17	1.08	1.10	1.09
query18	0.23	0.22	0.23
query19	1.90	1.78	1.79
query20	0.02	0.02	0.01
query21	15.41	0.92	0.58
query22	0.75	0.83	0.52
query23	15.20	1.41	0.51
query24	3.70	1.05	0.90
query25	0.20	0.09	0.06
query26	0.23	0.14	0.13
query27	0.04	0.05	0.04
query28	13.03	1.00	0.44
query29	12.58	3.95	3.24
query30	0.26	0.10	0.06
query31	2.84	0.59	0.36
query32	3.22	0.53	0.46
query33	3.05	3.07	3.00
query34	16.43	5.20	4.48
query35	4.62	4.57	4.52
query36	0.64	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.7 s
Total hot run time: 28.51 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 19, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 6ff6fe3 into branch-3.1 Sep 25, 2025
23 checks passed
@morrySnow morrySnow deleted the auto-pick-56150-branch-3.1 branch September 25, 2025 09:16
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @morrySnow @dataroaring @zy-kkk