-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) not use cte split multi distinct when agg has source repeat #55907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
add related PR and but detail in desc |
|
run buildall |
TPC-H: Total hot run time: 34632 ms |
|
run buildall |
TPC-H: Total hot run time: 34601 ms |
TPC-DS: Total hot run time: 188982 ms |
ClickBench: Total hot run time: 29.94 s |
|
run cloud_p0 |
4ead0e5 to
f419212
Compare
|
run buildall |
FE Regression Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 34492 ms |
TPC-DS: Total hot run time: 188906 ms |
ClickBench: Total hot run time: 30.06 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
run external |
1 similar comment
|
run external |
f419212 to
1fe6e60
Compare
|
run buildall |
TPC-H: Total hot run time: 34521 ms |
TPC-DS: Total hot run time: 189309 ms |
ClickBench: Total hot run time: 30.18 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
run p0 |
1fe6e60 to
5bf7f11
Compare
|
run buildall |
TPC-H: Total hot run time: 35041 ms |
TPC-DS: Total hot run time: 189760 ms |
ClickBench: Total hot run time: 30.16 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #54079
Problem Summary:
There may be some issues in scenarios where the grouping() function is present. When merging a project,
In theory, it should be rewritten as
GROUPPING_PREVIX_publish_date# 79 AS dim_207# 32, but there is a problem here:The map generated by the lower level project is: key :
GROUPING_PREFIX_publish_date#36 , value: GROUPING_PREFIX_publish_date#79Dealing with upper level projects
GROUPING_PREFIX_publish_date#36 originExpression=Grouping(publish_date#6) AS dim_207#32In the upper level project, the 'virtual slot' is used, and the 'key' in the map is' slot '. Although the ExprId is the same, it cannot be hit, resulting in an error.So temporarily disable the use of CTE splitting to handle grouping+multiple counts (distinctions) scenarios.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)