Skip to content

branch-3.1: [fix](nereids) fix window expression alias reuse expr id #55286 #55486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 4 commits into from
Sep 4, 2025
Merged

branch-3.1: [fix](nereids) fix window expression alias reuse expr id #55286 #55486

morrySnow merged 4 commits into from
Sep 4, 2025

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Aug 29, 2025

cherry pick from #55286

@yujun777 yujun777 requested a review from morrySnow as a code owner August 29, 2025 11:37
@yujun777
Copy link
Contributor Author

yujun777 commented Aug 29, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Aug 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

TPC-H: Total hot run time: 32670 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0161a4ffe76a41d2b88027a6be9dd13971a1b248, data reload: false

------ Round 1 ----------------------------------
q1	17611	5465	5445	5445
q2	2037	432	288	288
q3	12119	1226	739	739
q4	10536	868	463	463
q5	9453	2404	2101	2101
q6	182	164	134	134
q7	886	745	620	620
q8	9333	1394	1158	1158
q9	5280	4961	4876	4876
q10	6768	2281	1821	1821
q11	487	287	267	267
q12	339	348	212	212
q13	17786	3592	3017	3017
q14	235	233	207	207
q15	529	466	460	460
q16	427	427	369	369
q17	601	857	363	363
q18	6867	6433	6431	6431
q19	1739	946	538	538
q20	331	344	206	206
q21	3012	2204	1945	1945
q22	1041	1014	1010	1010
Total cold run time: 107599 ms
Total hot run time: 32670 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6144	5449	5469	5449
q2	235	326	235	235
q3	2234	2632	2326	2326
q4	1353	1764	1349	1349
q5	4443	5046	5101	5046
q6	172	169	130	130
q7	2075	1960	1848	1848
q8	2693	2903	2744	2744
q9	7354	7371	7225	7225
q10	3052	3232	2775	2775
q11	599	507	492	492
q12	700	733	600	600
q13	3470	3772	3171	3171
q14	280	295	278	278
q15	514	474	450	450
q16	455	475	445	445
q17	1208	1703	1272	1272
q18	7654	7447	7283	7283
q19	791	1120	1051	1051
q20	2007	2046	1895	1895
q21	5374	5013	4437	4437
q22	1051	1066	1020	1020
Total cold run time: 53858 ms
Total hot run time: 51521 ms

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

TPC-DS: Total hot run time: 192723 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0161a4ffe76a41d2b88027a6be9dd13971a1b248, data reload: false

query1	958	393	374	374
query2	6228	1864	1901	1864
query3	8708	204	200	200
query4	33785	23636	23465	23465
query5	3699	592	448	448
query6	287	194	182	182
query7	4203	505	313	313
query8	312	261	252	252
query9	9532	2616	2588	2588
query10	487	325	276	276
query11	18080	15502	15200	15200
query12	163	116	112	112
query13	1567	541	425	425
query14	10143	6671	7508	6671
query15	255	195	171	171
query16	8086	624	514	514
query17	1648	814	630	630
query18	2168	414	315	315
query19	231	179	158	158
query20	130	123	127	123
query21	215	128	109	109
query22	4615	4594	4351	4351
query23	34875	34295	34522	34295
query24	7527	2741	2788	2741
query25	503	477	403	403
query26	833	283	173	173
query27	1951	509	364	364
query28	5262	2231	2172	2172
query29	680	580	466	466
query30	255	198	169	169
query31	971	932	790	790
query32	81	64	60	60
query33	516	370	341	341
query34	760	872	540	540
query35	784	812	719	719
query36	1055	1080	995	995
query37	111	99	74	74
query38	4065	4067	3982	3982
query39	1526	1485	1495	1485
query40	213	123	121	121
query41	56	53	53	53
query42	128	113	113	113
query43	530	525	491	491
query44	1390	849	851	849
query45	191	188	176	176
query46	903	1076	692	692
query47	2011	2036	1951	1951
query48	431	445	365	365
query49	769	532	456	456
query50	709	724	436	436
query51	7408	7298	7163	7163
query52	107	107	99	99
query53	249	274	201	201
query54	577	592	485	485
query55	80	82	85	82
query56	281	282	269	269
query57	1278	1264	1196	1196
query58	253	222	215	215
query59	3098	3109	3038	3038
query60	291	302	276	276
query61	117	111	130	111
query62	827	746	737	737
query63	235	207	205	205
query64	3632	995	643	643
query65	3445	3327	3386	3327
query66	859	414	321	321
query67	16458	15940	15627	15627
query68	7714	849	532	532
query69	502	315	270	270
query70	1254	1121	1122	1121
query71	389	305	283	283
query72	5691	3806	3743	3743
query73	643	760	351	351
query74	10208	9164	9097	9097
query75	3258	3182	2701	2701
query76	3089	1168	807	807
query77	538	364	278	278
query78	10334	10410	9706	9706
query79	4209	878	589	589
query80	865	523	447	447
query81	508	256	219	219
query82	574	119	88	88
query83	173	169	151	151
query84	291	101	86	86
query85	783	357	305	305
query86	408	321	304	304
query87	4315	4373	4298	4298
query88	4983	2406	2401	2401
query89	418	344	299	299
query90	1754	193	195	193
query91	140	150	111	111
query92	66	62	56	56
query93	2702	918	545	545
query94	682	428	319	319
query95	354	295	281	281
query96	486	607	281	281
query97	3195	3284	3168	3168
query98	244	210	205	205
query99	1570	1436	1280	1280
Total cold run time: 296121 ms
Total hot run time: 192723 ms

@doris-robot
Copy link

doris-robot commented Aug 29, 2025

ClickBench: Total hot run time: 28.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0161a4ffe76a41d2b88027a6be9dd13971a1b248, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.52	0.52	0.53
query6	1.12	0.73	0.74
query7	0.03	0.02	0.01
query8	0.05	0.03	0.03
query9	0.56	0.51	0.49
query10	0.55	0.57	0.55
query11	0.16	0.10	0.10
query12	0.14	0.12	0.12
query13	0.63	0.61	0.60
query14	0.78	0.83	0.78
query15	0.84	0.85	0.82
query16	0.37	0.38	0.39
query17	1.03	0.99	1.08
query18	0.25	0.22	0.23
query19	1.85	1.91	1.75
query20	0.01	0.01	0.01
query21	15.39	0.94	0.56
query22	0.75	0.79	0.67
query23	15.12	1.41	0.64
query24	3.46	0.85	0.29
query25	0.16	0.09	0.07
query26	0.28	0.15	0.14
query27	0.05	0.06	0.04
query28	12.47	1.08	0.42
query29	12.55	3.93	3.26
query30	0.26	0.10	0.07
query31	2.80	0.60	0.37
query32	3.22	0.54	0.46
query33	3.00	3.00	3.02
query34	16.85	5.23	4.53
query35	4.62	4.54	4.62
query36	0.66	0.51	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 102.97 s
Total hot run time: 28.21 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 29, 2025

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

@yujun777
Copy link
Contributor Author

yujun777 commented Sep 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2025

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-H: Total hot run time: 33140 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2cd28c1975e3f8bd339e984481333354e0a4254, data reload: false

------ Round 1 ----------------------------------
q1	17757	5606	5581	5581
q2	2024	409	278	278
q3	12039	1265	783	783
q4	10251	891	466	466
q5	8287	2464	2173	2173
q6	187	168	136	136
q7	922	771	633	633
q8	9324	1459	1213	1213
q9	5271	5037	4950	4950
q10	6789	2293	1833	1833
q11	471	285	279	279
q12	341	368	219	219
q13	17768	3594	3027	3027
q14	235	225	204	204
q15	536	460	459	459
q16	428	434	368	368
q17	610	880	381	381
q18	7082	6384	6428	6384
q19	1527	977	574	574
q20	325	340	207	207
q21	2850	2186	2015	2015
q22	1043	984	977	977
Total cold run time: 106067 ms
Total hot run time: 33140 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6013	5616	5613	5613
q2	233	328	235	235
q3	2291	2674	2279	2279
q4	1373	1831	1397	1397
q5	4445	5047	5003	5003
q6	176	164	133	133
q7	2072	2012	1853	1853
q8	2688	2887	2738	2738
q9	7327	7275	7224	7224
q10	3089	3323	2774	2774
q11	592	527	498	498
q12	672	756	590	590
q13	3450	3825	3163	3163
q14	270	298	286	286
q15	519	467	475	467
q16	422	497	446	446
q17	1248	1755	1239	1239
q18	7708	7436	7396	7396
q19	843	1005	1198	1005
q20	2017	2054	1892	1892
q21	5457	5014	4677	4677
q22	1086	1124	1030	1030
Total cold run time: 53991 ms
Total hot run time: 51938 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

TPC-DS: Total hot run time: 191914 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d2cd28c1975e3f8bd339e984481333354e0a4254, data reload: false

query1	958	414	406	406
query2	6229	2004	1991	1991
query3	8693	204	201	201
query4	33673	23669	23419	23419
query5	3510	588	466	466
query6	296	198	186	186
query7	4205	495	312	312
query8	306	231	229	229
query9	9394	2613	2614	2613
query10	497	330	259	259
query11	17941	15455	15235	15235
query12	146	109	112	109
query13	1559	548	427	427
query14	9621	6848	6702	6702
query15	236	196	183	183
query16	8013	686	487	487
query17	1563	759	605	605
query18	2098	429	343	343
query19	223	191	171	171
query20	138	118	115	115
query21	203	134	112	112
query22	4671	4659	4413	4413
query23	35140	34387	33679	33679
query24	8042	2716	2741	2716
query25	562	497	440	440
query26	1355	322	175	175
query27	2633	490	368	368
query28	5913	2227	2202	2202
query29	790	623	466	466
query30	236	198	165	165
query31	1024	972	833	833
query32	96	60	63	60
query33	520	368	350	350
query34	774	860	538	538
query35	797	821	718	718
query36	1012	1052	947	947
query37	104	91	72	72
query38	4002	4062	4032	4032
query39	1515	1470	1470	1470
query40	212	123	105	105
query41	50	55	46	46
query42	127	107	107	107
query43	519	516	497	497
query44	1356	829	827	827
query45	189	179	176	176
query46	892	1056	684	684
query47	2016	1995	1889	1889
query48	431	441	357	357
query49	760	496	404	404
query50	687	707	447	447
query51	7376	7444	7191	7191
query52	99	102	93	93
query53	230	258	193	193
query54	551	553	478	478
query55	82	75	79	75
query56	282	265	272	265
query57	1265	1291	1226	1226
query58	234	226	226	226
query59	3166	3295	3039	3039
query60	289	290	283	283
query61	114	109	131	109
query62	796	768	687	687
query63	235	200	195	195
query64	4524	995	644	644
query65	3419	3279	3265	3265
query66	942	416	315	315
query67	16444	15957	15421	15421
query68	7742	839	559	559
query69	496	310	270	270
query70	1186	1110	1109	1109
query71	374	319	267	267
query72	5706	3782	3833	3782
query73	635	745	356	356
query74	10393	9295	9066	9066
query75	3208	3126	2689	2689
query76	2969	1176	789	789
query77	471	374	276	276
query78	10357	10586	9699	9699
query79	2865	876	617	617
query80	697	523	430	430
query81	515	263	222	222
query82	471	128	92	92
query83	163	167	144	144
query84	236	107	83	83
query85	774	361	304	304
query86	399	314	292	292
query87	4302	4353	4255	4255
query88	5266	2458	2438	2438
query89	413	332	301	301
query90	1784	192	193	192
query91	136	138	110	110
query92	65	56	53	53
query93	2014	937	561	561
query94	678	382	321	321
query95	343	280	268	268
query96	501	612	286	286
query97	3244	3303	3124	3124
query98	232	206	206	206
query99	1732	1392	1294	1294
Total cold run time: 296342 ms
Total hot run time: 191914 ms

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

ClickBench: Total hot run time: 28.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d2cd28c1975e3f8bd339e984481333354e0a4254, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.02	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.11
query5	0.53	0.52	0.52
query6	1.13	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.57	0.50	0.49
query10	0.56	0.56	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	0.77	0.81	0.80
query15	0.84	0.83	0.83
query16	0.38	0.38	0.38
query17	1.06	1.05	1.10
query18	0.24	0.22	0.23
query19	1.90	1.81	1.86
query20	0.02	0.01	0.01
query21	15.37	0.91	0.55
query22	0.76	0.73	0.65
query23	15.29	1.43	0.57
query24	3.69	1.67	0.95
query25	0.11	0.19	0.20
query26	0.25	0.15	0.14
query27	0.04	0.04	0.05
query28	13.58	0.96	0.44
query29	12.57	3.98	3.24
query30	0.25	0.08	0.06
query31	2.83	0.60	0.38
query32	3.23	0.54	0.46
query33	3.03	3.01	3.02
query34	16.81	5.24	4.55
query35	4.64	4.57	4.46
query36	0.66	0.49	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 104.54 s
Total hot run time: 28.95 s

@morrySnow morrySnow merged commit 6ad7fb2 into apache:branch-3.1 Sep 4, 2025
22 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yujun777 @Thearas @doris-robot @hello-stephen @morrySnow