Skip to content

branch-3.1: [fix](errmsg) recover errmsg for -230 #54697 #54731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 14, 2025
Merged

branch-3.1: [fix](errmsg) recover errmsg for -230 #54697 #54731

morrySnow merged 1 commit into from
Aug 14, 2025

Conversation

@dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Aug 14, 2025 •
edited by morrySnow
Loading

pick #54697

@dataroaring dataroaring requested a review from morrySnow as a code owner August 14, 2025 02:40
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Contributor Author

dataroaring commented Aug 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

TPC-H: Total hot run time: 32509 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ed49bdf4b73197ec668805c79bad2d51a724eee9, data reload: false

------ Round 1 ----------------------------------
q1	17584	5421	5456	5421
q2	2033	395	277	277
q3	12039	1221	758	758
q4	10280	858	438	438
q5	9136	2363	2099	2099
q6	178	163	131	131
q7	884	721	615	615
q8	9323	1396	1116	1116
q9	5316	4948	4944	4944
q10	6785	2271	1841	1841
q11	504	280	266	266
q12	326	349	208	208
q13	17766	3625	3014	3014
q14	247	221	217	217
q15	517	464	475	464
q16	450	428	364	364
q17	568	850	348	348
q18	6745	6443	6335	6335
q19	1206	945	537	537
q20	326	344	203	203
q21	2715	2102	1943	1943
q22	1054	1030	970	970
Total cold run time: 105982 ms
Total hot run time: 32509 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5474	5475	5475	5475
q2	225	320	239	239
q3	2227	2601	2322	2322
q4	1303	1816	1363	1363
q5	4405	4827	4919	4827
q6	169	165	134	134
q7	2021	1943	1813	1813
q8	2598	2815	2701	2701
q9	7286	7186	7208	7186
q10	3068	3312	2730	2730
q11	566	501	500	500
q12	657	756	591	591
q13	3354	3913	3277	3277
q14	284	310	301	301
q15	541	495	464	464
q16	455	515	435	435
q17	1273	1756	1276	1276
q18	7865	7414	7330	7330
q19	759	934	1143	934
q20	2011	2061	1911	1911
q21	5412	4856	4619	4619
q22	1076	1049	1016	1016
Total cold run time: 53029 ms
Total hot run time: 51444 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

TPC-DS: Total hot run time: 192233 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ed49bdf4b73197ec668805c79bad2d51a724eee9, data reload: false

query1	932	398	414	398
query2	6232	1913	1959	1913
query3	8691	198	198	198
query4	33749	23707	23394	23394
query5	3692	567	440	440
query6	279	188	193	188
query7	4195	478	317	317
query8	308	241	228	228
query9	9336	2590	2560	2560
query10	448	331	258	258
query11	18421	15366	15627	15366
query12	170	109	106	106
query13	1552	560	404	404
query14	10272	7369	6822	6822
query15	268	201	177	177
query16	8008	656	492	492
query17	1598	757	610	610
query18	2151	416	340	340
query19	231	188	185	185
query20	121	116	121	116
query21	209	128	108	108
query22	4624	4650	4489	4489
query23	35079	34289	34203	34203
query24	7571	2645	2703	2645
query25	540	502	450	450
query26	860	295	170	170
query27	1930	484	361	361
query28	5271	2217	2196	2196
query29	735	582	444	444
query30	244	192	165	165
query31	994	915	833	833
query32	91	65	59	59
query33	529	364	314	314
query34	742	868	522	522
query35	799	819	781	781
query36	983	1070	927	927
query37	96	90	67	67
query38	4065	4019	3943	3943
query39	1545	1478	1460	1460
query40	214	117	102	102
query41	50	50	46	46
query42	115	104	101	101
query43	524	524	491	491
query44	1329	828	834	828
query45	190	181	178	178
query46	896	1077	670	670
query47	1983	2028	1947	1947
query48	413	431	359	359
query49	744	491	426	426
query50	677	705	450	450
query51	7225	7290	7229	7229
query52	105	100	94	94
query53	228	262	202	202
query54	555	560	471	471
query55	78	80	79	79
query56	284	264	268	264
query57	1293	1267	1224	1224
query58	238	219	220	219
query59	3223	3335	3124	3124
query60	291	284	264	264
query61	121	159	130	130
query62	816	777	700	700
query63	231	195	192	192
query64	3832	993	659	659
query65	3413	3277	3284	3277
query66	824	409	311	311
query67	16331	15727	15504	15504
query68	7632	822	539	539
query69	489	306	273	273
query70	1177	1141	1090	1090
query71	394	303	258	258
query72	5720	3790	3966	3790
query73	625	752	359	359
query74	10162	9429	8894	8894
query75	3248	3070	2675	2675
query76	3133	1167	751	751
query77	517	378	266	266
query78	10272	10416	9668	9668
query79	3543	896	587	587
query80	798	513	445	445
query81	510	255	221	221
query82	571	117	88	88
query83	157	164	148	148
query84	241	98	73	73
query85	780	366	292	292
query86	396	314	302	302
query87	4327	4252	4235	4235
query88	5041	2407	2383	2383
query89	402	335	300	300
query90	1793	190	190	190
query91	145	141	111	111
query92	67	51	52	51
query93	2532	897	543	543
query94	674	397	293	293
query95	336	280	275	275
query96	484	598	280	280
query97	3213	3294	3175	3175
query98	233	206	196	196
query99	1494	1371	1292	1292
Total cold run time: 294890 ms
Total hot run time: 192233 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

ClickBench: Total hot run time: 28.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ed49bdf4b73197ec668805c79bad2d51a724eee9, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.50	0.53	0.51
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.03
query9	0.58	0.50	0.49
query10	0.57	0.56	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.61	0.60	0.61
query14	0.78	0.78	0.80
query15	0.84	0.83	0.82
query16	0.37	0.40	0.39
query17	1.03	1.03	1.06
query18	0.23	0.22	0.23
query19	1.83	1.79	1.71
query20	0.01	0.01	0.01
query21	15.39	0.94	0.58
query22	0.73	0.81	0.64
query23	15.12	1.43	0.51
query24	3.36	0.70	2.10
query25	0.13	0.08	0.09
query26	0.33	0.15	0.13
query27	0.05	0.05	0.05
query28	13.55	0.93	0.42
query29	12.56	4.03	3.33
query30	0.25	0.09	0.07
query31	2.83	0.60	0.37
query32	3.22	0.54	0.46
query33	3.02	3.03	3.05
query34	16.55	5.19	4.58
query35	4.56	4.50	4.57
query36	0.65	0.48	0.46
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.58 s
Total hot run time: 28.53 s

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

BE UT Coverage Report

Increment line coverage 57.14% (4/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.44% (12707/27964)
Line Coverage 36.32% (113196/311683)
Region Coverage 33.96% (64792/190801)
Branch Coverage 30.99% (33991/109692)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 57.14% (4/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.41% (21320/27542)
Line Coverage 71.67% (223001/311157)
Region Coverage 69.67% (133546/191696)
Branch Coverage 63.22% (69698/110250)

@morrySnow morrySnow changed the title [fix](errmsg) recover errmsg for -230 (#54697) branch-3.1: [fix](errmsg) recover errmsg for -230 #54697 Aug 14, 2025
@morrySnow morrySnow merged commit 058769d into apache:branch-3.1 Aug 14, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dataroaring @hello-stephen @doris-robot @morrySnow