Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Aug 4, 2025

cherry pick from #54227

Fix
1. cloud_decommission increased it robustness
2. test_cloud_full_compaction_multi_segments,
test_cloud_mow_retry_txn_interleave, test_cloud_concurrent_calc_dbm_task
fix its not set fe debug point
3. fix CloudTablet.capture_rs_readers.return.e-230 debug point not work,
due to apache#52440,
@deardeng deardeng requested a review from dataroaring as a code owner August 4, 2025 02:23
@deardeng
Copy link
Contributor Author

deardeng commented Aug 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 39772 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 45d988d4ea84bee1490798648e4f4e87ebf67ae2, data reload: false

------ Round 1 ----------------------------------
q1	17580	6846	6675	6675
q2	2073	192	155	155
q3	10531	1131	1160	1131
q4	10211	721	706	706
q5	7724	2858	2705	2705
q6	209	135	132	132
q7	965	624	626	624
q8	9360	1903	2030	1903
q9	6618	6353	6393	6353
q10	7040	2276	2287	2276
q11	470	261	263	261
q12	405	218	214	214
q13	17791	2988	2994	2988
q14	239	205	207	205
q15	513	463	468	463
q16	483	377	382	377
q17	964	584	577	577
q18	7092	6727	6713	6713
q19	1390	1080	1023	1023
q20	479	200	214	200
q21	4115	3110	3144	3110
q22	1089	999	981	981
Total cold run time: 107341 ms
Total hot run time: 39772 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6541	6533	6557	6533
q2	321	236	231	231
q3	2863	2973	2897	2897
q4	2065	1743	1830	1743
q5	5697	5737	5741	5737
q6	208	125	128	125
q7	2247	1845	1895	1845
q8	3399	3531	3594	3531
q9	8846	9052	9129	9052
q10	3600	3577	3569	3569
q11	598	496	505	496
q12	806	650	631	631
q13	8285	3363	3269	3269
q14	310	287	292	287
q15	513	460	474	460
q16	493	451	460	451
q17	1932	1648	1668	1648
q18	8496	8132	8104	8104
q19	1653	1502	1521	1502
q20	2064	1821	1877	1821
q21	5230	5118	5055	5055
q22	1115	1073	1049	1049
Total cold run time: 67282 ms
Total hot run time: 60036 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.89% (11135/26582)
Line Coverage 32.42% (95388/294253)
Region Coverage 31.56% (49275/156133)
Branch Coverage 28.00% (25254/90200)

@doris-robot
Copy link

TPC-DS: Total hot run time: 197057 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 45d988d4ea84bee1490798648e4f4e87ebf67ae2, data reload: false

query1	1279	946	890	890
query2	6326	1851	1860	1851
query3	10947	4637	4633	4633
query4	33453	23559	23943	23559
query5	4782	466	447	447
query6	283	191	191	191
query7	4001	309	323	309
query8	286	226	222	222
query9	9441	2587	2574	2574
query10	490	262	262	262
query11	18253	15290	15252	15252
query12	157	99	100	99
query13	1542	425	418	418
query14	8794	6843	7576	6843
query15	285	183	192	183
query16	7981	526	506	506
query17	1593	616	594	594
query18	2197	318	335	318
query19	383	165	162	162
query20	126	112	110	110
query21	219	111	110	110
query22	4675	4534	4598	4534
query23	35790	34050	34367	34050
query24	11263	2931	2866	2866
query25	677	418	418	418
query26	1264	174	176	174
query27	2396	362	351	351
query28	7287	2159	2162	2159
query29	879	483	465	465
query30	259	167	159	159
query31	1023	824	847	824
query32	93	57	53	53
query33	773	323	300	300
query34	927	525	528	525
query35	864	731	733	731
query36	1117	930	930	930
query37	130	62	70	62
query38	4115	3996	3974	3974
query39	1547	1443	1527	1443
query40	211	100	103	100
query41	49	51	47	47
query42	116	106	98	98
query43	519	481	489	481
query44	1320	794	809	794
query45	185	168	166	166
query46	1182	750	751	750
query47	1993	1880	1914	1880
query48	477	386	371	371
query49	890	421	410	410
query50	850	440	429	429
query51	7302	7351	7229	7229
query52	104	91	92	91
query53	255	193	196	193
query54	1105	459	464	459
query55	77	79	76	76
query56	266	245	229	229
query57	1323	1223	1198	1198
query58	223	211	238	211
query59	3151	2986	2993	2986
query60	288	259	264	259
query61	108	160	111	111
query62	866	672	690	672
query63	221	194	196	194
query64	4070	662	640	640
query65	3361	3291	3345	3291
query66	767	302	301	301
query67	15942	15437	15403	15403
query68	4490	582	557	557
query69	434	257	290	257
query70	1184	1115	1104	1104
query71	335	256	252	252
query72	6321	4107	4049	4049
query73	773	343	351	343
query74	10433	8942	9314	8942
query75	3380	2662	2664	2662
query76	2595	1008	1131	1008
query77	400	271	267	267
query78	10479	9622	9594	9594
query79	2565	606	628	606
query80	967	433	418	418
query81	551	225	230	225
query82	703	91	87	87
query83	257	145	143	143
query84	238	76	75	75
query85	1559	305	288	288
query86	461	306	271	271
query87	4366	4270	4315	4270
query88	4188	2363	2342	2342
query89	417	291	291	291
query90	1933	185	189	185
query91	184	151	148	148
query92	65	49	50	49
query93	2338	557	559	557
query94	818	288	286	286
query95	364	261	263	261
query96	666	277	279	277
query97	3256	3132	3172	3132
query98	227	196	206	196
query99	1508	1295	1324	1295
Total cold run time: 303573 ms
Total hot run time: 197057 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 45d988d4ea84bee1490798648e4f4e87ebf67ae2, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.10
query5	0.53	0.50	0.49
query6	1.13	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.48	0.51
query10	0.53	0.56	0.58
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.79	0.78	0.82
query15	0.85	0.81	0.81
query16	0.38	0.39	0.39
query17	1.03	1.00	1.00
query18	0.24	0.24	0.23
query19	1.82	1.74	1.86
query20	0.02	0.01	0.01
query21	15.39	0.59	0.56
query22	2.65	2.30	2.16
query23	16.93	1.11	0.79
query24	3.43	1.87	1.48
query25	0.18	0.22	0.07
query26	0.54	0.14	0.14
query27	0.04	0.05	0.04
query28	9.04	0.55	0.47
query29	12.56	3.24	3.26
query30	0.25	0.07	0.06
query31	2.85	0.38	0.37
query32	3.26	0.47	0.47
query33	3.02	2.97	3.03
query34	16.98	4.49	4.52
query35	4.57	4.59	4.61
query36	0.66	0.48	0.46
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.65 s
Total hot run time: 30.96 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.00% (19676/26236)
Line Coverage 68.22% (200488/293888)
Region Coverage 66.35% (119979/180836)
Branch Coverage 59.68% (60860/101982)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit d6ac40a into apache:branch-3.0 Aug 4, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants