Skip to content

[fix](replica) Get tablet replica infos should return all primary backends except for warmup jobs #54131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Aug 4, 2025
Merged

[fix](replica) Get tablet replica infos should return all primary backends except for warmup jobs #54131

dataroaring merged 2 commits into from
Aug 4, 2025

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Jul 31, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

Fix logic conflict of #52514 and #52440

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Hastyshell Hastyshell requested a review from dataroaring as a code owner July 31, 2025 03:03
@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 31, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 31, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Jul 31, 2025

TPC-H: Total hot run time: 39405 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2058cb6f4b80508268b8368ea4b23e453cccd624, data reload: false

------ Round 1 ----------------------------------
q1	17804	7012	6602	6602
q2	2070	159	153	153
q3	10705	1114	1116	1114
q4	10465	740	717	717
q5	7747	2814	2780	2780
q6	219	134	130	130
q7	991	604	592	592
q8	9345	1900	2016	1900
q9	6594	6412	6379	6379
q10	7035	2232	2267	2232
q11	466	257	245	245
q12	396	209	208	208
q13	17768	2958	3017	2958
q14	220	207	197	197
q15	515	459	472	459
q16	496	378	365	365
q17	967	569	552	552
q18	7133	6666	6676	6666
q19	1393	1066	1060	1060
q20	482	195	196	195
q21	3824	2943	3036	2943
q22	1075	991	958	958
Total cold run time: 107710 ms
Total hot run time: 39405 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6627	6592	6614	6592
q2	327	228	233	228
q3	2907	2966	2957	2957
q4	2081	1806	1892	1806
q5	5776	5841	5782	5782
q6	217	133	132	132
q7	2182	1816	1825	1816
q8	3421	3596	3536	3536
q9	8928	8957	8936	8936
q10	3571	3544	3515	3515
q11	587	519	506	506
q12	822	637	609	609
q13	7723	3140	3137	3137
q14	289	262	266	262
q15	514	467	466	466
q16	477	443	431	431
q17	1834	1616	1621	1616
q18	8128	7862	7726	7726
q19	1669	1510	1518	1510
q20	2130	1830	1783	1783
q21	5028	5047	4877	4877
q22	1117	1041	1065	1041
Total cold run time: 66355 ms
Total hot run time: 59264 ms

@doris-robot
Copy link

doris-robot commented Jul 31, 2025

TPC-DS: Total hot run time: 195565 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2058cb6f4b80508268b8368ea4b23e453cccd624, data reload: false

query1	1281	877	869	869
query2	6346	1912	1841	1841
query3	10977	4465	4434	4434
query4	33245	23743	23903	23743
query5	4340	456	431	431
query6	270	184	168	168
query7	3978	309	314	309
query8	278	228	223	223
query9	9401	2562	2537	2537
query10	471	274	251	251
query11	18021	15232	15185	15185
query12	152	101	101	101
query13	1576	429	409	409
query14	9515	6597	6815	6597
query15	228	185	199	185
query16	7892	440	496	440
query17	1613	604	620	604
query18	2054	314	309	309
query19	224	169	165	165
query20	123	126	116	116
query21	208	113	120	113
query22	4913	4319	4363	4319
query23	34561	33722	33873	33722
query24	11685	2911	2882	2882
query25	693	420	423	420
query26	1713	176	164	164
query27	3009	335	342	335
query28	7574	2146	2135	2135
query29	1049	458	449	449
query30	264	171	163	163
query31	1026	825	835	825
query32	93	59	62	59
query33	759	293	284	284
query34	1041	505	526	505
query35	884	727	728	727
query36	1098	961	978	961
query37	132	68	64	64
query38	4046	3945	3972	3945
query39	1515	1605	1459	1459
query40	261	99	96	96
query41	48	47	47	47
query42	115	100	95	95
query43	515	473	465	465
query44	1280	789	806	789
query45	186	169	168	168
query46	1148	757	720	720
query47	1991	1881	1877	1877
query48	478	366	373	366
query49	1067	402	385	385
query50	850	424	422	422
query51	7480	7314	7282	7282
query52	99	86	88	86
query53	263	183	184	183
query54	1315	465	459	459
query55	78	76	83	76
query56	274	243	237	237
query57	1309	1192	1188	1188
query58	234	202	208	202
query59	3098	2947	3086	2947
query60	295	251	253	251
query61	108	143	109	109
query62	887	686	685	685
query63	234	198	192	192
query64	5147	670	632	632
query65	3313	3319	3310	3310
query66	1320	313	307	307
query67	16176	15452	15455	15452
query68	4862	571	554	554
query69	436	255	256	255
query70	1206	1082	1113	1082
query71	323	252	245	245
query72	6325	4041	3981	3981
query73	763	342	341	341
query74	10254	9147	8995	8995
query75	3367	2623	2666	2623
query76	2649	1038	995	995
query77	374	264	283	264
query78	10588	9591	9458	9458
query79	1662	591	588	588
query80	1064	422	417	417
query81	534	210	215	210
query82	948	85	85	85
query83	230	137	143	137
query84	235	76	83	76
query85	1379	293	287	287
query86	380	307	293	293
query87	4390	4263	4203	4203
query88	3378	2348	2302	2302
query89	417	286	296	286
query90	1939	178	183	178
query91	181	146	145	145
query92	56	49	50	49
query93	1810	542	534	534
query94	871	303	301	301
query95	360	249	251	249
query96	606	280	277	277
query97	3313	3160	3158	3158
query98	208	192	193	192
query99	1505	1358	1329	1329
Total cold run time: 304430 ms
Total hot run time: 195565 ms

@doris-robot
Copy link

doris-robot commented Jul 31, 2025

ClickBench: Total hot run time: 29.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2058cb6f4b80508268b8368ea4b23e453cccd624, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.54	0.53	0.54
query6	1.14	0.72	0.73
query7	0.03	0.02	0.01
query8	0.04	0.04	0.03
query9	0.57	0.49	0.49
query10	0.54	0.58	0.54
query11	0.14	0.09	0.10
query12	0.13	0.11	0.11
query13	0.60	0.58	0.60
query14	0.77	0.80	0.82
query15	0.83	0.81	0.81
query16	0.38	0.38	0.39
query17	0.99	1.00	1.04
query18	0.24	0.22	0.22
query19	1.99	1.89	1.80
query20	0.01	0.02	0.01
query21	15.38	0.58	0.58
query22	2.62	1.66	1.13
query23	17.02	1.09	0.79
query24	3.27	0.64	1.62
query25	0.12	0.13	0.18
query26	0.47	0.14	0.14
query27	0.04	0.06	0.05
query28	10.12	0.53	0.48
query29	12.60	3.25	3.19
query30	0.25	0.06	0.06
query31	2.85	0.38	0.40
query32	3.23	0.46	0.45
query33	2.96	2.96	3.05
query34	16.95	4.51	4.57
query35	4.54	4.54	4.51
query36	0.69	0.47	0.46
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 104.47 s
Total hot run time: 29.11 s

dataroaring
dataroaring approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring force-pushed the fix-get-replica-info-logic-conflict branch from d67c7ac to f6a4908 Compare August 3, 2025 02:46
@dataroaring
Copy link
Contributor

dataroaring commented Aug 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 3, 2025

TPC-H: Total hot run time: 39869 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f6a4908cd43130bc4d901aad345510c461bd27fe, data reload: false

------ Round 1 ----------------------------------
q1	17603	7111	6659	6659
q2	2048	201	206	201
q3	10567	1121	1118	1118
q4	10255	766	776	766
q5	7720	2886	2871	2871
q6	216	134	134	134
q7	972	614	616	614
q8	9593	1893	2033	1893
q9	7671	6387	6435	6387
q10	6988	2274	2270	2270
q11	443	261	263	261
q12	402	209	221	209
q13	17761	2997	3024	2997
q14	237	213	207	207
q15	520	467	472	467
q16	500	386	373	373
q17	973	597	526	526
q18	7307	6625	6701	6625
q19	1389	1043	1102	1043
q20	465	197	206	197
q21	3882	3053	3182	3053
q22	1107	1002	998	998
Total cold run time: 108619 ms
Total hot run time: 39869 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6638	6603	6642	6603
q2	322	227	231	227
q3	2934	2929	2902	2902
q4	2105	1765	1827	1765
q5	5721	5722	5744	5722
q6	210	131	138	131
q7	2202	1816	1824	1816
q8	3366	3572	3534	3534
q9	8856	8950	8897	8897
q10	3556	3514	3557	3514
q11	586	477	511	477
q12	816	628	596	596
q13	7938	3162	3152	3152
q14	309	266	269	266
q15	526	474	476	474
q16	494	442	446	442
q17	1853	1664	1616	1616
q18	8287	7880	7715	7715
q19	1661	1545	1517	1517
q20	2083	1869	1874	1869
q21	5172	5016	4931	4931
q22	1122	1095	1021	1021
Total cold run time: 66757 ms
Total hot run time: 59187 ms

@doris-robot
Copy link

doris-robot commented Aug 3, 2025

TPC-DS: Total hot run time: 195702 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f6a4908cd43130bc4d901aad345510c461bd27fe, data reload: false

query1	1263	921	882	882
query2	6256	1859	1859	1859
query3	11006	4562	4753	4562
query4	36137	23604	23740	23604
query5	4057	474	455	455
query6	277	201	188	188
query7	4022	308	325	308
query8	289	225	221	221
query9	9512	2586	2583	2583
query10	447	261	272	261
query11	16826	15181	15275	15181
query12	159	100	104	100
query13	1544	443	413	413
query14	8882	7536	7289	7289
query15	258	185	182	182
query16	7957	514	454	454
query17	1699	591	600	591
query18	2127	324	308	308
query19	228	169	164	164
query20	125	116	117	116
query21	203	109	113	109
query22	4813	4450	4459	4450
query23	34862	33926	34437	33926
query24	11245	2939	2999	2939
query25	621	452	425	425
query26	1058	179	171	171
query27	2480	369	356	356
query28	7727	2157	2170	2157
query29	768	502	446	446
query30	261	169	170	169
query31	1011	852	823	823
query32	102	57	54	54
query33	724	292	297	292
query34	1144	516	519	516
query35	849	740	709	709
query36	1097	942	933	933
query37	117	71	70	70
query38	4044	4039	4056	4039
query39	1520	1481	1556	1481
query40	203	99	100	99
query41	51	48	54	48
query42	122	104	101	101
query43	517	474	483	474
query44	1348	808	841	808
query45	189	177	168	168
query46	1133	733	734	733
query47	2030	1891	1951	1891
query48	474	373	378	373
query49	959	402	400	400
query50	847	439	430	430
query51	7412	7243	7243	7243
query52	100	96	96	96
query53	264	188	192	188
query54	1147	476	474	474
query55	89	77	76	76
query56	265	246	241	241
query57	1315	1240	1223	1223
query58	222	210	204	204
query59	3154	2928	2867	2867
query60	283	280	262	262
query61	114	111	141	111
query62	868	697	717	697
query63	225	191	194	191
query64	3991	682	642	642
query65	3367	3308	3270	3270
query66	751	292	299	292
query67	15907	15516	15415	15415
query68	4589	599	561	561
query69	425	265	258	258
query70	1197	1132	1155	1132
query71	328	262	255	255
query72	6242	4081	2467	2467
query73	756	338	338	338
query74	10215	9356	8857	8857
query75	3397	2667	2697	2667
query76	2372	1080	1060	1060
query77	400	287	282	282
query78	10593	9616	9562	9562
query79	1707	594	592	592
query80	1234	432	428	428
query81	545	224	222	222
query82	955	97	89	89
query83	233	147	145	145
query84	238	82	82	82
query85	1369	297	300	297
query86	407	297	295	295
query87	4440	4253	4284	4253
query88	3691	2350	2347	2347
query89	413	297	297	297
query90	1887	188	187	187
query91	190	171	151	151
query92	59	51	50	50
query93	1895	556	555	555
query94	860	302	297	297
query95	365	254	259	254
query96	607	280	277	277
query97	3296	3171	3134	3134
query98	215	212	197	197
query99	1553	1319	1311	1311
Total cold run time: 301737 ms
Total hot run time: 195702 ms

@doris-robot
Copy link

doris-robot commented Aug 3, 2025

ClickBench: Total hot run time: 30.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f6a4908cd43130bc4d901aad345510c461bd27fe, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.52	0.52	0.51
query6	1.13	0.73	0.74
query7	0.02	0.03	0.01
query8	0.04	0.04	0.03
query9	0.56	0.51	0.50
query10	0.55	0.56	0.55
query11	0.15	0.11	0.10
query12	0.13	0.11	0.12
query13	0.60	0.60	0.59
query14	0.77	0.80	0.80
query15	0.84	0.83	0.83
query16	0.40	0.37	0.39
query17	1.07	1.06	1.05
query18	0.21	0.22	0.22
query19	1.95	1.81	1.76
query20	0.01	0.01	0.01
query21	15.40	0.60	0.57
query22	2.25	1.88	1.58
query23	17.20	0.95	0.93
query24	2.93	1.37	1.72
query25	0.31	0.20	0.06
query26	0.44	0.13	0.14
query27	0.06	0.04	0.03
query28	9.70	0.53	0.44
query29	12.62	3.20	3.18
query30	0.26	0.06	0.06
query31	2.86	0.38	0.39
query32	3.24	0.46	0.46
query33	3.00	2.96	2.99
query34	16.78	4.53	4.59
query35	4.56	4.56	4.57
query36	0.65	0.49	0.48
query37	0.08	0.06	0.07
query38	0.05	0.03	0.03
query39	0.04	0.02	0.03
query40	0.16	0.14	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.65 s
Total hot run time: 30.41 s

@dataroaring dataroaring merged commit 64a5781 into apache:branch-3.0 Aug 4, 2025
23 checks passed
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged p0_new reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hastyshell @hello-stephen @doris-robot @dataroaring