Skip to content

[Bug](fold) skip INET6_ATON function in fold by BE (#53423) #54013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Aug 1, 2025
Merged

[Bug](fold) skip INET6_ATON function in fold by BE (#53423) #54013

yiguolei merged 1 commit into from
Aug 1, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jul 29, 2025

What problem does this PR solve?

Problem Summary:
cherry-pick from #53423

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zhangstar333
[Bug](fold) skip INET6_ATON function in fold by BE (apache#53423)
7514d62 
Problem Summary:
Now the Java StringLiteral can't handle binary data from C++,
it's will cause the result incorrect.
before the ipv6_string_to_num_or_default and INET6_ATON could fold by
BE,
after this PR, this two function will not fold by be.
@zhangstar333 zhangstar333 requested a review from yiguolei as a code owner July 29, 2025 04:46
@Thearas
Copy link
Contributor

Thearas commented Jul 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jul 29, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 3e0543a into apache:branch-2.1 Aug 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangstar333 @Thearas @yiguolei