Skip to content

branch-3.1: [Log](topn) Log query id in topn two read and change the timeout to query timeout #53450 #53822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 24, 2025
Merged

branch-3.1: [Log](topn) Log query id in topn two read and change the timeout to query timeout #53450 #53822

morrySnow merged 1 commit into from
Jul 24, 2025

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Jul 24, 2025 •
edited by morrySnow
Loading

picked from #53450

@HappenLee HappenLee requested a review from morrySnow as a code owner July 24, 2025 03:56
@Thearas
Copy link
Contributor

Thearas commented Jul 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

HappenLee commented Jul 24, 2025

run buildall

@morrySnow morrySnow changed the title [Log](topn) Log query id in topn two read and change the timeout to query timeout branch-3.1: [Log](topn) Log query id in topn two read and change the timeout to query timeout #52573 Jul 24, 2025
@doris-robot
Copy link

doris-robot commented Jul 24, 2025

TPC-H: Total hot run time: 32764 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb4f7dd858e39100ac7b2a2a2dedc6166a275d13, data reload: false

------ Round 1 ----------------------------------
q1	18431	6144	5509	5509
q2	2056	320	165	165
q3	10539	1357	734	734
q4	10221	894	463	463
q5	7993	2396	2101	2101
q6	182	160	132	132
q7	908	770	632	632
q8	9350	1472	1184	1184
q9	5298	4980	4981	4980
q10	6768	2274	1850	1850
q11	477	273	268	268
q12	337	355	205	205
q13	17767	3648	3018	3018
q14	249	225	217	217
q15	527	470	462	462
q16	419	434	379	379
q17	625	882	382	382
q18	7126	6346	6431	6346
q19	1274	958	541	541
q20	337	345	208	208
q21	2881	2202	1977	1977
q22	1052	1031	1011	1011
Total cold run time: 104817 ms
Total hot run time: 32764 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5580	5543	5546	5543
q2	227	330	246	246
q3	2305	2633	2280	2280
q4	1363	1819	1386	1386
q5	4409	5000	5074	5000
q6	171	168	132	132
q7	2095	1926	1763	1763
q8	2620	2801	2669	2669
q9	7183	7159	7204	7159
q10	3054	3327	2787	2787
q11	577	501	478	478
q12	654	768	586	586
q13	3369	3755	3234	3234
q14	276	305	290	290
q15	524	483	471	471
q16	448	490	439	439
q17	1209	1727	1275	1275
q18	7810	7523	7373	7373
q19	801	914	1118	914
q20	1981	2022	1898	1898
q21	5330	4954	4497	4497
q22	1158	1086	1033	1033
Total cold run time: 53144 ms
Total hot run time: 51453 ms

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 24, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.28% (12570/27761)
Line Coverage 36.18% (111919/309327)
Region Coverage 35.25% (57867/164172)
Branch Coverage 32.42% (31449/96990)

@doris-robot
Copy link

doris-robot commented Jul 24, 2025

TPC-DS: Total hot run time: 190535 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb4f7dd858e39100ac7b2a2a2dedc6166a275d13, data reload: false

query1	962	367	377	367
query2	6526	1930	1899	1899
query3	6715	215	216	215
query4	33745	23743	23460	23460
query5	4453	630	461	461
query6	266	197	194	194
query7	4621	491	321	321
query8	297	253	240	240
query9	9382	2622	2587	2587
query10	487	334	258	258
query11	18108	15455	15181	15181
query12	156	106	103	103
query13	1650	549	419	419
query14	9240	6687	7242	6687
query15	238	192	179	179
query16	8110	667	503	503
query17	1689	780	590	590
query18	2343	413	320	320
query19	207	203	169	169
query20	137	132	121	121
query21	207	129	112	112
query22	4730	4658	4725	4658
query23	35416	33629	33463	33463
query24	7393	2621	2627	2621
query25	516	462	412	412
query26	1197	281	168	168
query27	2344	474	350	350
query28	5274	2164	2125	2125
query29	777	576	468	468
query30	252	188	157	157
query31	970	892	809	809
query32	97	62	58	58
query33	535	386	313	313
query34	750	837	506	506
query35	764	780	705	705
query36	1005	1041	912	912
query37	102	101	70	70
query38	3838	3909	3805	3805
query39	1474	1425	1432	1425
query40	219	116	104	104
query41	52	53	51	51
query42	120	103	105	103
query43	494	514	479	479
query44	1302	810	812	810
query45	186	175	178	175
query46	875	1035	670	670
query47	1928	1930	1882	1882
query48	419	424	368	368
query49	798	533	434	434
query50	661	676	409	409
query51	7298	7210	7010	7010
query52	100	97	92	92
query53	241	251	183	183
query54	572	527	458	458
query55	81	78	77	77
query56	269	267	260	260
query57	1261	1210	1184	1184
query58	234	217	221	217
query59	2973	2964	2985	2964
query60	278	286	268	268
query61	117	111	114	111
query62	824	725	683	683
query63	221	186	185	185
query64	4662	1010	636	636
query65	3291	3161	3192	3161
query66	869	409	307	307
query67	15996	15749	15648	15648
query68	8154	848	540	540
query69	471	316	265	265
query70	1250	1125	1081	1081
query71	585	304	267	267
query72	5626	3723	3851	3723
query73	643	733	360	360
query74	10200	9125	9175	9125
query75	3493	3166	2676	2676
query76	3213	1176	761	761
query77	656	361	273	273
query78	10718	10393	9617	9617
query79	3581	884	592	592
query80	713	525	445	445
query81	491	256	226	226
query82	669	118	92	92
query83	178	159	150	150
query84	281	101	76	76
query85	801	382	296	296
query86	360	325	309	309
query87	4311	4359	4238	4238
query88	5022	2396	2376	2376
query89	405	322	291	291
query90	1842	186	184	184
query91	150	141	111	111
query92	64	57	52	52
query93	1465	821	554	554
query94	686	415	300	300
query95	338	275	259	259
query96	500	627	292	292
query97	3178	3283	3189	3189
query98	233	217	195	195
query99	1583	1402	1280	1280
Total cold run time: 295174 ms
Total hot run time: 190535 ms

@doris-robot
Copy link

doris-robot commented Jul 24, 2025

ClickBench: Total hot run time: 28.85 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb4f7dd858e39100ac7b2a2a2dedc6166a275d13, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.02
query3	0.24	0.07	0.07
query4	1.63	0.10	0.10
query5	0.53	0.51	0.50
query6	1.12	0.73	0.73
query7	0.02	0.02	0.02
query8	0.03	0.03	0.03
query9	0.57	0.50	0.51
query10	0.55	0.58	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	0.77	0.78	0.83
query15	0.84	0.83	0.82
query16	0.39	0.38	0.39
query17	1.08	0.98	1.02
query18	0.24	0.23	0.22
query19	1.96	1.87	1.81
query20	0.01	0.01	0.01
query21	15.40	0.91	0.59
query22	0.74	0.83	0.76
query23	15.00	1.38	0.60
query24	2.71	0.94	1.59
query25	0.19	0.22	0.07
query26	0.27	0.14	0.13
query27	0.06	0.05	0.05
query28	14.19	1.02	0.42
query29	12.56	3.92	3.25
query30	0.24	0.09	0.07
query31	2.83	0.58	0.39
query32	3.22	0.53	0.45
query33	2.97	3.03	3.02
query34	16.59	5.19	4.47
query35	4.56	4.51	4.61
query36	0.62	0.49	0.47
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.61 s
Total hot run time: 28.85 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (20878/27428)
Line Coverage 69.44% (214643/309090)
Region Coverage 67.50% (128455/190303)
Branch Coverage 61.04% (66794/109424)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.12% (20879/27428)
Line Coverage 69.45% (214661/309090)
Region Coverage 67.51% (128474/190303)
Branch Coverage 61.06% (66810/109424)

@morrySnow morrySnow merged commit a844184 into apache:branch-3.1 Jul 24, 2025
24 of 25 checks passed
@morrySnow morrySnow changed the title branch-3.1: [Log](topn) Log query id in topn two read and change the timeout to query timeout #52573 branch-3.1: [Log](topn) Log query id in topn two read and change the timeout to query timeout #53450 Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HappenLee @Thearas @doris-robot @hello-stephen @morrySnow