Skip to content

branch-3.1: [Bug](fold) skip INET6_ATON function in fold by BE #53423 #53780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 24, 2025
Merged

branch-3.1: [Bug](fold) skip INET6_ATON function in fold by BE #53423 #53780

morrySnow merged 1 commit into from
Jul 24, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 23, 2025

Cherry-picked from #53423

@zhangstar333
[Bug](fold) skip INET6_ATON function in fold by BE (#53423)
d611752 
### What problem does this PR solve?
Problem Summary:
Now the Java StringLiteral can't handle binary data from C++,
it's will cause the result incorrect. 
before the ipv6_string_to_num_or_default and INET6_ATON could fold by
BE,
after this PR, this two function will not fold by be.
@github-actions github-actions bot requested a review from morrySnow as a code owner July 23, 2025 08:42
@Thearas
Copy link
Contributor

Thearas commented Jul 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 23, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 23, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 23, 2025

TPC-H: Total hot run time: 32547 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d6117520e3df4b5abb1e1e90368965b378b5c57d, data reload: false

------ Round 1 ----------------------------------
q1	17591	5497	5357	5357
q2	2057	279	158	158
q3	10454	1301	741	741
q4	10201	872	452	452
q5	8418	2400	2122	2122
q6	177	166	132	132
q7	890	727	623	623
q8	9331	1438	1167	1167
q9	5581	4960	4883	4883
q10	6771	2284	1843	1843
q11	479	292	264	264
q12	336	361	208	208
q13	17795	3791	2983	2983
q14	234	228	207	207
q15	512	484	464	464
q16	415	429	390	390
q17	628	876	376	376
q18	6906	6406	6518	6406
q19	1207	961	556	556
q20	341	339	213	213
q21	3006	2160	1983	1983
q22	1086	1026	1019	1019
Total cold run time: 104416 ms
Total hot run time: 32547 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5526	5527	5496	5496
q2	235	340	241	241
q3	2265	2620	2300	2300
q4	1340	1783	1321	1321
q5	4401	4876	5060	4876
q6	172	162	122	122
q7	2091	1920	1805	1805
q8	2646	2779	2639	2639
q9	7190	7104	7083	7083
q10	3024	3332	2830	2830
q11	584	507	498	498
q12	683	750	601	601
q13	3313	3758	3242	3242
q14	285	295	287	287
q15	509	495	469	469
q16	440	480	452	452
q17	1212	1740	1258	1258
q18	7610	7441	7245	7245
q19	784	1032	1123	1032
q20	1973	2085	1877	1877
q21	5302	4836	4716	4716
q22	1131	1076	1012	1012
Total cold run time: 52716 ms
Total hot run time: 51402 ms

@doris-robot
Copy link

doris-robot commented Jul 23, 2025

TPC-DS: Total hot run time: 190679 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d6117520e3df4b5abb1e1e90368965b378b5c57d, data reload: false

query1	992	391	358	358
query2	6534	1983	1931	1931
query3	6710	214	216	214
query4	33984	23643	23448	23448
query5	4313	610	477	477
query6	265	183	174	174
query7	4621	494	322	322
query8	297	236	224	224
query9	9458	2565	2555	2555
query10	459	327	264	264
query11	18425	15336	15206	15206
query12	156	109	104	104
query13	1639	563	424	424
query14	9257	6770	7336	6770
query15	237	193	178	178
query16	8127	621	511	511
query17	1749	768	622	622
query18	2200	411	331	331
query19	237	197	166	166
query20	119	116	115	115
query21	212	129	111	111
query22	4686	4556	4489	4489
query23	34584	33509	33800	33509
query24	7192	2650	2651	2650
query25	518	467	411	411
query26	1209	280	169	169
query27	2382	450	342	342
query28	5436	2137	2111	2111
query29	748	590	469	469
query30	251	191	163	163
query31	960	873	807	807
query32	88	61	59	59
query33	516	375	306	306
query34	744	824	516	516
query35	758	800	717	717
query36	996	1035	967	967
query37	105	95	70	70
query38	3840	3911	3907	3907
query39	1504	1433	1462	1433
query40	215	119	109	109
query41	53	54	50	50
query42	115	103	103	103
query43	513	519	475	475
query44	1290	806	807	806
query45	191	176	173	173
query46	874	1023	672	672
query47	1908	1946	1884	1884
query48	412	425	353	353
query49	802	505	425	425
query50	667	673	412	412
query51	7269	7348	7070	7070
query52	104	101	93	93
query53	225	253	183	183
query54	545	526	454	454
query55	80	79	77	77
query56	285	264	270	264
query57	1264	1228	1189	1189
query58	243	230	211	211
query59	3025	3023	2941	2941
query60	305	273	274	273
query61	138	147	136	136
query62	872	727	671	671
query63	220	194	187	187
query64	4446	972	660	660
query65	3297	3159	3187	3159
query66	1048	409	312	312
query67	15889	16043	15667	15667
query68	7366	843	551	551
query69	477	321	269	269
query70	1248	1135	1079	1079
query71	574	325	262	262
query72	5683	3736	3758	3736
query73	647	738	349	349
query74	10467	9009	8895	8895
query75	3326	3122	2674	2674
query76	3444	1208	758	758
query77	572	381	272	272
query78	10412	10548	9659	9659
query79	3509	916	605	605
query80	647	548	455	455
query81	517	256	225	225
query82	656	115	92	92
query83	173	168	148	148
query84	245	107	86	86
query85	792	360	299	299
query86	400	325	290	290
query87	4327	4358	4263	4263
query88	5202	2418	2399	2399
query89	401	336	294	294
query90	1887	187	183	183
query91	141	144	108	108
query92	69	57	53	53
query93	1968	918	546	546
query94	694	403	315	315
query95	344	273	271	271
query96	493	610	294	294
query97	3170	3312	3128	3128
query98	230	222	202	202
query99	1594	1413	1310	1310
Total cold run time: 294478 ms
Total hot run time: 190679 ms

@doris-robot
Copy link

doris-robot commented Jul 23, 2025

ClickBench: Total hot run time: 28.6 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d6117520e3df4b5abb1e1e90368965b378b5c57d, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.08	0.07
query4	1.62	0.11	0.10
query5	0.52	0.53	0.53
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.55	0.56	0.56
query11	0.14	0.10	0.11
query12	0.15	0.12	0.12
query13	0.62	0.59	0.60
query14	0.78	0.80	0.82
query15	0.85	0.84	0.82
query16	0.39	0.38	0.38
query17	1.06	1.07	1.07
query18	0.23	0.23	0.23
query19	1.97	1.76	1.90
query20	0.02	0.01	0.01
query21	15.37	0.94	0.60
query22	0.74	0.72	0.62
query23	15.25	1.42	0.51
query24	3.26	1.80	0.68
query25	0.14	0.13	0.04
query26	0.38	0.15	0.13
query27	0.05	0.05	0.07
query28	13.45	1.02	0.43
query29	12.64	3.94	3.29
query30	0.25	0.09	0.06
query31	2.83	0.60	0.39
query32	3.22	0.53	0.46
query33	2.97	3.02	3.06
query34	16.51	5.19	4.55
query35	4.57	4.53	4.55
query36	0.64	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 103.77 s
Total hot run time: 28.6 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 23, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit aa77d5c into branch-3.1 Jul 24, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-53423-branch-3.1 branch July 24, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Thearas @doris-robot @hello-stephen @morrySnow @dataroaring @zhangstar333