Skip to content

branch-3.0: [fix](csv reader) fix data loss when concurrency read using multi char line delimiter (#53374) #53634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 21, 2025
Merged

branch-3.0: [fix](csv reader) fix data loss when concurrency read using multi char line delimiter (#53374) #53634

dataroaring merged 1 commit into from
Jul 21, 2025

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Jul 21, 2025

pick (#53374)

Multiple concurrent split file locations will be determined in plan phase, if the split point happens to be in the middle of the multi char line delimiter:

  • The previous concurrent will read the complete row1 and read a little more to read the line delimiter.
  • The latter concurrency will start reading from half of the multi char line delimiter, and row2 is the first line of this concurrency, but the first line in the middle range is always discarded, so row2 will be lost.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@sollhui
[fix](csv reader) fix data loss when concurrency read using multi cha…
8278cd0 
…r line delimiter (apache#53374)

Multiple concurrent split file locations will be determined in plan
phase, if the split point happens to be in the middle of the multi char
line delimiter:

- The previous concurrent will read the complete row1 and read a little
more to read the line delimiter.
- The latter concurrency will start reading from half of the multi char
line delimiter, and row2 is the first line of this concurrency, but the
first line in the middle range is always discarded, so row2 will be
lost.
@sollhui sollhui requested a review from dataroaring as a code owner July 21, 2025 06:46
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui sollhui changed the title branch-3.1: [fix](csv reader) fix data loss when concurrency read using multi char line delimiter (#53374) branch-3.0: [fix](csv reader) fix data loss when concurrency read using multi char line delimiter (#53374) Jul 21, 2025
@sollhui
Copy link
Contributor Author

sollhui commented Jul 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 21, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.89% (11135/26579)
Line Coverage 32.44% (95397/294098)
Region Coverage 31.57% (49264/156048)
Branch Coverage 27.99% (25241/90184)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 21, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 50.87% (13344/26233)
Line Coverage 41.34% (121417/293702)
Region Coverage 38.97% (70430/180717)
Branch Coverage 33.37% (34018/101948)

dataroaring
dataroaring approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6e07b92 into apache:branch-3.0 Jul 21, 2025
20 of 25 checks passed
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sollhui @hello-stephen @doris-robot @dataroaring