Skip to content

branch-3.1: [opt](nereids) opt for adjustting slot nullable and add exception for changing slot nullable #52748 #53533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 3 commits into from
Jul 18, 2025
Merged

branch-3.1: [opt](nereids) opt for adjustting slot nullable and add exception for changing slot nullable #52748 #53533

morrySnow merged 3 commits into from
Jul 18, 2025

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Jul 18, 2025

cherry pick from #52748

@yujun777 yujun777 requested a review from morrySnow as a code owner July 18, 2025 07:43
@yujun777
Copy link
Contributor Author

yujun777 commented Jul 18, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Contributor Author

yujun777 commented Jul 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

TPC-H: Total hot run time: 39928 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73c6b96849485f79e70bd7eb664b9cb1eb7997c4, data reload: false

------ Round 1 ----------------------------------
q1	18136	7021	6676	6676
q2	2066	176	156	156
q3	10537	1156	1170	1156
q4	10499	752	705	705
q5	7747	2831	2835	2831
q6	215	137	137	137
q7	995	620	616	616
q8	9353	1924	2065	1924
q9	6682	6420	6441	6420
q10	6985	2274	2246	2246
q11	461	272	256	256
q12	398	214	207	207
q13	17790	2993	2966	2966
q14	240	204	207	204
q15	506	468	475	468
q16	474	394	378	378
q17	979	572	529	529
q18	7360	6675	6721	6675
q19	1314	1045	1053	1045
q20	476	213	201	201
q21	4001	3175	3150	3150
q22	1099	1007	982	982
Total cold run time: 108313 ms
Total hot run time: 39928 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6657	6598	6603	6598
q2	336	228	238	228
q3	2916	2999	3029	2999
q4	2057	1821	1815	1815
q5	5736	5750	5687	5687
q6	205	131	131	131
q7	2106	1761	1764	1761
q8	3358	3486	3511	3486
q9	8801	8877	8834	8834
q10	3571	3516	3494	3494
q11	590	489	485	485
q12	819	592	629	592
q13	4104	3167	3119	3119
q14	312	296	271	271
q15	518	476	473	473
q16	482	445	436	436
q17	1823	1618	1591	1591
q18	8144	7683	7692	7683
q19	1682	1603	1593	1593
q20	2098	1887	1838	1838
q21	5053	4742	4991	4742
q22	1106	1006	986	986
Total cold run time: 62474 ms
Total hot run time: 58842 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

TPC-DS: Total hot run time: 189921 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73c6b96849485f79e70bd7eb664b9cb1eb7997c4, data reload: false

query1	987	367	369	367
query2	6523	1885	1891	1885
query3	6702	226	234	226
query4	33888	23898	24081	23898
query5	4295	475	443	443
query6	268	170	177	170
query7	4616	307	313	307
query8	289	251	235	235
query9	9789	2607	2588	2588
query10	492	279	281	279
query11	18460	15042	15316	15042
query12	164	104	105	104
query13	1634	449	411	411
query14	9243	6816	7402	6816
query15	256	174	180	174
query16	8141	514	465	465
query17	1669	590	559	559
query18	2151	321	321	321
query19	399	163	156	156
query20	123	116	119	116
query21	220	111	105	105
query22	4440	4132	4306	4132
query23	34574	33727	33271	33271
query24	11565	2834	2840	2834
query25	685	414	424	414
query26	1435	178	178	178
query27	2932	341	339	339
query28	7890	2107	2132	2107
query29	921	442	449	442
query30	329	164	165	164
query31	1035	794	806	794
query32	101	62	63	62
query33	823	328	312	312
query34	935	502	528	502
query35	847	729	713	713
query36	1091	978	902	902
query37	143	74	71	71
query38	3912	3744	3823	3744
query39	1468	1457	1403	1403
query40	289	104	103	103
query41	54	52	52	52
query42	118	106	107	106
query43	513	479	482	479
query44	1220	792	800	792
query45	189	170	173	170
query46	1137	709	736	709
query47	1964	1835	1865	1835
query48	437	338	351	338
query49	1195	423	386	386
query50	816	417	410	410
query51	7315	7215	7099	7099
query52	107	95	95	95
query53	254	183	191	183
query54	1279	462	481	462
query55	80	79	81	79
query56	266	266	256	256
query57	1295	1154	1164	1154
query58	242	207	217	207
query59	3074	2867	2997	2867
query60	289	259	257	257
query61	113	108	107	107
query62	843	668	681	668
query63	212	188	194	188
query64	5506	661	656	656
query65	3296	3163	3189	3163
query66	1458	311	305	305
query67	15865	15672	15544	15544
query68	4086	609	571	571
query69	439	269	261	261
query70	1136	1140	1125	1125
query71	358	273	252	252
query72	6427	4051	4069	4051
query73	748	358	359	358
query74	9907	9389	8972	8972
query75	3399	2572	2669	2572
query76	2836	923	1129	923
query77	416	286	277	277
query78	10433	9516	9541	9516
query79	1083	602	599	599
query80	764	444	436	436
query81	488	225	222	222
query82	1301	90	88	88
query83	238	151	145	145
query84	237	79	87	79
query85	1124	311	298	298
query86	314	297	273	273
query87	4316	4166	4188	4166
query88	3595	2432	2394	2394
query89	400	296	292	292
query90	2085	190	187	187
query91	142	113	116	113
query92	61	51	54	51
query93	1075	560	548	548
query94	869	298	292	292
query95	376	255	262	255
query96	608	285	282	282
query97	3299	3132	3110	3110
query98	223	197	190	190
query99	1538	1321	1302	1302
Total cold run time: 299182 ms
Total hot run time: 189921 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

ClickBench: Total hot run time: 30.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 73c6b96849485f79e70bd7eb664b9cb1eb7997c4, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.24	0.07	0.06
query4	1.62	0.12	0.10
query5	0.51	0.52	0.51
query6	1.13	0.74	0.72
query7	0.02	0.02	0.02
query8	0.04	0.02	0.03
query9	0.57	0.50	0.50
query10	0.56	0.54	0.54
query11	0.14	0.11	0.11
query12	0.14	0.11	0.10
query13	0.61	0.60	0.59
query14	0.78	0.79	0.79
query15	0.84	0.84	0.82
query16	0.38	0.38	0.37
query17	1.07	1.08	1.06
query18	0.23	0.23	0.23
query19	1.96	1.77	1.81
query20	0.01	0.01	0.02
query21	15.40	0.59	0.59
query22	2.41	2.43	2.18
query23	16.94	1.18	0.69
query24	3.41	1.51	2.00
query25	0.20	0.12	0.04
query26	0.56	0.14	0.15
query27	0.05	0.05	0.04
query28	8.78	0.52	0.49
query29	12.59	3.24	3.23
query30	0.24	0.07	0.07
query31	2.86	0.40	0.38
query32	3.25	0.46	0.45
query33	2.96	3.01	2.97
query34	16.99	4.48	4.51
query35	4.61	4.54	4.52
query36	0.71	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.4 s
Total hot run time: 30.93 s

@yujun777
Copy link
Contributor Author

yujun777 commented Jul 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

TPC-H: Total hot run time: 39796 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 29a26f9fc943de4ac768d608d97795bd0fd6c19a, data reload: false

------ Round 1 ----------------------------------
q1	17842	7333	6778	6778
q2	3391	205	188	188
q3	11256	1164	1206	1164
q4	10477	755	756	755
q5	7762	2850	2739	2739
q6	216	136	138	136
q7	994	620	606	606
q8	9377	2027	1954	1954
q9	8406	6435	6416	6416
q10	7040	2221	2245	2221
q11	453	270	265	265
q12	393	209	209	209
q13	17793	2981	2979	2979
q14	245	208	218	208
q15	501	480	476	476
q16	464	377	383	377
q17	999	518	518	518
q18	7130	6663	6534	6534
q19	1331	939	964	939
q20	484	197	196	196
q21	3960	3234	3165	3165
q22	1103	986	973	973
Total cold run time: 111617 ms
Total hot run time: 39796 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6594	6561	6574	6561
q2	330	247	250	247
q3	3143	3023	2993	2993
q4	2047	1808	1808	1808
q5	5625	5731	5706	5706
q6	215	126	130	126
q7	2193	1822	1754	1754
q8	3360	3498	3503	3498
q9	8768	8877	8798	8798
q10	3565	3505	3538	3505
q11	595	492	485	485
q12	792	622	628	622
q13	3847	3117	3163	3117
q14	309	275	284	275
q15	510	463	467	463
q16	472	426	459	426
q17	1866	1616	1612	1612
q18	8279	7732	7912	7732
q19	1705	1574	1477	1477
q20	2045	1838	1804	1804
q21	4928	4781	4730	4730
q22	1072	1000	1021	1000
Total cold run time: 62260 ms
Total hot run time: 58739 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

TPC-DS: Total hot run time: 189991 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 29a26f9fc943de4ac768d608d97795bd0fd6c19a, data reload: false

query1	974	372	364	364
query2	6545	1896	1868	1868
query3	6706	231	230	230
query4	34120	23330	23739	23330
query5	4303	462	441	441
query6	286	181	182	181
query7	4620	316	312	312
query8	300	237	219	219
query9	9625	2603	2604	2603
query10	486	272	249	249
query11	18176	15338	15151	15151
query12	155	102	102	102
query13	1656	439	427	427
query14	9510	6944	6608	6608
query15	226	175	174	174
query16	8000	504	436	436
query17	1637	588	578	578
query18	2075	312	315	312
query19	254	167	161	161
query20	119	108	106	106
query21	213	109	104	104
query22	4436	4219	4273	4219
query23	34366	35253	33616	33616
query24	12252	2858	2890	2858
query25	591	414	425	414
query26	1185	168	177	168
query27	2930	349	348	348
query28	7698	2140	2145	2140
query29	696	437	449	437
query30	323	160	159	159
query31	1034	788	801	788
query32	100	60	61	60
query33	800	308	313	308
query34	937	516	523	516
query35	863	719	706	706
query36	1070	953	959	953
query37	190	72	77	72
query38	3967	3774	3982	3774
query39	1483	1434	1424	1424
query40	296	105	107	105
query41	55	51	50	50
query42	122	105	104	104
query43	517	486	469	469
query44	1297	803	797	797
query45	190	172	174	172
query46	1136	717	731	717
query47	1924	1864	1818	1818
query48	438	346	361	346
query49	1303	424	401	401
query50	813	415	414	414
query51	7307	7143	7122	7122
query52	108	96	95	95
query53	258	187	187	187
query54	1225	482	495	482
query55	86	84	83	83
query56	287	270	258	258
query57	1267	1156	1152	1152
query58	249	224	227	224
query59	3180	2929	2898	2898
query60	328	275	302	275
query61	114	109	116	109
query62	880	662	653	653
query63	218	188	190	188
query64	5172	666	613	613
query65	3302	3237	3252	3237
query66	1324	315	339	315
query67	15925	15467	15717	15467
query68	4837	594	581	581
query69	443	270	264	264
query70	1157	1102	1096	1096
query71	434	271	271	271
query72	6002	4019	3955	3955
query73	792	358	358	358
query74	10271	9001	8902	8902
query75	3396	2634	2617	2617
query76	2940	1029	1088	1029
query77	439	298	275	275
query78	10545	9700	9516	9516
query79	1413	606	610	606
query80	1014	435	429	429
query81	537	223	221	221
query82	961	97	91	91
query83	222	148	152	148
query84	239	80	82	80
query85	1323	331	298	298
query86	365	294	305	294
query87	4387	4284	4272	4272
query88	3801	2439	2399	2399
query89	402	291	295	291
query90	1943	188	187	187
query91	141	106	111	106
query92	56	51	57	51
query93	1101	560	551	551
query94	896	308	288	288
query95	350	263	261	261
query96	603	293	285	285
query97	3303	3148	3098	3098
query98	215	207	195	195
query99	1485	1309	1315	1309
Total cold run time: 300241 ms
Total hot run time: 189991 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2025

ClickBench: Total hot run time: 29.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 29a26f9fc943de4ac768d608d97795bd0fd6c19a, data reload: false

query1	0.03	0.04	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.50	0.51	0.52
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.53	0.51
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.12
query13	0.61	0.60	0.60
query14	0.77	0.81	0.79
query15	0.85	0.83	0.82
query16	0.38	0.38	0.40
query17	1.08	1.05	1.10
query18	0.24	0.21	0.22
query19	1.87	1.87	1.89
query20	0.02	0.01	0.00
query21	15.42	0.61	0.60
query22	2.42	1.66	1.94
query23	17.02	1.01	0.79
query24	3.01	0.79	2.29
query25	0.19	0.14	0.04
query26	0.44	0.13	0.14
query27	0.05	0.05	0.05
query28	9.61	0.54	0.46
query29	12.60	3.27	3.21
query30	0.24	0.06	0.07
query31	2.86	0.38	0.39
query32	3.24	0.46	0.46
query33	2.96	2.97	3.00
query34	17.03	4.52	4.50
query35	4.52	4.46	4.48
query36	0.67	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.15	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.6 s
Total hot run time: 29.84 s

@morrySnow morrySnow merged commit 1655f1e into apache:branch-3.1 Jul 18, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yujun777 @hello-stephen @doris-robot @morrySnow