Skip to content

branch-3.0: [fix](catalog) synchronize reset methods in catalog classes and remove Lombok annotations #53167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jul 16, 2025
Merged

branch-3.0: [fix](catalog) synchronize reset methods in catalog classes and remove Lombok annotations #53167

dataroaring merged 2 commits into from
Jul 16, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Jul 13, 2025

pick (#51787)

@zy-kkk zy-kkk requested a review from dataroaring as a code owner July 13, 2025 11:33
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Jul 13, 2025

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Jul 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 15, 2025

TPC-H: Total hot run time: 39690 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fd25cae579a47dad8b480d3f2e0bf9d1d5f4b8d5, data reload: false

------ Round 1 ----------------------------------
q1	17574	6960	6622	6622
q2	2065	198	166	166
q3	10650	1125	1135	1125
q4	10384	718	782	718
q5	7748	2843	2748	2748
q6	216	134	133	133
q7	961	625	613	613
q8	9349	1942	1995	1942
q9	6532	6388	6379	6379
q10	7048	2289	2284	2284
q11	467	271	277	271
q12	388	218	215	215
q13	17814	3020	2995	2995
q14	233	198	206	198
q15	511	480	472	472
q16	490	402	385	385
q17	985	596	534	534
q18	7259	6630	6655	6630
q19	1402	965	956	956
q20	468	199	208	199
q21	3888	3121	3204	3121
q22	1099	992	984	984
Total cold run time: 107531 ms
Total hot run time: 39690 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6611	6617	6583	6583
q2	326	234	227	227
q3	2865	2879	2954	2879
q4	2075	1862	1896	1862
q5	5676	5705	5702	5702
q6	207	128	127	127
q7	2236	1861	1803	1803
q8	3344	3504	3488	3488
q9	8904	9005	9019	9005
q10	3643	3569	3496	3496
q11	633	501	527	501
q12	841	609	656	609
q13	9376	3199	3177	3177
q14	303	273	286	273
q15	527	462	474	462
q16	498	442	444	442
q17	1855	1602	1616	1602
q18	8255	7752	7715	7715
q19	1674	1539	1433	1433
q20	2080	1829	1870	1829
q21	5263	5063	4978	4978
q22	1137	1075	1033	1033
Total cold run time: 68329 ms
Total hot run time: 59226 ms

@doris-robot
Copy link

doris-robot commented Jul 15, 2025

TPC-DS: Total hot run time: 196439 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fd25cae579a47dad8b480d3f2e0bf9d1d5f4b8d5, data reload: false

query1	1265	903	886	886
query2	6314	1920	1879	1879
query3	10849	4278	4248	4248
query4	33027	23472	23444	23444
query5	3433	462	455	455
query6	256	185	194	185
query7	3996	316	323	316
query8	283	224	214	214
query9	9616	2565	2575	2565
query10	462	267	247	247
query11	17932	15121	15561	15121
query12	154	98	100	98
query13	1530	404	418	404
query14	9361	6638	6869	6638
query15	228	185	187	185
query16	7793	491	480	480
query17	1584	576	562	562
query18	2004	311	297	297
query19	222	172	159	159
query20	118	120	111	111
query21	206	105	114	105
query22	4681	4530	4733	4530
query23	34953	34300	34040	34040
query24	11555	2986	2986	2986
query25	674	439	441	439
query26	1522	183	180	180
query27	2865	353	368	353
query28	7723	2182	2159	2159
query29	948	478	482	478
query30	275	168	172	168
query31	1036	816	829	816
query32	98	62	68	62
query33	773	306	311	306
query34	1158	520	532	520
query35	868	742	769	742
query36	1111	936	953	936
query37	139	70	68	68
query38	4064	3941	4016	3941
query39	1555	1456	1484	1456
query40	244	107	103	103
query41	51	50	52	50
query42	123	109	109	109
query43	538	482	490	482
query44	1241	817	817	817
query45	188	178	176	176
query46	1158	771	762	762
query47	1997	1911	1954	1911
query48	467	388	383	383
query49	1038	418	403	403
query50	849	423	427	423
query51	7519	7165	7294	7165
query52	104	92	88	88
query53	262	187	187	187
query54	1188	471	473	471
query55	77	75	83	75
query56	274	270	266	266
query57	1312	1195	1189	1189
query58	231	214	226	214
query59	3126	3024	3007	3007
query60	274	262	256	256
query61	114	111	108	108
query62	889	732	699	699
query63	229	197	194	194
query64	4154	680	696	680
query65	3628	3329	3228	3228
query66	970	296	314	296
query67	15887	15525	15529	15525
query68	4665	568	571	568
query69	461	262	260	260
query70	1151	1089	1095	1089
query71	333	265	265	265
query72	6317	4045	3977	3977
query73	765	349	344	344
query74	10336	9063	8883	8883
query75	3408	2636	2673	2636
query76	2608	1060	1048	1048
query77	397	283	276	276
query78	10570	9639	9609	9609
query79	1785	615	608	608
query80	1118	427	424	424
query81	550	218	230	218
query82	951	88	88	88
query83	223	145	141	141
query84	244	77	80	77
query85	1387	312	289	289
query86	459	301	265	265
query87	4406	4219	4246	4219
query88	3572	2401	2396	2396
query89	409	294	290	290
query90	1883	188	189	188
query91	193	149	151	149
query92	65	49	51	49
query93	2406	557	566	557
query94	849	305	297	297
query95	368	261	263	261
query96	608	277	284	277
query97	3283	3137	3150	3137
query98	212	205	211	205
query99	1511	1306	1303	1303
Total cold run time: 302256 ms
Total hot run time: 196439 ms

@doris-robot
Copy link

doris-robot commented Jul 15, 2025

ClickBench: Total hot run time: 30.06 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fd25cae579a47dad8b480d3f2e0bf9d1d5f4b8d5, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.64	0.10	0.10
query5	0.52	0.53	0.52
query6	1.14	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.49
query10	0.55	0.56	0.55
query11	0.14	0.10	0.10
query12	0.14	0.12	0.12
query13	0.62	0.60	0.59
query14	0.78	0.82	0.80
query15	0.84	0.82	0.82
query16	0.37	0.38	0.37
query17	1.03	1.01	1.05
query18	0.24	0.22	0.22
query19	1.89	1.82	1.81
query20	0.01	0.01	0.01
query21	15.39	0.60	0.60
query22	2.47	1.89	1.82
query23	17.18	0.91	0.75
query24	3.05	1.50	0.82
query25	0.22	0.18	0.15
query26	0.38	0.14	0.13
query27	0.05	0.04	0.04
query28	10.16	0.50	0.45
query29	12.58	3.24	3.26
query30	0.25	0.06	0.06
query31	2.85	0.38	0.38
query32	3.24	0.48	0.46
query33	2.97	3.01	2.98
query34	17.23	4.51	4.51
query35	4.55	4.53	4.54
query36	0.68	0.46	0.48
query37	0.08	0.06	0.05
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.57 s
Total hot run time: 30.06 s

dataroaring
dataroaring approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 300ec58 into apache:branch-3.0 Jul 16, 2025
22 of 24 checks passed
@zy-kkk zy-kkk deleted the pick-51787-to-3.0 branch July 16, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zy-kkk @hello-stephen @doris-robot @dataroaring