Skip to content

[fix & opt](orc) ORC-1525: Fix bad read in RleDecoderV2::readByte and Decompress zlib by libdeflate. #53078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jul 16, 2025
Merged

[fix & opt](orc) ORC-1525: Fix bad read in RleDecoderV2::readByte and Decompress zlib by libdeflate. #53078

yiguolei merged 1 commit into from
Jul 16, 2025

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Jul 10, 2025

What problem does this PR solve?

Problem Summary:

Release note

Cherry-pick #51775

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@kaka11chen kaka11chen requested a review from yiguolei as a code owner July 10, 2025 17:24
@Thearas
Copy link
Contributor

Thearas commented Jul 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

kaka11chen commented Jul 10, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 10, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.07% (10342/26472)
Line Coverage 30.02% (85811/285803)
Region Coverage 28.72% (44315/154288)
Branch Coverage 25.43% (22675/89154)

@kaka11chen
Copy link
Contributor Author

kaka11chen commented Jul 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 11, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.08% (10344/26472)
Line Coverage 30.04% (85867/285804)
Region Coverage 28.73% (44328/154289)
Branch Coverage 25.44% (22677/89154)

@kaka11chen kaka11chen force-pushed the cherry-pick-51775_2.1 branch from d2ea639 to d6f8a13 Compare July 14, 2025 00:15
@kaka11chen kaka11chen marked this pull request as draft July 14, 2025 00:15
@kaka11chen
Copy link
Contributor Author

kaka11chen commented Jul 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 14, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.06% (10341/26472)
Line Coverage 30.04% (85842/285804)
Region Coverage 28.72% (44305/154289)
Branch Coverage 25.43% (22669/89154)

@kaka11chen kaka11chen force-pushed the cherry-pick-51775_2.1 branch from d6f8a13 to 5aaf468 Compare July 14, 2025 07:27
@kaka11chen
Copy link
Contributor Author

kaka11chen commented Jul 14, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 14, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.07% (10343/26472)
Line Coverage 30.04% (85859/285804)
Region Coverage 28.73% (44329/154289)
Branch Coverage 25.43% (22675/89154)

@kaka11chen kaka11chen force-pushed the cherry-pick-51775_2.1 branch from 5aaf468 to e491da0 Compare July 15, 2025 11:38
@kaka11chen
Copy link
Contributor Author

kaka11chen commented Jul 15, 2025

run buildall

@kaka11chen kaka11chen marked this pull request as ready for review July 15, 2025 11:39
@doris-robot
Copy link

doris-robot commented Jul 15, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.06% (10341/26472)
Line Coverage 30.02% (85808/285804)
Region Coverage 28.72% (44318/154289)
Branch Coverage 25.42% (22667/89154)

@yiguolei yiguolei merged commit d543713 into apache:branch-2.1 Jul 16, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaka11chen @Thearas @hello-stephen @doris-robot @yiguolei