Skip to content

branch-3.1: [Bug](topn) variant column read in topn may coredump #52573 #52929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 8, 2025
Merged

branch-3.1: [Bug](topn) variant column read in topn may coredump #52573 #52929

morrySnow merged 1 commit into from
Jul 8, 2025

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Jul 8, 2025 •
edited by morrySnow
Loading

cherry pick #52573

@HappenLee HappenLee requested a review from morrySnow as a code owner July 8, 2025 07:29
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

HappenLee commented Jul 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-H: Total hot run time: 39535 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6137c81345e956f42c4c6f3251e0e50bbe67ab5a, data reload: false

------ Round 1 ----------------------------------
q1	17653	6872	6585	6585
q2	2074	215	165	165
q3	10636	1120	1179	1120
q4	10429	738	697	697
q5	7736	2902	2831	2831
q6	216	136	134	134
q7	979	618	615	615
q8	9347	1926	2033	1926
q9	6641	6386	6432	6386
q10	7038	2251	2288	2251
q11	461	256	258	256
q12	396	210	211	210
q13	17805	2974	2963	2963
q14	237	200	205	200
q15	514	466	479	466
q16	486	383	368	368
q17	982	523	554	523
q18	7269	6570	6697	6570
q19	1348	1014	1008	1008
q20	481	205	210	205
q21	4118	3140	3080	3080
q22	1064	976	997	976
Total cold run time: 107910 ms
Total hot run time: 39535 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6638	6536	6530	6530
q2	334	232	227	227
q3	2865	2938	2881	2881
q4	2017	1778	1788	1778
q5	5684	5759	5702	5702
q6	214	127	127	127
q7	2184	1797	1828	1797
q8	3332	3495	3540	3495
q9	8700	8824	8844	8824
q10	3537	3486	3487	3486
q11	582	481	478	478
q12	818	590	590	590
q13	7216	3212	3129	3129
q14	291	277	267	267
q15	523	467	453	453
q16	501	446	433	433
q17	1844	1614	1603	1603
q18	8221	7811	7875	7811
q19	1688	1448	1438	1438
q20	2042	1803	1813	1803
q21	5279	5002	4897	4897
q22	1120	1051	1073	1051
Total cold run time: 65630 ms
Total hot run time: 58800 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.24% (12469/27563)
Line Coverage 36.21% (110555/305323)
Region Coverage 35.35% (57329/162177)
Branch Coverage 32.43% (31083/95844)

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-DS: Total hot run time: 195557 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6137c81345e956f42c4c6f3251e0e50bbe67ab5a, data reload: false

query1	1272	931	883	883
query2	6304	1977	1938	1938
query3	10846	4220	4284	4220
query4	33057	23781	23442	23442
query5	4358	455	458	455
query6	281	177	186	177
query7	3990	315	327	315
query8	294	241	229	229
query9	9578	2614	2604	2604
query10	488	265	255	255
query11	18576	15146	15126	15126
query12	161	102	105	102
query13	1560	434	422	422
query14	9814	6480	7090	6480
query15	257	184	184	184
query16	7988	494	508	494
query17	1664	606	601	601
query18	2179	338	331	331
query19	323	166	171	166
query20	125	129	120	120
query21	212	114	112	112
query22	4611	4441	4349	4349
query23	34847	34251	33899	33899
query24	11390	2967	2926	2926
query25	670	433	439	433
query26	1287	179	174	174
query27	2482	358	363	358
query28	7330	2212	2204	2204
query29	882	469	489	469
query30	260	158	152	152
query31	1009	806	858	806
query32	91	55	54	54
query33	775	297	320	297
query34	932	503	509	503
query35	847	768	712	712
query36	1107	955	938	938
query37	126	64	65	64
query38	4087	3958	3933	3933
query39	1521	1553	1430	1430
query40	202	104	103	103
query41	49	50	50	50
query42	115	105	103	103
query43	539	479	494	479
query44	1424	839	828	828
query45	190	175	177	175
query46	1198	724	758	724
query47	2002	1932	1985	1932
query48	451	354	349	349
query49	1114	414	402	402
query50	838	420	428	420
query51	7449	7359	7191	7191
query52	103	90	119	90
query53	259	185	180	180
query54	1180	461	466	461
query55	80	82	78	78
query56	266	260	255	255
query57	1295	1186	1211	1186
query58	226	206	242	206
query59	3310	3182	2993	2993
query60	281	265	258	258
query61	118	131	114	114
query62	826	696	700	696
query63	215	192	196	192
query64	4068	705	629	629
query65	3323	3268	3248	3248
query66	769	310	301	301
query67	15955	15478	15265	15265
query68	4782	585	590	585
query69	450	261	265	261
query70	1183	1135	1077	1077
query71	344	259	257	257
query72	6300	4126	4059	4059
query73	750	355	352	352
query74	10736	8826	9151	8826
query75	3364	2610	2608	2608
query76	2697	1116	1070	1070
query77	406	281	285	281
query78	10539	9680	9628	9628
query79	1475	606	615	606
query80	943	437	431	431
query81	541	216	225	216
query82	607	89	85	85
query83	246	151	147	147
query84	237	86	77	77
query85	1206	300	290	290
query86	425	282	283	282
query87	4335	4162	4195	4162
query88	3730	2401	2384	2384
query89	412	288	298	288
query90	1954	187	186	186
query91	149	106	110	106
query92	65	58	51	51
query93	2354	558	558	558
query94	771	290	302	290
query95	368	263	255	255
query96	622	280	275	275
query97	3316	3104	3243	3104
query98	217	195	202	195
query99	1499	1300	1333	1300
Total cold run time: 302449 ms
Total hot run time: 195557 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

ClickBench: Total hot run time: 29.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6137c81345e956f42c4c6f3251e0e50bbe67ab5a, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.52	0.51	0.54
query6	1.12	0.72	0.73
query7	0.02	0.02	0.01
query8	0.03	0.03	0.03
query9	0.56	0.52	0.50
query10	0.55	0.55	0.55
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.80	0.78	0.79
query15	0.83	0.81	0.84
query16	0.39	0.37	0.37
query17	1.06	1.07	1.05
query18	0.24	0.22	0.22
query19	1.96	1.81	1.76
query20	0.02	0.01	0.01
query21	15.39	0.59	0.57
query22	2.41	2.36	1.62
query23	16.92	1.03	0.79
query24	3.47	0.42	1.99
query25	0.29	0.11	0.07
query26	0.38	0.15	0.13
query27	0.04	0.08	0.04
query28	9.84	0.50	0.45
query29	12.59	3.25	3.24
query30	0.25	0.07	0.07
query31	2.83	0.38	0.39
query32	3.26	0.45	0.45
query33	2.96	3.02	3.00
query34	17.12	4.45	4.44
query35	4.48	4.48	4.44
query36	0.66	0.47	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.12	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.32 s
Total hot run time: 29.23 s

@morrySnow morrySnow changed the title [Bug](topn) variant column read in topn may coredump branch-3.1: [Bug](topn) variant column read in topn may coredump #52573 Jul 8, 2025
@morrySnow morrySnow merged commit 42f9f32 into apache:branch-3.1 Jul 8, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HappenLee @hello-stephen @doris-robot @morrySnow