Skip to content

branch-3.1: [fix](function) fix array_map cause coredump as NULL #51618 #52599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 2, 2025
Merged

branch-3.1: [fix](function) fix array_map cause coredump as NULL #51618 #52599

morrySnow merged 1 commit into from
Jul 2, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jul 1, 2025

What problem does this PR solve?

Problem Summary:
cherry-pick from master #51618

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zhangstar333
[bug](function) fix array_map cause coredump as NULL (apache#51618)
2bb10f3 
if column_array is NULL, we know the array_data_column will not write
any data,
so the column is empty. eg : (x) -> concat('|',x + "1"). if still
execute the lambda function, will cause the bolck rows are not equal.
the x column is empty, but "|" is const literal, size of column is 1, so
the block rows is 1, but the x column is empty, will be coredump.
@zhangstar333 zhangstar333 requested a review from morrySnow as a code owner July 1, 2025 11:37
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jul 1, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 1, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.05% (12381/27480)
Line Coverage 36.05% (109623/304127)
Region Coverage 35.12% (56802/161752)
Branch Coverage 32.24% (30816/95572)

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-H: Total hot run time: 40083 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2bb10f38eac7dc26342d740bd80260efa7c4f7a7, data reload: false

------ Round 1 ----------------------------------
q1	17613	6856	6648	6648
q2	2088	194	189	189
q3	10585	1137	1139	1137
q4	10382	735	740	735
q5	7742	2893	2737	2737
q6	212	130	136	130
q7	998	637	623	623
q8	9345	2013	2049	2013
q9	6650	6459	6464	6459
q10	7054	2257	2306	2257
q11	467	265	264	264
q12	398	216	209	209
q13	17774	3004	2987	2987
q14	247	209	210	209
q15	504	466	464	464
q16	484	371	377	371
q17	1011	645	613	613
q18	7247	6709	6634	6634
q19	1347	1060	1020	1020
q20	484	204	208	204
q21	3964	3197	3181	3181
q22	1084	999	1002	999
Total cold run time: 107680 ms
Total hot run time: 40083 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6692	6610	6588	6588
q2	327	233	241	233
q3	2941	2969	2993	2969
q4	2042	1822	1883	1822
q5	5730	5786	5741	5741
q6	205	128	127	127
q7	2260	1775	1810	1775
q8	3400	3562	3587	3562
q9	8761	8907	8890	8890
q10	3571	3509	3531	3509
q11	586	501	488	488
q12	826	626	609	609
q13	9379	3193	3101	3101
q14	295	271	281	271
q15	515	466	458	458
q16	489	430	425	425
q17	1852	1632	1620	1620
q18	8215	7937	7712	7712
q19	1715	1538	1595	1538
q20	2067	1807	1832	1807
q21	5250	4960	5081	4960
q22	1098	1014	1048	1014
Total cold run time: 68216 ms
Total hot run time: 59219 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-DS: Total hot run time: 196209 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2bb10f38eac7dc26342d740bd80260efa7c4f7a7, data reload: false

query1	1276	938	902	902
query2	6273	1873	1882	1873
query3	10800	4395	4161	4161
query4	32957	23334	23852	23334
query5	4282	465	457	457
query6	278	188	194	188
query7	3995	319	323	319
query8	295	239	240	239
query9	9574	2570	2569	2569
query10	497	276	262	262
query11	18611	15211	15731	15211
query12	161	102	105	102
query13	1562	429	419	419
query14	9106	7270	7186	7186
query15	256	185	207	185
query16	7906	513	489	489
query17	1658	642	611	611
query18	2192	346	324	324
query19	276	172	178	172
query20	134	117	118	117
query21	205	111	109	109
query22	4625	4505	4464	4464
query23	35092	33992	34312	33992
query24	10975	2828	2917	2828
query25	654	434	433	433
query26	748	180	170	170
query27	2344	359	349	349
query28	6322	2178	2241	2178
query29	800	498	438	438
query30	256	165	160	160
query31	1047	831	822	822
query32	86	56	58	56
query33	665	301	313	301
query34	925	530	503	503
query35	857	750	708	708
query36	1082	936	944	936
query37	113	67	66	66
query38	4057	4018	4055	4018
query39	1534	1468	1474	1468
query40	197	98	107	98
query41	48	47	50	47
query42	111	101	102	101
query43	523	486	482	482
query44	1151	819	817	817
query45	180	173	169	169
query46	1170	734	742	734
query47	1989	1961	1932	1932
query48	443	338	345	338
query49	904	410	384	384
query50	839	428	416	416
query51	7356	7134	7125	7125
query52	110	94	89	89
query53	264	182	179	179
query54	1236	471	481	471
query55	85	83	77	77
query56	266	239	240	239
query57	1326	1205	1221	1205
query58	230	212	219	212
query59	3106	2996	3039	2996
query60	281	250	252	250
query61	115	110	113	110
query62	829	703	693	693
query63	227	198	185	185
query64	3737	660	660	660
query65	3387	3260	3273	3260
query66	791	306	311	306
query67	16053	15811	15492	15492
query68	4714	573	568	568
query69	482	262	263	262
query70	1177	1040	1065	1040
query71	342	250	253	250
query72	6332	4004	3868	3868
query73	761	348	344	344
query74	10755	8948	9215	8948
query75	3353	2606	2655	2606
query76	2692	1076	1035	1035
query77	362	268	268	268
query78	10620	9577	9608	9577
query79	1322	604	586	586
query80	1046	432	416	416
query81	552	216	220	216
query82	1037	89	84	84
query83	248	140	141	140
query84	233	83	85	83
query85	1177	297	293	293
query86	349	304	296	296
query87	4321	4300	4189	4189
query88	3558	2367	2353	2353
query89	416	288	291	288
query90	1923	183	185	183
query91	138	103	105	103
query92	58	50	53	50
query93	1279	548	553	548
query94	809	293	309	293
query95	357	254	263	254
query96	597	278	277	277
query97	3316	3128	3147	3128
query98	210	197	198	197
query99	1528	1280	1340	1280
Total cold run time: 297494 ms
Total hot run time: 196209 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

ClickBench: Total hot run time: 30.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2bb10f38eac7dc26342d740bd80260efa7c4f7a7, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.54	0.50	0.50
query6	1.13	0.73	0.73
query7	0.04	0.02	0.02
query8	0.04	0.03	0.04
query9	0.55	0.50	0.50
query10	0.57	0.56	0.57
query11	0.14	0.09	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	0.77	0.79	0.79
query15	0.85	0.83	0.84
query16	0.37	0.37	0.38
query17	1.05	1.08	1.03
query18	0.23	0.22	0.22
query19	1.95	1.87	1.84
query20	0.02	0.01	0.01
query21	15.39	0.59	0.59
query22	2.46	2.46	1.88
query23	17.12	0.99	0.79
query24	3.04	1.26	1.43
query25	0.18	0.07	0.13
query26	0.53	0.13	0.14
query27	0.03	0.05	0.04
query28	9.95	0.48	0.53
query29	12.59	3.26	3.23
query30	0.25	0.06	0.06
query31	2.84	0.38	0.39
query32	3.25	0.47	0.45
query33	2.98	3.03	3.04
query34	16.86	4.52	4.47
query35	4.56	4.52	4.52
query36	0.68	0.48	0.51
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.03
query40	0.16	0.12	0.12
query41	0.07	0.02	0.03
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.1 s
Total hot run time: 30.61 s

@morrySnow morrySnow changed the title [cherry-pick](branch-31) fix array_map cause coredump as NULL (#51618) branch-3.1: [fix](function) fix array_map cause coredump as NULL #51618 Jul 2, 2025
@morrySnow morrySnow merged commit ea1a531 into apache:branch-3.1 Jul 2, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangstar333 @hello-stephen @doris-robot @morrySnow