Skip to content

[Bug](topn) variant column read in topn may coredump #52585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 22, 2025
Merged

[Bug](topn) variant column read in topn may coredump #52585

dataroaring merged 1 commit into from
Jul 22, 2025

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Jul 1, 2025

What problem does this PR solve?

cherry pick #52573

Problem Summary:

@HappenLee HappenLee requested a review from dataroaring as a code owner July 1, 2025 08:05
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

HappenLee commented Jul 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-H: Total hot run time: 40107 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit beee15d7fb4d039c24e856d0a7e4c76f263b5b9b, data reload: false

------ Round 1 ----------------------------------
q1	17635	7217	6588	6588
q2	2074	184	185	184
q3	10566	1123	1147	1123
q4	10230	772	784	772
q5	7745	2843	2841	2841
q6	219	141	136	136
q7	992	624	620	620
q8	9380	1996	2042	1996
q9	6685	6403	6394	6394
q10	7042	2285	2290	2285
q11	470	267	261	261
q12	399	220	224	220
q13	17823	3010	3051	3010
q14	228	205	216	205
q15	518	466	480	466
q16	503	402	389	389
q17	1006	587	545	545
q18	7274	6578	6839	6578
q19	1402	1109	1094	1094
q20	477	203	207	203
q21	3943	3197	3238	3197
q22	1082	1002	1000	1000
Total cold run time: 107693 ms
Total hot run time: 40107 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6668	6614	6635	6614
q2	323	232	230	230
q3	2971	2975	2947	2947
q4	2084	1837	1842	1837
q5	5673	5755	5761	5755
q6	207	133	136	133
q7	2217	1840	1822	1822
q8	3396	3581	3613	3581
q9	8928	9031	9031	9031
q10	3608	3588	3592	3588
q11	615	522	506	506
q12	829	653	624	624
q13	8758	3227	3167	3167
q14	303	276	280	276
q15	513	480	485	480
q16	499	445	455	445
q17	1847	1666	1611	1611
q18	8294	7763	8172	7763
q19	1656	1587	1580	1580
q20	2093	1912	1879	1879
q21	5278	5196	5123	5123
q22	1139	1084	1047	1047
Total cold run time: 67899 ms
Total hot run time: 60039 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.89% (11133/26579)
Line Coverage 32.42% (95348/294099)
Region Coverage 31.56% (49250/156052)
Branch Coverage 27.98% (25236/90188)

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-DS: Total hot run time: 196373 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit beee15d7fb4d039c24e856d0a7e4c76f263b5b9b, data reload: false

query1	1287	931	914	914
query2	6254	1894	1863	1863
query3	11002	4446	4654	4446
query4	32921	24039	23446	23446
query5	4571	472	447	447
query6	278	175	167	167
query7	3994	321	317	317
query8	276	219	233	219
query9	9587	2608	2600	2600
query10	494	288	260	260
query11	18241	15155	15276	15155
query12	157	105	104	104
query13	1557	432	421	421
query14	8518	6800	7627	6800
query15	259	181	196	181
query16	8379	497	516	497
query17	1643	613	603	603
query18	2104	327	323	323
query19	241	173	179	173
query20	124	121	121	121
query21	212	108	107	107
query22	4740	4569	4479	4479
query23	34955	34277	33732	33732
query24	10740	3032	2943	2943
query25	633	420	425	420
query26	738	173	177	173
query27	2431	371	365	365
query28	6452	2192	2152	2152
query29	793	478	465	465
query30	282	158	150	150
query31	1046	804	833	804
query32	99	55	63	55
query33	704	313	315	313
query34	912	535	513	513
query35	865	776	709	709
query36	1104	948	955	948
query37	108	66	69	66
query38	4090	3971	3998	3971
query39	1528	1480	1467	1467
query40	209	110	101	101
query41	50	47	57	47
query42	121	105	106	105
query43	554	480	472	472
query44	1220	808	809	808
query45	190	176	166	166
query46	1165	730	749	730
query47	2027	1908	1923	1908
query48	468	385	397	385
query49	997	401	403	401
query50	833	436	443	436
query51	7470	7249	7270	7249
query52	109	98	89	89
query53	267	187	194	187
query54	1332	491	479	479
query55	83	79	79	79
query56	285	253	257	253
query57	1286	1214	1202	1202
query58	239	215	219	215
query59	3166	2813	2727	2727
query60	270	249	259	249
query61	110	168	109	109
query62	819	651	689	651
query63	221	197	193	193
query64	3604	655	626	626
query65	3245	3244	3188	3188
query66	812	294	300	294
query67	15740	15517	15535	15517
query68	4473	594	589	589
query69	434	267	291	267
query70	1167	1128	1054	1054
query71	331	251	256	251
query72	6348	4144	4018	4018
query73	743	350	351	350
query74	10545	9195	9077	9077
query75	3325	2656	2621	2621
query76	2748	1057	1163	1057
query77	404	279	284	279
query78	10625	9598	9638	9598
query79	1726	623	599	599
query80	1134	427	435	427
query81	555	225	220	220
query82	965	90	95	90
query83	239	141	151	141
query84	231	75	80	75
query85	1286	320	305	305
query86	423	300	304	300
query87	4372	4272	4259	4259
query88	3536	2386	2368	2368
query89	419	295	294	294
query90	2092	199	196	196
query91	180	153	152	152
query92	66	49	52	49
query93	1909	557	552	552
query94	969	254	301	254
query95	374	264	259	259
query96	612	279	281	279
query97	3265	3150	3166	3150
query98	212	202	212	202
query99	1546	1286	1292	1286
Total cold run time: 298465 ms
Total hot run time: 196373 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

ClickBench: Total hot run time: 30.38 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit beee15d7fb4d039c24e856d0a7e4c76f263b5b9b, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.11	0.11
query5	0.52	0.52	0.50
query6	1.12	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.55
query11	0.14	0.10	0.09
query12	0.14	0.12	0.11
query13	0.60	0.60	0.62
query14	0.78	0.79	0.80
query15	0.86	0.83	0.83
query16	0.38	0.36	0.39
query17	1.00	1.07	1.04
query18	0.23	0.21	0.21
query19	1.87	1.87	1.87
query20	0.01	0.01	0.01
query21	15.40	0.59	0.60
query22	2.31	2.59	2.11
query23	16.83	1.02	0.89
query24	3.01	0.71	2.39
query25	0.21	0.24	0.07
query26	0.44	0.14	0.15
query27	0.04	0.05	0.04
query28	9.36	0.51	0.52
query29	12.55	3.16	3.17
query30	0.24	0.06	0.07
query31	2.86	0.39	0.38
query32	3.22	0.46	0.46
query33	2.94	2.96	3.09
query34	17.24	4.50	4.50
query35	4.61	4.61	4.59
query36	0.67	0.47	0.48
query37	0.09	0.06	0.05
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 103.19 s
Total hot run time: 30.38 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 22, 2025

BE Regression && UT Coverage Report

Increment line coverage 20.00% (2/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 50.81% (13330/26233)
Line Coverage 41.32% (121367/293703)
Region Coverage 38.92% (70329/180716)
Branch Coverage 33.38% (34030/101950)

dataroaring
dataroaring approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit a629f41 into apache:branch-3.0 Jul 22, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HappenLee @hello-stephen @doris-robot @dataroaring