-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-2.1: [fix](nereids) exceed expr limit error not fallback to legacy planner #52431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch-2.1: [fix](nereids) exceed expr limit error not fallback to legacy planner #52431
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
morrySnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test case
|
run buildall |
|
run feut |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run feut |
|
run buildall |
|
run feut |
What problem does this PR solve?
Legacy planner check expr limit is not reliable. When planner expr change, it need explict call expr.analyse to check the limit.
Nereids planner check expr limit at expr's construct function, it's reliable.
So nereids don't fallback to legacy planner when met exceed expr limit error, this can avoid legacy planner forget to check the expr limit and use a lot of memory.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)