Skip to content

branch-2.1: [fix](Prepared Statment) Fix exec prepared insert stmt in non master error (#48689) #52265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jun 28, 2025
Merged

branch-2.1: [fix](Prepared Statment) Fix exec prepared insert stmt in non master error (#48689) #52265

yiguolei merged 1 commit into from
Jun 28, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jun 25, 2025

backport: #48689

@liutang123 @Jibing-Li
[fix](Prepared Statment) Fix exec prepared insert stmt in non master …
4c15dc7 
…error (apache#48689)

When client send a prepare command to non master frontend like `INSERT
INTO xxxx VALUES(?)` and then execute it whith some params.
The non master frontend will forward the origin stmt to master and
analyze error will occur.
In this PR, we forward the origin sql and param to master. Master
prepare a logic plan with place holder and then use the param and logic
plan to generate physical plan.
@Jibing-Li Jibing-Li marked this pull request as ready for review June 25, 2025 02:35
@Jibing-Li Jibing-Li requested a review from yiguolei as a code owner June 25, 2025 02:35
@Thearas
Copy link
Contributor

Thearas commented Jun 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 25, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 307c047 into apache:branch-2.1 Jun 28, 2025
19 of 20 checks passed
@Jibing-Li Jibing-Li deleted the obprepare2.1 branch June 28, 2025 03:12
@yiguolei yiguolei mentioned this pull request Aug 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jibing-Li @Thearas @yiguolei @liutang123