Skip to content

branch-3.1: [fix](nereids) fix cast ipv4 to string #51546 #51981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jun 20, 2025
Merged

branch-3.1: [fix](nereids) fix cast ipv4 to string #51546 #51981

morrySnow merged 1 commit into from
Jun 20, 2025

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Jun 19, 2025

cherry pick from #51546

@yujun777 yujun777 requested a review from morrySnow as a code owner June 19, 2025 12:58
@yujun777
Copy link
Contributor Author

yujun777 commented Jun 19, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Contributor Author

yujun777 commented Jun 20, 2025

run performance

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

TPC-H: Total hot run time: 39473 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4dd5cf2620321226dec6a84039a041857dcec537, data reload: false

------ Round 1 ----------------------------------
q1	17574	6679	6557	6557
q2	2057	168	162	162
q3	10625	1117	1152	1117
q4	10258	811	744	744
q5	7821	2878	2792	2792
q6	212	134	136	134
q7	984	625	613	613
q8	9963	1912	2016	1912
q9	6598	6371	6394	6371
q10	7027	2261	2315	2261
q11	465	262	254	254
q12	419	210	209	209
q13	17785	2949	3004	2949
q14	246	212	205	205
q15	514	473	457	457
q16	486	375	368	368
q17	958	555	609	555
q18	7279	6771	6671	6671
q19	1392	1095	1058	1058
q20	483	200	205	200
q21	3887	3079	2936	2936
q22	1082	974	948	948
Total cold run time: 108115 ms
Total hot run time: 39473 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6554	6541	7301	6541
q2	324	227	230	227
q3	2907	2771	2958	2771
q4	2078	1756	1773	1756
q5	5700	5716	5747	5716
q6	204	125	124	124
q7	2162	1772	1802	1772
q8	3332	3498	3550	3498
q9	8820	8782	8685	8685
q10	3566	3530	3498	3498
q11	585	486	481	481
q12	824	605	596	596
q13	8031	3105	3192	3105
q14	311	274	284	274
q15	524	454	464	454
q16	476	442	436	436
q17	1829	1620	1584	1584
q18	8152	7555	7593	7555
q19	1694	1598	1630	1598
q20	2098	1871	1862	1862
q21	5237	5028	4983	4983
q22	1062	974	970	970
Total cold run time: 66470 ms
Total hot run time: 58486 ms

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

TPC-DS: Total hot run time: 189937 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4dd5cf2620321226dec6a84039a041857dcec537, data reload: false

query1	961	373	360	360
query2	6512	1950	1941	1941
query3	6708	231	227	227
query4	34216	23503	23307	23307
query5	4310	449	448	448
query6	279	180	181	180
query7	4641	315	311	311
query8	280	226	222	222
query9	9672	2559	2544	2544
query10	446	279	256	256
query11	17957	15145	15129	15129
query12	141	110	101	101
query13	1632	407	410	407
query14	9708	7005	7085	7005
query15	252	171	178	171
query16	8100	455	486	455
query17	1628	581	566	566
query18	2146	310	309	309
query19	245	158	159	158
query20	115	110	108	108
query21	210	105	101	101
query22	4495	4217	3978	3978
query23	34317	34777	34055	34055
query24	11685	2889	2838	2838
query25	587	414	417	414
query26	1112	178	172	172
query27	2912	352	349	349
query28	7656	2096	2102	2096
query29	678	458	452	452
query30	319	168	171	168
query31	999	774	805	774
query32	97	63	62	62
query33	795	306	310	306
query34	924	498	508	498
query35	851	713	726	713
query36	1109	918	919	918
query37	119	70	70	70
query38	3913	3849	3843	3843
query39	1502	1409	1434	1409
query40	295	105	105	105
query41	54	53	52	52
query42	121	103	103	103
query43	513	479	467	467
query44	1268	800	798	798
query45	186	169	170	169
query46	1172	716	751	716
query47	1908	1846	1800	1800
query48	478	377	388	377
query49	1224	394	392	392
query50	818	409	439	409
query51	7305	7188	7268	7188
query52	101	94	90	90
query53	254	187	183	183
query54	1132	466	466	466
query55	77	80	79	79
query56	260	256	246	246
query57	1289	1137	1129	1129
query58	245	205	217	205
query59	2997	2851	2780	2780
query60	293	257	250	250
query61	113	106	118	106
query62	828	689	664	664
query63	215	188	186	186
query64	5227	666	625	625
query65	3245	3164	3204	3164
query66	1104	308	303	303
query67	16011	15339	15544	15339
query68	4608	565	574	565
query69	422	273	267	267
query70	1159	1083	1100	1083
query71	316	257	259	257
query72	6070	4038	3753	3753
query73	761	365	356	356
query74	10230	9145	9005	9005
query75	3429	2661	2655	2655
query76	2964	1058	1104	1058
query77	399	302	269	269
query78	10486	9653	9485	9485
query79	1377	595	589	589
query80	944	447	420	420
query81	524	215	220	215
query82	1139	97	90	90
query83	227	150	147	147
query84	240	82	78	78
query85	1141	311	294	294
query86	359	296	293	293
query87	4392	4211	4230	4211
query88	3316	2460	2392	2392
query89	402	299	309	299
query90	1807	190	189	189
query91	187	152	153	152
query92	61	52	54	52
query93	1078	575	550	550
query94	702	313	261	261
query95	368	263	268	263
query96	600	288	284	284
query97	3289	3135	3105	3105
query98	227	200	201	200
query99	1536	1300	1288	1288
Total cold run time: 297722 ms
Total hot run time: 189937 ms

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

ClickBench: Total hot run time: 30.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4dd5cf2620321226dec6a84039a041857dcec537, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.52	0.50	0.53
query6	1.14	0.73	0.74
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.56	0.50	0.51
query10	0.55	0.55	0.54
query11	0.14	0.10	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.77	0.81	0.84
query15	0.83	0.81	0.81
query16	0.38	0.36	0.39
query17	1.06	1.06	1.07
query18	0.23	0.22	0.22
query19	1.98	1.88	1.87
query20	0.01	0.01	0.02
query21	15.40	0.58	0.57
query22	2.49	1.52	1.55
query23	16.76	1.21	0.74
query24	3.49	1.28	1.70
query25	0.35	0.20	0.15
query26	0.29	0.14	0.13
query27	0.05	0.04	0.04
query28	9.28	0.53	0.45
query29	12.57	3.28	3.27
query30	0.25	0.06	0.05
query31	2.88	0.38	0.38
query32	3.22	0.45	0.45
query33	2.96	3.01	3.02
query34	17.22	4.48	4.46
query35	4.55	4.52	4.54
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.84 s
Total hot run time: 30.29 s

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 801ac7f into apache:branch-3.1 Jun 20, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yujun777 @hello-stephen @doris-robot @morrySnow