Skip to content

[cherry-pick](branch-21) fix array_map cause coredump as NULL (#51618) #51742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Jun 16, 2025
Merged

[cherry-pick](branch-21) fix array_map cause coredump as NULL (#51618) #51742

yiguolei merged 2 commits into from
Jun 16, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jun 16, 2025 •
edited
Loading

Problem Summary:
cherry-pick from #51618

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zhangstar333
[bug](function) fix array_map cause coredump as NULL (apache#51618)
ffd38e1 
if column_array is NULL, we know the array_data_column will not write
any data,
so the column is empty. eg : (x) -> concat('|',x + "1"). if still
execute the lambda function, will cause the bolck rows are not equal.
the x column is empty, but "|" is const literal, size of column is 1, so
the block rows is 1, but the x column is empty, will be coredump.
@zhangstar333 zhangstar333 requested a review from yiguolei as a code owner June 16, 2025 02:55
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jun 16, 2025

run buildall

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jun 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.02% (10328/26468)
Line Coverage 30.04% (85826/285751)
Region Coverage 28.70% (44290/154298)
Branch Coverage 25.42% (22660/89138)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 16, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (27/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.61% (19455/26074)
Line Coverage 69.43% (197127/283928)
Region Coverage 67.00% (120332/179594)
Branch Coverage 60.11% (60575/100774)

@yiguolei yiguolei merged commit 56d87c7 into apache:branch-2.1 Jun 16, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangstar333 @hello-stephen @doris-robot @yiguolei