Skip to content

branch-3.0:[improvement](statistics)Agg table set preagg on when doing sample analyzing. (#49918) #51672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 13, 2025
Merged

branch-3.0:[improvement](statistics)Agg table set preagg on when doing sample analyzing. (#49918) #51672

dataroaring merged 1 commit into from
Jun 13, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jun 12, 2025 •
edited
Loading

backport: #49918
backport: #51116

@Jibing-Li
[improvement](statistics)Agg table set preagg on when doing sample an…
4bc0506 
…alyzing. (apache#49918)

This pr includes 3 changes.
1. Nereids support set ScanNode preagg on by hint, like this: select *
from table1 /*+PREAGGOPEN*/
2. When sample analyze agg table and mor unique table, set preagg on to
improve performance.
3. Skip sample analyzing agg table and mor unique table's value columns.
@Thearas
Copy link
Contributor

Thearas commented Jun 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run buildall

1 similar comment
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 13, 2025

run buildall

@Jibing-Li Jibing-Li marked this pull request as ready for review June 13, 2025 07:15
@Jibing-Li Jibing-Li requested a review from dataroaring as a code owner June 13, 2025 07:15
dataroaring
dataroaring approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ce42bb5 into apache:branch-3.0 Jun 13, 2025
21 of 24 checks passed
@Jibing-Li Jibing-Li deleted the agg3.0 branch June 13, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jibing-Li @Thearas @dataroaring