Skip to content

branch-2.1: [improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer #51659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jun 16, 2025
Merged

branch-2.1: [improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer #51659

yiguolei merged 1 commit into from
Jun 16, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Jun 12, 2025

pick #51285

@zy-kkk
[improvement](jdbc catalog) Optimize the acquisition of indentity typ…
fa0c32c 
…e in SQLServer (apache#51285)

1、In SQLServer, if a type is indentity, then the display of its original
type may be changed, such as decimal -> decima(), so we get the string
from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType
method to build the type
@zy-kkk zy-kkk requested a review from yiguolei as a code owner June 12, 2025 03:15
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Jun 12, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 3a1e95c into apache:branch-2.1 Jun 16, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zy-kkk @hello-stephen @morningman @yiguolei