Skip to content

branch-2.1:[fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's enough rdlock inside tablet internal function calls.#39211 #51611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jun 20, 2025
Merged

branch-2.1:[fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's enough rdlock inside tablet internal function calls.#39211 #51611

yiguolei merged 1 commit into from
Jun 20, 2025

Conversation

@dtkavin
Copy link
Contributor

@dtkavin dtkavin commented Jun 10, 2025

cherry-pick: #39211

@dtkavin
[fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's…
d8b0de2 
… enough rdlock inside tablet internal function calls
@dtkavin dtkavin requested a review from yiguolei as a code owner June 10, 2025 08:53
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dtkavin
Copy link
Contributor Author

dtkavin commented Jun 10, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 10, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.03% (10326/26457)
Line Coverage 30.03% (85770/285652)
Region Coverage 28.69% (44259/154270)
Branch Coverage 25.42% (22652/89126)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 10, 2025

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.58% (19435/26061)
Line Coverage 69.24% (196515/283808)
Region Coverage 66.83% (120003/179559)
Branch Coverage 59.87% (60328/100758)

@felixwluo felixwluo changed the title [fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's… branch-2.1:[fix](cooldown)No need to rdlock inside get_cooldown_tablets, there's enough rdlock inside tablet internal function calls.#39211 Jun 10, 2025
dataroaring
dataroaring approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 0230d60 into apache:branch-2.1 Jun 20, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dtkavin @hello-stephen @yiguolei @dataroaring