Skip to content

branch-2.1: [fix](jdbc)make sure init the jdbc client before using it #51541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Jun 20, 2025
Merged

branch-2.1: [fix](jdbc)make sure init the jdbc client before using it #51541

yiguolei merged 2 commits into from
Jun 20, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 6, 2025 •
edited
Loading

This may cause some statistic collection task fail:

2025-06-05 15:02:32,277 WARN (Statistics Job Appender|182) [ExternalCatalog.buildDbForInit():902] Failed to check db DORIS_TEST exist in remote system, ignore it.
java.lang.NullPointerException: Cannot invoke "org.apache.doris.datasource.jdbc.client.JdbcClient.getDatabaseNameList()" because "this.jdbcClient" is null
        at org.apache.doris.datasource.jdbc.JdbcExternalCatalog.listDatabaseNames(JdbcExternalCatalog.java:267) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.datasource.ExternalCatalog.getFilteredDatabaseNames(ExternalCatalog.java:476) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.datasource.ExternalCatalog.lambda$makeSureInitialized$0(ExternalCatalog.java:318) ~[doris-fe.jar:1.2-SNAPSHOT]
        at com.github.benmanes.caffeine.cache.LocalLoadingCache.lambda$newMappingFunction$2(LocalLoadingCache.java:145) ~[hive-catalog-shade-2.1.4.jar:2.1.4]
        at com.github.benmanes.caffeine.cache.LocalCache.lambda$statsAware$0(LocalCache.java:139) ~[hive-catalog-shade-2.1.4.jar:2.1.4]
        at com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$doComputeIfAbsent$14(BoundedLocalCache.java:2406) ~[hive-catalog-shade-2.1.4.jar:2.1.4]
        at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1916) ~[?:?]

Only for branch-2.1.
Fix master in #51471

@morningman morningman requested a review from yiguolei as a code owner June 6, 2025 02:38
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman morningman changed the title branch-2.1: make sure init the jdbc client before using it branch-2.1: [fix](jdbc)make sure init the jdbc client before using it Jun 6, 2025
@morningman
Copy link
Contributor Author

morningman commented Jun 6, 2025

run buildall

zy-kkk
zy-kkk previously approved these changes Jun 6, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

yiguolei commented Jun 16, 2025

run buildall

@morningman
Copy link
Contributor Author

morningman commented Jun 19, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 19, 2025
@yiguolei yiguolei merged commit 43a5116 into apache:branch-2.1 Jun 20, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zy-kkk zy-kkk zy-kkk left review comments

Assignees

No one assigned

Labels

dev/2.1.11-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman @hello-stephen @yiguolei @zy-kkk