Skip to content

branch-2.1: [fix](iceberg)Fix the thread pool issue used for commit. #51508 #51528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Jul 10, 2025
Merged

branch-2.1: [fix](iceberg)Fix the thread pool issue used for commit. #51508 #51528

yiguolei merged 2 commits into from
Jul 10, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 5, 2025

Cherry-picked from #51508

@github-actions github-actions bot requested a review from yiguolei as a code owner June 5, 2025 09:37
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jun 5, 2025
@dataroaring dataroaring reopened this Jun 5, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 5, 2025

run buildall

@wuwenchi @morningman
[fix](iceberg)Fix the thread pool issue used for commit. (#51508)
1cdba2c 
### What problem does this PR solve?

Problem Summary:

When Iceberg generates a new snapshot, it performs a merge operation
based on the previous snapshot. This operation reads manifest files, and
the file reading process uses a global thread pool. However, users may
have their own authentication information, which requires the use of
doAs to ensure context. Therefore, the thread pool provided by Iceberg
cannot be used.

### Release note

None
@morningman morningman force-pushed the auto-pick-51508-branch-2.1 branch from 930410c to 1cdba2c Compare July 9, 2025 14:13
@morningman
Copy link
Contributor

morningman commented Jul 9, 2025

run buildall

@yiguolei yiguolei merged commit 03994b8 into branch-2.1 Jul 10, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-51508-branch-2.1 branch July 10, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @morningman @yiguolei @dataroaring @wuwenchi