Skip to content

branch-3.0: [improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer #51285 #51317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 11, 2025
Merged

branch-3.0: [improvement](jdbc catalog) Optimize the acquisition of indentity type in SQLServer #51285 #51317

dataroaring merged 1 commit into from
Jun 11, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 28, 2025

Cherry-picked from #51285

@zy-kkk
[improvement](jdbc catalog) Optimize the acquisition of indentity typ…
be58abd 
…e in SQLServer (#51285)

1、In SQLServer, if a type is indentity, then the display of its original
type may be changed, such as decimal -> decima(), so we get the string
from subscript 0 to ( before as typename
2、For decimal, we should use the unified createDecimalOrStringType
method to build the type
@github-actions github-actions bot requested a review from dataroaring as a code owner May 28, 2025 06:13
@Thearas
Copy link
Contributor

Thearas commented May 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this May 28, 2025
@Thearas
Copy link
Contributor

Thearas commented May 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 28, 2025

TPC-H: Total hot run time: 39865 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit be58abd55b5b4cef4f4d2ab828208023d0163d35, data reload: false

------ Round 1 ----------------------------------
q1	17585	6858	6648	6648
q2	2076	176	164	164
q3	10594	1091	1168	1091
q4	10570	704	716	704
q5	7760	2854	2765	2765
q6	218	136	137	136
q7	996	619	611	611
q8	9384	1951	2080	1951
q9	6711	6431	6466	6431
q10	6989	2226	2288	2226
q11	464	262	260	260
q12	401	212	215	212
q13	17810	2963	3025	2963
q14	230	207	203	203
q15	502	460	473	460
q16	500	376	378	376
q17	981	609	614	609
q18	7490	6753	6776	6753
q19	1415	1020	1085	1020
q20	494	209	207	207
q21	4242	3268	3124	3124
q22	1097	951	1005	951
Total cold run time: 108509 ms
Total hot run time: 39865 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6638	6615	6580	6580
q2	340	233	240	233
q3	2937	2806	2985	2806
q4	1997	1801	1826	1801
q5	5878	5757	5756	5756
q6	217	132	135	132
q7	2254	1780	1841	1780
q8	3402	3596	3557	3557
q9	8956	8839	8878	8839
q10	3587	3529	3506	3506
q11	586	504	514	504
q12	809	638	623	623
q13	8540	3144	3207	3144
q14	288	248	280	248
q15	504	476	466	466
q16	489	443	457	443
q17	1829	1653	1620	1620
q18	8443	7726	7784	7726
q19	1704	1459	1548	1459
q20	2100	1788	1814	1788
q21	5525	5409	5455	5409
q22	1129	1038	1009	1009
Total cold run time: 68152 ms
Total hot run time: 59429 ms

@doris-robot
Copy link

doris-robot commented May 28, 2025

TPC-DS: Total hot run time: 196570 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit be58abd55b5b4cef4f4d2ab828208023d0163d35, data reload: false

query1	1317	931	915	915
query2	6336	1902	1837	1837
query3	10780	4248	4420	4248
query4	60788	30219	23569	23569
query5	5165	447	442	442
query6	396	171	160	160
query7	5473	323	330	323
query8	306	211	209	209
query9	8666	2590	2585	2585
query10	433	272	266	266
query11	17841	15101	15582	15101
query12	157	102	102	102
query13	1474	454	444	444
query14	10714	7024	7158	7024
query15	205	182	186	182
query16	7132	491	507	491
query17	1182	572	565	565
query18	1867	315	330	315
query19	222	152	173	152
query20	116	120	110	110
query21	201	99	98	98
query22	4681	4480	4733	4480
query23	34817	34503	33839	33839
query24	6295	2996	2952	2952
query25	544	428	420	420
query26	652	174	168	168
query27	1730	365	368	365
query28	3789	2174	2192	2174
query29	708	472	458	458
query30	246	154	159	154
query31	989	818	835	818
query32	72	60	57	57
query33	418	295	299	295
query34	934	525	523	523
query35	845	746	767	746
query36	1049	946	950	946
query37	111	69	72	69
query38	4038	3958	3945	3945
query39	1493	1476	1455	1455
query40	217	106	105	105
query41	50	53	51	51
query42	118	104	107	104
query43	521	484	484	484
query44	1181	859	844	844
query45	190	173	168	168
query46	1160	746	734	734
query47	2004	1884	1903	1884
query48	506	372	391	372
query49	734	440	436	436
query50	828	443	439	439
query51	7439	7304	7357	7304
query52	110	97	98	97
query53	268	205	202	202
query54	591	488	489	488
query55	86	90	81	81
query56	313	263	247	247
query57	1280	1156	1158	1156
query58	230	219	227	219
query59	3209	2944	2941	2941
query60	286	259	261	259
query61	108	145	133	133
query62	760	667	681	667
query63	218	192	196	192
query64	1384	660	628	628
query65	3243	3201	3233	3201
query66	719	304	296	296
query67	15915	15684	15452	15452
query68	4099	581	598	581
query69	444	267	265	265
query70	1175	1090	1082	1082
query71	355	260	265	260
query72	6356	4063	4065	4063
query73	751	346	346	346
query74	10540	9005	8933	8933
query75	3347	2610	2627	2610
query76	2232	1149	1058	1058
query77	510	279	276	276
query78	10550	9635	9575	9575
query79	2045	588	610	588
query80	1356	439	427	427
query81	517	230	218	218
query82	1264	91	92	91
query83	278	153	145	145
query84	276	82	84	82
query85	1002	303	292	292
query86	401	287	298	287
query87	4398	4217	4247	4217
query88	3978	2379	2339	2339
query89	426	290	284	284
query90	1967	186	188	186
query91	186	146	146	146
query92	62	50	50	50
query93	2975	564	568	564
query94	779	296	302	296
query95	365	259	262	259
query96	623	284	275	275
query97	3305	3172	3094	3094
query98	226	206	190	190
query99	1611	1323	1305	1305
Total cold run time: 316249 ms
Total hot run time: 196570 ms

@doris-robot
Copy link

doris-robot commented May 28, 2025

ClickBench: Total hot run time: 30.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit be58abd55b5b4cef4f4d2ab828208023d0163d35, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.52	0.51	0.51
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.49	0.50
query10	0.55	0.54	0.54
query11	0.14	0.12	0.11
query12	0.15	0.12	0.11
query13	0.61	0.59	0.60
query14	0.78	0.79	0.81
query15	0.85	0.82	0.83
query16	0.40	0.36	0.39
query17	1.07	1.02	1.06
query18	0.23	0.22	0.21
query19	2.01	1.87	1.84
query20	0.01	0.01	0.01
query21	15.39	0.62	0.60
query22	3.17	2.13	1.98
query23	17.14	0.81	0.75
query24	3.06	1.39	1.59
query25	0.27	0.11	0.13
query26	0.49	0.14	0.14
query27	0.05	0.04	0.04
query28	9.46	0.53	0.45
query29	12.65	3.20	3.21
query30	0.24	0.05	0.05
query31	2.86	0.39	0.39
query32	3.26	0.46	0.46
query33	3.01	3.03	3.02
query34	17.10	4.53	4.49
query35	4.55	4.47	4.61
query36	0.69	0.48	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.12	0.12
query41	0.07	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 104.93 s
Total hot run time: 30.72 s

dataroaring
dataroaring approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8e31467 into branch-3.0 Jun 11, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-51285-branch-3.0 branch June 11, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @zy-kkk