Skip to content

branch-3.0: [hotfix](jdbc catalog) Fix jdbcclient repeated initialization #51037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
May 20, 2025
Merged

branch-3.0: [hotfix](jdbc catalog) Fix jdbcclient repeated initialization #51037

dataroaring merged 2 commits into from
May 20, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented May 19, 2025 •
edited
Loading

pick #51036

@zy-kkk zy-kkk requested a review from dataroaring as a code owner May 19, 2025 09:53
@Thearas
Copy link
Contributor

Thearas commented May 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented May 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 19, 2025

TPC-H: Total hot run time: 39658 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a668c87219d397c7c784b44da181e706b70ed789, data reload: false

------ Round 1 ----------------------------------
q1	17570	6674	6566	6566
q2	2053	170	178	170
q3	10776	1076	1160	1076
q4	10449	756	711	711
q5	7756	2792	2829	2792
q6	216	134	128	128
q7	1007	626	602	602
q8	9357	1927	2037	1927
q9	6601	6410	6333	6333
q10	6994	2221	2323	2221
q11	469	268	258	258
q12	407	208	206	206
q13	17806	2955	2990	2955
q14	240	204	202	202
q15	499	465	467	465
q16	685	590	576	576
q17	986	581	550	550
q18	7121	6670	6558	6558
q19	1405	1053	1096	1053
q20	476	201	200	200
q21	4027	3244	3134	3134
q22	1043	987	975	975
Total cold run time: 107943 ms
Total hot run time: 39658 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6619	6611	6618	6611
q2	323	244	234	234
q3	2916	2880	2934	2880
q4	2107	1797	1824	1797
q5	5917	5896	5873	5873
q6	211	127	131	127
q7	2217	1897	1847	1847
q8	3381	3584	3529	3529
q9	8991	8903	8845	8845
q10	3575	3528	3520	3520
q11	588	485	493	485
q12	818	635	647	635
q13	9838	3428	3299	3299
q14	328	304	297	297
q15	501	468	478	468
q16	703	664	686	664
q17	1898	1649	1630	1630
q18	8642	8702	7829	7829
q19	3586	1639	1670	1639
q20	2065	1826	1803	1803
q21	5621	5377	5300	5300
q22	1118	1049	999	999
Total cold run time: 71963 ms
Total hot run time: 60311 ms

@doris-robot
Copy link

doris-robot commented May 19, 2025

TPC-DS: Total hot run time: 196928 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a668c87219d397c7c784b44da181e706b70ed789, data reload: false

query1	1280	908	906	906
query2	6354	1996	2016	1996
query3	10787	4399	4260	4260
query4	61552	29162	23494	23494
query5	5205	467	468	467
query6	408	198	179	179
query7	5429	307	310	307
query8	301	254	223	223
query9	8289	2582	2585	2582
query10	469	279	264	264
query11	17608	15311	15683	15311
query12	163	111	103	103
query13	1441	431	423	423
query14	10488	7017	7527	7017
query15	209	183	177	177
query16	7084	493	491	491
query17	1154	594	577	577
query18	1952	336	320	320
query19	231	165	159	159
query20	117	114	112	112
query21	212	101	106	101
query22	4692	4522	4559	4522
query23	34539	33880	33695	33695
query24	6054	2931	3001	2931
query25	540	434	425	425
query26	676	197	168	168
query27	1826	371	364	364
query28	4345	2463	2437	2437
query29	678	445	428	428
query30	237	166	160	160
query31	1005	805	840	805
query32	71	56	59	56
query33	450	276	277	276
query34	889	499	513	499
query35	836	743	739	739
query36	1074	966	959	959
query37	119	67	68	67
query38	4099	3999	3892	3892
query39	1536	1486	1463	1463
query40	203	101	102	101
query41	50	50	51	50
query42	119	103	96	96
query43	528	475	495	475
query44	1139	812	849	812
query45	189	171	172	171
query46	1168	725	715	715
query47	2001	1942	1981	1942
query48	472	379	399	379
query49	727	400	391	391
query50	828	426	424	424
query51	7382	7054	7135	7054
query52	102	91	88	88
query53	257	186	185	185
query54	561	485	461	461
query55	80	78	80	78
query56	268	242	238	238
query57	1285	1191	1154	1154
query58	219	237	219	219
query59	3244	3064	2902	2902
query60	293	263	266	263
query61	116	128	127	127
query62	796	689	691	689
query63	228	192	191	191
query64	1529	679	654	654
query65	3301	3190	3192	3190
query66	700	295	292	292
query67	15992	15633	15643	15633
query68	4326	574	562	562
query69	444	264	259	259
query70	1154	1076	1107	1076
query71	375	290	249	249
query72	6410	4220	4103	4103
query73	744	344	355	344
query74	10235	9237	9277	9237
query75	3332	2620	2649	2620
query76	1893	996	1101	996
query77	473	279	273	273
query78	10623	9644	9501	9501
query79	1949	594	589	589
query80	1406	423	435	423
query81	529	244	241	241
query82	1224	89	86	86
query83	273	144	139	139
query84	283	81	78	78
query85	995	299	293	293
query86	396	297	301	297
query87	4468	4287	4246	4246
query88	3618	2365	2330	2330
query89	412	294	291	291
query90	1952	182	180	180
query91	181	149	149	149
query92	65	50	57	50
query93	2084	551	544	544
query94	785	296	299	296
query95	360	257	263	257
query96	631	286	282	282
query97	3323	3173	3135	3135
query98	216	202	193	193
query99	1594	1293	1280	1280
Total cold run time: 314929 ms
Total hot run time: 196928 ms

@doris-robot
Copy link

doris-robot commented May 19, 2025

ClickBench: Total hot run time: 31.9 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a668c87219d397c7c784b44da181e706b70ed789, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.06	0.06
query4	1.62	0.11	0.10
query5	0.52	0.50	0.50
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.56	0.51	0.51
query10	0.55	0.54	0.55
query11	0.14	0.10	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.61
query14	2.85	2.74	2.83
query15	0.89	0.83	0.83
query16	0.38	0.39	0.38
query17	1.08	1.08	1.01
query18	0.23	0.22	0.22
query19	1.93	1.90	2.03
query20	0.01	0.01	0.01
query21	15.38	0.60	0.62
query22	3.15	2.59	1.72
query23	16.93	1.13	0.88
query24	3.00	0.90	1.68
query25	0.29	0.05	0.07
query26	0.54	0.13	0.13
query27	0.06	0.05	0.04
query28	9.98	0.48	0.44
query29	12.57	3.23	3.15
query30	0.24	0.06	0.06
query31	2.87	0.40	0.37
query32	3.26	0.46	0.45
query33	3.00	2.97	3.01
query34	17.26	4.44	4.46
query35	4.54	4.48	4.52
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.29 s
Total hot run time: 31.9 s

@dataroaring
Copy link
Contributor

dataroaring commented May 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 19, 2025

TPC-H: Total hot run time: 39869 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9a6068b2f107d78db351febefd9dcd5b029b785, data reload: false

------ Round 1 ----------------------------------
q1	17559	6821	6610	6610
q2	2048	166	173	166
q3	10705	1105	1166	1105
q4	10555	740	698	698
q5	7778	2837	2775	2775
q6	221	137	135	135
q7	968	632	615	615
q8	9358	1922	1984	1922
q9	6600	6373	6426	6373
q10	7040	2251	2272	2251
q11	464	264	258	258
q12	404	213	222	213
q13	17775	2962	2978	2962
q14	236	202	203	202
q15	504	457	475	457
q16	664	595	570	570
q17	966	525	534	525
q18	7141	6516	6762	6516
q19	1400	1120	1063	1063
q20	477	200	202	200
q21	3964	3264	3321	3264
q22	1090	989	989	989
Total cold run time: 107917 ms
Total hot run time: 39869 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6617	6609	6660	6609
q2	343	240	240	240
q3	2955	2820	2898	2820
q4	2022	1776	1838	1776
q5	5857	5806	5799	5799
q6	213	135	129	129
q7	2225	1842	1836	1836
q8	3353	3592	3536	3536
q9	8968	8839	8915	8839
q10	3531	3509	3497	3497
q11	584	499	478	478
q12	845	618	630	618
q13	8241	3138	3204	3138
q14	296	261	261	261
q15	504	477	457	457
q16	689	641	632	632
q17	1844	1637	1634	1634
q18	8141	7735	7700	7700
q19	1704	1451	1506	1451
q20	2094	1786	1841	1786
q21	5424	5418	5357	5357
q22	1104	1015	996	996
Total cold run time: 67554 ms
Total hot run time: 59589 ms

@doris-robot
Copy link

doris-robot commented May 19, 2025

TPC-DS: Total hot run time: 196656 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9a6068b2f107d78db351febefd9dcd5b029b785, data reload: false

query1	1286	901	894	894
query2	6326	2020	1950	1950
query3	10822	4261	4226	4226
query4	61071	29263	23467	23467
query5	5225	452	447	447
query6	411	171	173	171
query7	5480	315	313	313
query8	320	223	222	222
query9	8677	2578	2566	2566
query10	472	268	252	252
query11	17678	15158	15677	15158
query12	162	107	101	101
query13	1460	442	435	435
query14	10501	6879	7242	6879
query15	201	177	184	177
query16	7154	505	435	435
query17	1273	588	599	588
query18	1951	324	318	318
query19	219	159	160	159
query20	117	115	109	109
query21	214	105	112	105
query22	4741	4556	4626	4556
query23	34896	34143	34020	34020
query24	6145	2879	2990	2879
query25	536	435	440	435
query26	663	169	170	169
query27	1856	381	360	360
query28	4363	2439	2477	2439
query29	727	499	460	460
query30	244	169	158	158
query31	996	808	818	808
query32	67	54	57	54
query33	416	288	284	284
query34	921	504	524	504
query35	837	724	747	724
query36	1057	950	979	950
query37	121	65	71	65
query38	4000	3934	3950	3934
query39	1516	1451	1492	1451
query40	206	101	97	97
query41	51	48	49	48
query42	110	99	97	97
query43	536	494	492	492
query44	1190	816	809	809
query45	193	170	164	164
query46	1138	714	712	712
query47	1995	1917	1923	1917
query48	476	379	376	376
query49	754	413	391	391
query50	847	430	430	430
query51	7483	7264	7348	7264
query52	99	88	91	88
query53	269	182	191	182
query54	566	461	483	461
query55	77	84	80	80
query56	263	254	246	246
query57	1290	1126	1191	1126
query58	210	216	218	216
query59	3108	3097	2968	2968
query60	271	247	244	244
query61	114	108	104	104
query62	778	686	688	686
query63	227	197	185	185
query64	1416	676	646	646
query65	3285	3175	3224	3175
query66	703	294	303	294
query67	15988	15440	15459	15440
query68	4278	581	572	572
query69	441	264	259	259
query70	1132	1073	1054	1054
query71	346	244	256	244
query72	6085	4190	4022	4022
query73	753	337	348	337
query74	10185	9103	9074	9074
query75	3344	2621	2683	2621
query76	2005	1093	1133	1093
query77	474	266	271	266
query78	10598	9761	9607	9607
query79	1524	589	593	589
query80	857	429	455	429
query81	506	237	235	235
query82	1298	83	86	83
query83	166	138	143	138
query84	284	86	76	76
query85	870	308	291	291
query86	325	267	298	267
query87	4511	4187	4277	4187
query88	3826	2357	2365	2357
query89	421	288	288	288
query90	2008	186	187	186
query91	188	151	148	148
query92	66	51	56	51
query93	1918	555	562	555
query94	741	290	297	290
query95	361	270	266	266
query96	607	289	278	278
query97	3279	3153	3164	3153
query98	218	198	188	188
query99	1612	1310	1292	1292
Total cold run time: 313992 ms
Total hot run time: 196656 ms

@doris-robot
Copy link

doris-robot commented May 19, 2025

ClickBench: Total hot run time: 31.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a9a6068b2f107d78db351febefd9dcd5b029b785, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.04
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.53	0.51	0.50
query6	1.13	0.73	0.72
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.48
query10	0.55	0.55	0.56
query11	0.14	0.10	0.10
query12	0.16	0.12	0.11
query13	0.62	0.59	0.59
query14	2.85	2.85	2.76
query15	0.90	0.84	0.82
query16	0.37	0.37	0.37
query17	1.02	0.96	1.07
query18	0.23	0.21	0.22
query19	1.95	1.87	2.00
query20	0.01	0.01	0.02
query21	15.36	0.60	0.61
query22	2.52	1.52	2.25
query23	17.16	0.89	0.81
query24	3.35	0.92	1.35
query25	0.14	0.16	0.16
query26	0.48	0.14	0.14
query27	0.05	0.05	0.04
query28	9.91	0.47	0.46
query29	12.53	3.19	3.18
query30	0.25	0.06	0.06
query31	2.87	0.40	0.38
query32	3.26	0.47	0.45
query33	2.94	2.99	3.02
query34	17.25	4.46	4.47
query35	4.49	4.55	4.51
query36	0.68	0.47	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.8 s
Total hot run time: 31.76 s

dataroaring
dataroaring approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ddbc99a into apache:branch-3.0 May 20, 2025
25 of 26 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk @Thearas @doris-robot @dataroaring @morningman