Skip to content

[Bug](cancel) fix ctrl+c can not cancel query #50916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BiteTheDDDDt wants to merge 8 commits into from
Closed

[Bug](cancel) fix ctrl+c can not cancel query #50916

BiteTheDDDDt wants to merge 8 commits into from

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented May 14, 2025 •
edited
Loading

What problem does this PR solve?

before

mysql> select count(*) from d_table;
+----------+
| count(*) |
+----------+
| 10000000 |
+----------+
1 row in set (0.23 sec)

mysql> select * from d_table;
^C^C -- query aborted
+---------+---------+---------+------+
| k1      | k2      | k3      | k4   |
+---------+---------+---------+------+
|       2 |       2 |       2 | a    |
+---------+---------+---------+------+
10000000 rows in set (1 min 6.28 sec)

after:

mysql> select * from d_table;
^C^C -- query aborted
ERROR 1105 (HY000): errCode = 2, detailMessage = cancel query by user from 127.0.0.1:53598

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 14, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented May 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 14, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 14, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.32% (20833/26264)
Line Coverage 72.50% (214326/295627)
Region Coverage 70.67% (126057/178381)
Branch Coverage 64.45% (65339/101386)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 15, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 15, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.82% (14903/26698)
Line Coverage 44.61% (131937/295750)
Region Coverage 43.66% (66331/151920)
Branch Coverage 38.27% (33983/88798)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 15, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 15, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 15, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 15, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.25% (20813/26264)
Line Coverage 72.46% (214270/295689)
Region Coverage 70.65% (126065/178432)
Branch Coverage 64.38% (65295/101414)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 16, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.87% (14883/26641)
Line Coverage 44.65% (131877/295362)
Region Coverage 43.76% (66396/151731)
Branch Coverage 38.36% (34020/88690)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented May 16, 2025

This problem has been fixed in #50791, so close the PR

@BiteTheDDDDt BiteTheDDDDt mentioned this pull request May 16, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BiteTheDDDDt @Thearas @hello-stephen