Skip to content

branch-3.0: [fix](jdbc catalog) fix a jdbc catalog npe #50911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
May 15, 2025
Merged

branch-3.0: [fix](jdbc catalog) fix a jdbc catalog npe #50911

dataroaring merged 1 commit into from
May 15, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented May 14, 2025

cherry-pick #50901

@zy-kkk zy-kkk requested a review from dataroaring as a code owner May 14, 2025 10:49
@Thearas
Copy link
Contributor

Thearas commented May 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk zy-kkk changed the title [fix](jdbc catalog) fix a jdbc catalog npe branch-3.0: [fix](jdbc catalog) fix a jdbc catalog npe May 14, 2025
@zy-kkk
Copy link
Member Author

zy-kkk commented May 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-H: Total hot run time: 40466 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f25db661fa1689bfc4c847a078a19aff9dbd4efd, data reload: false

------ Round 1 ----------------------------------
q1	17663	6814	6609	6609
q2	2035	181	167	167
q3	10627	1051	1152	1051
q4	10561	713	805	713
q5	7737	2856	2831	2831
q6	221	133	131	131
q7	978	642	599	599
q8	9351	1956	2004	1956
q9	6579	6411	6360	6360
q10	7056	2287	2303	2287
q11	460	250	256	250
q12	401	214	212	212
q13	17779	2936	2966	2936
q14	242	211	209	209
q15	499	480	463	463
q16	672	588	584	584
q17	973	525	541	525
q18	7333	6970	7014	6970
q19	1435	1124	1140	1124
q20	468	206	203	203
q21	4074	3315	3300	3300
q22	1077	1005	986	986
Total cold run time: 108221 ms
Total hot run time: 40466 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6617	6601	6621	6601
q2	328	230	227	227
q3	2874	2746	2911	2746
q4	2052	1839	1826	1826
q5	5763	5740	5717	5717
q6	214	129	131	129
q7	2246	1807	1766	1766
q8	3367	3507	3519	3507
q9	8898	8820	8913	8820
q10	3586	3503	3514	3503
q11	597	509	490	490
q12	846	576	589	576
q13	8993	3223	3160	3160
q14	305	267	269	267
q15	518	468	456	456
q16	681	640	647	640
q17	1841	1629	1623	1623
q18	8299	7684	7720	7684
q19	1662	1540	1546	1540
q20	2052	1890	1878	1878
q21	5421	5325	5291	5291
q22	1120	1047	1020	1020
Total cold run time: 68280 ms
Total hot run time: 59467 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-DS: Total hot run time: 197633 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f25db661fa1689bfc4c847a078a19aff9dbd4efd, data reload: false

query1	1298	896	896	896
query2	6238	2111	2068	2068
query3	10937	4501	4421	4421
query4	61747	28879	23384	23384
query5	5203	450	449	449
query6	409	185	179	179
query7	5516	312	306	306
query8	306	228	228	228
query9	8657	2614	2608	2608
query10	498	278	265	265
query11	17644	15294	15698	15294
query12	167	108	103	103
query13	1456	469	445	445
query14	10615	7315	7731	7315
query15	206	189	177	177
query16	7155	517	489	489
query17	1189	589	582	582
query18	1878	328	310	310
query19	219	163	164	163
query20	116	111	113	111
query21	215	108	106	106
query22	4774	4453	4631	4453
query23	34744	34058	34539	34058
query24	6181	2897	2916	2897
query25	533	456	435	435
query26	658	180	173	173
query27	1823	363	374	363
query28	4235	2458	2433	2433
query29	714	443	425	425
query30	244	161	166	161
query31	968	787	840	787
query32	68	57	57	57
query33	446	291	291	291
query34	924	510	514	510
query35	844	722	745	722
query36	1081	949	978	949
query37	116	66	67	66
query38	4095	3981	4050	3981
query39	1532	1457	1483	1457
query40	201	103	107	103
query41	50	49	46	46
query42	113	106	101	101
query43	540	510	515	510
query44	1181	836	819	819
query45	195	172	165	165
query46	1146	709	729	709
query47	2018	1890	1928	1890
query48	477	397	386	386
query49	748	417	379	379
query50	849	410	419	410
query51	7203	7281	7128	7128
query52	105	91	87	87
query53	274	191	185	185
query54	580	470	468	468
query55	80	81	78	78
query56	272	259	250	250
query57	1282	1172	1159	1159
query58	218	209	204	204
query59	3216	2996	3094	2996
query60	273	259	246	246
query61	115	106	110	106
query62	798	698	699	698
query63	225	196	188	188
query64	1395	700	662	662
query65	3280	3193	3212	3193
query66	714	302	293	293
query67	15928	15728	15803	15728
query68	4347	571	571	571
query69	444	273	266	266
query70	1161	1115	1086	1086
query71	355	265	267	265
query72	6455	4001	4086	4001
query73	755	351	350	350
query74	10210	8974	9301	8974
query75	3372	2647	2670	2647
query76	2016	978	1147	978
query77	459	270	271	270
query78	10529	9711	9548	9548
query79	1348	592	599	592
query80	855	455	433	433
query81	501	243	245	243
query82	1301	86	87	86
query83	244	138	146	138
query84	286	81	83	81
query85	865	297	291	291
query86	319	295	287	287
query87	4385	4259	4195	4195
query88	3956	2376	2373	2373
query89	414	298	297	297
query90	2010	188	184	184
query91	180	150	147	147
query92	61	52	52	52
query93	1867	554	555	554
query94	737	299	303	299
query95	358	273	249	249
query96	609	282	284	282
query97	3305	3101	3251	3101
query98	217	223	203	203
query99	1899	1304	1286	1286
Total cold run time: 314945 ms
Total hot run time: 197633 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

ClickBench: Total hot run time: 32.32 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f25db661fa1689bfc4c847a078a19aff9dbd4efd, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.10
query5	0.50	0.52	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.51
query10	0.55	0.56	0.56
query11	0.14	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.60	0.59
query14	2.73	2.73	2.78
query15	0.87	0.84	0.83
query16	0.39	0.37	0.39
query17	1.03	1.04	1.03
query18	0.25	0.22	0.22
query19	1.93	1.77	2.00
query20	0.02	0.01	0.01
query21	15.36	0.57	0.59
query22	2.75	2.71	2.29
query23	17.05	0.89	0.88
query24	3.47	0.98	0.67
query25	0.28	0.05	0.09
query26	0.38	0.14	0.14
query27	0.04	0.04	0.05
query28	10.59	0.54	0.45
query29	12.59	3.20	3.20
query30	0.25	0.06	0.05
query31	2.88	0.39	0.38
query32	3.22	0.46	0.47
query33	3.00	2.99	3.05
query34	16.86	4.54	4.48
query35	4.53	4.56	4.59
query36	0.67	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.24 s
Total hot run time: 32.32 s

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9f09730 into apache:branch-3.0 May 15, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk @Thearas @doris-robot @morningman @dataroaring