Skip to content

branch-3.0: [fix](cooldown) allow cooldown_ttl = 0 when altering storage policy #50830 #50854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
May 14, 2025
Merged

branch-3.0: [fix](cooldown) allow cooldown_ttl = 0 when altering storage policy #50830 #50854

dataroaring merged 1 commit into from
May 14, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 13, 2025

Cherry-picked from #50830

@luwei16
[fix](cooldown) allow cooldown_ttl = 0 when altering storage policy (#…
26b885d 
…50830)

mysql> ALTER STORAGE POLICY s3_db PROPERTIES ("cooldown_ttl" = "0");
ERROR 1105 (HY000): errCode = 2, detailMessage = cooldown_datetime or cooldown_ttl must be set
@github-actions github-actions bot requested a review from dataroaring as a code owner May 13, 2025 08:28
@hello-stephen
Copy link
Contributor

hello-stephen commented May 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this May 13, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented May 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 13, 2025

TPC-H: Total hot run time: 40364 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 26b885de3e8b4be81b8d6c8d7f54f26e0f631482, data reload: false

------ Round 1 ----------------------------------
q1	17601	6766	6605	6605
q2	2037	166	177	166
q3	10834	1104	1163	1104
q4	10501	719	693	693
q5	7770	2809	2878	2809
q6	224	133	136	133
q7	1027	617	641	617
q8	9353	1929	2017	1929
q9	6666	6482	6459	6459
q10	7053	2231	2266	2231
q11	470	267	265	265
q12	401	208	208	208
q13	18846	3009	3001	3001
q14	240	211	206	206
q15	517	465	456	456
q16	696	587	594	587
q17	983	563	577	563
q18	7223	6768	6675	6675
q19	1411	1097	1085	1085
q20	473	209	195	195
q21	4102	3326	3623	3326
q22	1090	1051	1051	1051
Total cold run time: 109518 ms
Total hot run time: 40364 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6766	6650	6623	6623
q2	329	242	235	235
q3	3062	3096	3068	3068
q4	2162	1879	1905	1879
q5	5939	5920	5843	5843
q6	211	135	131	131
q7	2203	1771	1841	1771
q8	3459	3684	3604	3604
q9	9144	8975	9047	8975
q10	3596	3516	3506	3506
q11	584	488	494	488
q12	771	629	604	604
q13	14614	3124	3214	3124
q14	287	274	284	274
q15	532	462	465	462
q16	698	672	641	641
q17	1846	1594	1617	1594
q18	8317	7659	7771	7659
q19	1701	1690	1544	1544
q20	2056	1785	1811	1785
q21	5544	5468	5198	5198
q22	1148	1069	991	991
Total cold run time: 74969 ms
Total hot run time: 59999 ms

@doris-robot
Copy link

doris-robot commented May 13, 2025

TPC-DS: Total hot run time: 198184 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 26b885de3e8b4be81b8d6c8d7f54f26e0f631482, data reload: false

query1	1271	898	923	898
query2	6320	2093	2067	2067
query3	10966	4581	4458	4458
query4	61700	32821	23615	23615
query5	4666	461	455	455
query6	404	175	176	175
query7	5491	310	308	308
query8	308	219	228	219
query9	8528	2592	2569	2569
query10	446	257	257	257
query11	16529	15208	15889	15208
query12	155	104	99	99
query13	1469	450	449	449
query14	10328	6698	6763	6698
query15	200	182	171	171
query16	7123	530	475	475
query17	1232	592	601	592
query18	1871	327	354	327
query19	214	170	162	162
query20	122	111	107	107
query21	213	105	103	103
query22	4767	4632	4568	4568
query23	34826	34271	34179	34179
query24	6072	2996	2993	2993
query25	534	429	423	423
query26	661	168	176	168
query27	1889	370	352	352
query28	4074	2461	2424	2424
query29	681	458	443	443
query30	239	165	161	161
query31	993	816	849	816
query32	64	57	56	56
query33	453	297	295	295
query34	909	502	520	502
query35	843	723	755	723
query36	1069	991	983	983
query37	117	66	67	66
query38	4045	4011	3957	3957
query39	1565	1470	1494	1470
query40	207	99	101	99
query41	48	47	50	47
query42	117	103	101	101
query43	546	516	486	486
query44	1184	797	805	797
query45	185	167	167	167
query46	1145	742	733	733
query47	2088	1956	1982	1956
query48	474	377	384	377
query49	755	379	385	379
query50	829	431	420	420
query51	7249	7296	7317	7296
query52	103	86	90	86
query53	261	191	195	191
query54	556	450	461	450
query55	75	76	79	76
query56	270	268	262	262
query57	1308	1203	1181	1181
query58	240	222	212	212
query59	3310	3126	3085	3085
query60	267	255	252	252
query61	110	111	112	111
query62	748	690	645	645
query63	214	185	187	185
query64	1501	685	637	637
query65	3240	3219	3264	3219
query66	679	293	307	293
query67	15957	15698	15690	15690
query68	4089	555	553	553
query69	431	260	263	260
query70	1172	1110	1123	1110
query71	352	256	261	256
query72	6402	4114	4045	4045
query73	763	342	348	342
query74	10154	9327	9280	9280
query75	3360	2653	2660	2653
query76	1968	1038	1134	1038
query77	475	264	275	264
query78	10647	9610	9550	9550
query79	1913	601	598	598
query80	1394	436	431	431
query81	532	242	238	238
query82	1268	85	86	85
query83	276	145	138	138
query84	285	87	78	78
query85	1042	328	295	295
query86	389	299	298	298
query87	4353	4237	4244	4237
query88	3884	2353	2338	2338
query89	417	286	295	286
query90	1866	183	186	183
query91	181	147	150	147
query92	66	49	50	49
query93	2557	541	543	541
query94	782	307	299	299
query95	352	263	259	259
query96	635	275	279	275
query97	3350	3148	3146	3146
query98	213	201	198	198
query99	1541	1291	1290	1290
Total cold run time: 314132 ms
Total hot run time: 198184 ms

@doris-robot
Copy link

doris-robot commented May 13, 2025

ClickBench: Total hot run time: 32.39 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 26b885de3e8b4be81b8d6c8d7f54f26e0f631482, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.61	0.10	0.09
query5	0.52	0.50	0.52
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.51	0.50
query10	0.56	0.55	0.58
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	2.74	2.79	2.75
query15	0.90	0.83	0.83
query16	0.38	0.38	0.38
query17	1.03	1.05	1.02
query18	0.24	0.23	0.22
query19	1.89	1.94	2.07
query20	0.01	0.01	0.01
query21	15.37	0.61	0.61
query22	2.62	1.95	1.69
query23	17.10	0.93	0.75
query24	3.33	1.07	1.16
query25	0.20	0.17	0.09
query26	0.55	0.14	0.14
query27	0.05	0.05	0.04
query28	10.04	0.49	0.51
query29	12.61	3.30	3.30
query30	0.24	0.07	0.07
query31	2.84	0.38	0.38
query32	3.26	0.47	0.46
query33	2.98	2.96	3.06
query34	17.13	4.56	4.54
query35	4.54	4.55	4.58
query36	0.68	0.48	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.92 s
Total hot run time: 32.39 s

dataroaring
dataroaring approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented May 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented May 13, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 7200d03 into branch-3.0 May 14, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-50830-branch-3.0 branch May 14, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @luwei16