Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 5, 2025

Cherry-picked from #48641

…correct (#48641)

### What problem does this PR solve?

Related PR: #17393

Problem Summary:

divide const folding for decimalv3 return type is not correct. return
scale should be dividend's scale - divider's scale.
@github-actions github-actions bot requested a review from dataroaring as a code owner March 5, 2025 07:20
@Thearas
Copy link
Contributor

Thearas commented Mar 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 5, 2025
@dataroaring dataroaring reopened this Mar 5, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 5, 2025

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 17c7309 into branch-3.0 Mar 10, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48641-branch-3.0 branch March 10, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants