Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 3, 2025

Cherry-picked from #48494 #48551

### What problem does this PR solve?

come from #28589

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

Co-authored-by: liutang123 <liulijia@gmail.com>
@github-actions github-actions bot requested a review from dataroaring as a code owner March 3, 2025 03:04
@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Mar 3, 2025
@dataroaring dataroaring reopened this Mar 3, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 3, 2025

run buildall

@dataroaring dataroaring closed this Mar 4, 2025
@dataroaring dataroaring reopened this Mar 4, 2025
dataroaring
dataroaring previously approved these changes Mar 20, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2025
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@cambyzju
Copy link
Contributor

run buildall

morningman
morningman previously approved these changes May 6, 2025
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman dismissed stale reviews from dataroaring and themself via 2c85c1f May 14, 2025 02:13
@morningman
Copy link
Contributor

run buildall

@morningman morningman changed the title branch-3.0: [fix](broker) fix fd always timeout #48494 branch-3.0: [fix](broker) fix fd always timeout #48494 #48551 May 14, 2025
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 14, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 14, 2025
@morningman morningman merged commit f0ee3bc into branch-3.0 May 14, 2025
31 of 33 checks passed
@github-actions github-actions bot deleted the auto-pick-48494-branch-3.0 branch May 14, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants