[optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms" #4808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull from Apache
from master
merge from apache
[Bug] Fix Windows function lag()/lead() function throw AnalysisExcept…
merge from master
merge from master
chaoyli
reviewed
Oct 28, 2020
| * | ||
| * make it one hour to avoid fe close the socket so frequently, that be will retry to cost more time | ||
| */ | ||
| @ConfField public static int thrift_client_timeout_ms = 30000; |
Contributor
There was a problem hiding this comment.
when will fe close the socket frequently?
Member
Author
There was a problem hiding this comment.
in our case, query information_schema.tables. i find fe would send a TCP RST command(try tcpdump 9020 in fe) to be to close the socket becasuse of thrift_client_timeout_ms is meet, the be log comes "no more data to read", the be would retry in 1s(default).
Contributor
|
@francisoliverlee Please provide an issue related to this PR. |
Member
Author
|
caiconghui
reviewed
Oct 30, 2020
| * The connection timeout and socket timeout config for thrift server | ||
| * The value for thrift_client_timeout_ms is set to be larger than zero to prevent | ||
| * some hang up problems in java.net.SocketInputStream.socketRead0 | ||
| * |
Contributor
There was a problem hiding this comment.
The connection timeout and socket timeout config for thrift server
The default value for thrift_client_timeout_ms is set to be zero to prevent readtimeout
@ConfField public static int thrift_client_timeout_ms = 0;
f7537fb
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...