Skip to content

branch-3.0: [improve](routine load) improve routine load observability #46238 #46567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jan 13, 2025
Merged

branch-3.0: [improve](routine load) improve routine load observability #46238 #46567

dataroaring merged 1 commit into from
Jan 13, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 7, 2025

Cherry-picked from #46238

@sollhui
[improve](routine load) improve routine load observability (#46238)
7839794 
1. **reset other msg in the a stream window**
The routine load job is a continuously scheduled job, and as the job
runs, previous errors do not need to be constantly displayed.

2. **show error info when  transaction of sub task failed**
If a subtask fails, it will continuously retry, and there may be some
errors that prevent the job from scheduling and consuming data properly,
such as continuous too many segments error(code: -235). At this time, it
is necessary to display it in a timely manner to make the user aware.

3. **set pause reason to other msg when reschedule job**
For jobs that are unexpectedly paused, the job manager has an auto
resume mechanism. However, for some scenarios, such as not being able to
connect to Kafka and being auto resumed after pause to retry, it may
cause users to not see the problem for a long time. Unexpectedly paused
jobs always have issues, even if auto resume occurs, the reason for the
error needs to be displayed.
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 7, 2025
@dataroaring dataroaring reopened this Jan 7, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 7, 2025

TPC-H: Total hot run time: 40838 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78397947ee1e734b540757c307741993d9019644, data reload: false

------ Round 1 ----------------------------------
q1	17568	7380	7272	7272
q2	2049	181	167	167
q3	10600	1067	1148	1067
q4	10583	767	714	714
q5	7795	2889	2838	2838
q6	234	146	140	140
q7	966	610	603	603
q8	9388	1932	1955	1932
q9	6500	6371	6390	6371
q10	7033	2314	2271	2271
q11	464	262	259	259
q12	392	213	216	213
q13	17839	3115	2991	2991
q14	245	216	213	213
q15	566	527	536	527
q16	710	610	627	610
q17	975	571	608	571
q18	7286	7017	6771	6771
q19	1390	1116	1054	1054
q20	464	212	199	199
q21	4066	3234	3081	3081
q22	1133	974	1010	974
Total cold run time: 108246 ms
Total hot run time: 40838 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7245	7223	7216	7216
q2	321	243	234	234
q3	2918	2971	2914	2914
q4	2070	1771	1749	1749
q5	5691	5752	5721	5721
q6	233	144	147	144
q7	2245	1831	1806	1806
q8	3329	3545	3498	3498
q9	8776	8836	8847	8836
q10	3567	3540	3530	3530
q11	595	501	491	491
q12	839	603	658	603
q13	11782	3211	3161	3161
q14	315	266	270	266
q15	590	541	515	515
q16	711	656	650	650
q17	1848	1629	1602	1602
q18	8245	7730	7503	7503
q19	1668	1636	1679	1636
q20	2114	1882	1859	1859
q21	5425	5369	5388	5369
q22	1142	1057	1056	1056
Total cold run time: 71669 ms
Total hot run time: 60359 ms

@doris-robot
Copy link

doris-robot commented Jan 7, 2025

TPC-DS: Total hot run time: 197770 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78397947ee1e734b540757c307741993d9019644, data reload: false

query1	1277	936	912	912
query2	6252	2140	2111	2111
query3	10992	4384	4455	4384
query4	65626	28565	23604	23604
query5	4894	446	448	446
query6	414	179	175	175
query7	5516	325	311	311
query8	324	232	261	232
query9	8525	2696	2679	2679
query10	447	260	267	260
query11	17158	15177	15931	15177
query12	153	102	103	102
query13	1515	459	444	444
query14	10799	6780	7439	6780
query15	202	188	186	186
query16	7107	501	516	501
query17	1125	604	605	604
query18	1834	343	323	323
query19	210	169	165	165
query20	119	109	110	109
query21	216	112	107	107
query22	4643	4532	4309	4309
query23	34901	34306	34562	34306
query24	6291	2954	2909	2909
query25	540	424	426	424
query26	662	171	181	171
query27	1727	354	371	354
query28	4296	2499	2461	2461
query29	712	462	453	453
query30	252	171	168	168
query31	997	824	851	824
query32	63	54	58	54
query33	445	278	283	278
query34	905	501	527	501
query35	840	730	718	718
query36	1104	966	983	966
query37	122	73	72	72
query38	4167	4130	4081	4081
query39	1493	1483	1466	1466
query40	200	97	101	97
query41	49	48	50	48
query42	114	108	103	103
query43	542	507	501	501
query44	1191	835	827	827
query45	183	165	172	165
query46	1134	724	734	724
query47	2001	1912	1941	1912
query48	489	402	390	390
query49	711	408	404	404
query50	851	421	426	421
query51	7427	7210	7349	7210
query52	101	85	88	85
query53	267	181	185	181
query54	555	443	460	443
query55	77	81	81	81
query56	269	244	258	244
query57	1214	1108	1066	1066
query58	207	201	200	200
query59	3109	2982	2988	2982
query60	265	260	250	250
query61	112	104	108	104
query62	770	669	669	669
query63	214	193	195	193
query64	1356	688	640	640
query65	3289	3196	3278	3196
query66	708	300	312	300
query67	15870	15785	15560	15560
query68	3953	578	575	575
query69	448	306	266	266
query70	1185	1152	1140	1140
query71	387	263	259	259
query72	6396	4180	4078	4078
query73	750	354	354	354
query74	10280	8995	9058	8995
query75	3350	2628	2682	2628
query76	2073	1187	1087	1087
query77	497	277	279	277
query78	10580	9712	9526	9526
query79	1724	603	609	603
query80	1410	425	443	425
query81	524	248	237	237
query82	1260	119	118	118
query83	188	153	146	146
query84	292	84	75	75
query85	982	285	305	285
query86	422	280	307	280
query87	4524	4304	4271	4271
query88	3725	2425	2363	2363
query89	412	286	286	286
query90	1922	185	186	185
query91	182	151	152	151
query92	72	54	54	54
query93	2182	548	549	548
query94	848	305	293	293
query95	380	259	248	248
query96	610	277	277	277
query97	3343	3129	3154	3129
query98	220	209	195	195
query99	1594	1296	1293	1293
Total cold run time: 318855 ms
Total hot run time: 197770 ms

@doris-robot
Copy link

doris-robot commented Jan 7, 2025

ClickBench: Total hot run time: 33.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78397947ee1e734b540757c307741993d9019644, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.63	0.10	0.10
query5	0.53	0.53	0.52
query6	1.15	0.73	0.74
query7	0.02	0.02	0.02
query8	0.05	0.05	0.03
query9	0.55	0.51	0.49
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.64	0.61	0.61
query14	3.04	2.92	3.02
query15	0.93	0.86	0.86
query16	0.39	0.37	0.38
query17	1.06	1.07	1.10
query18	0.23	0.22	0.21
query19	1.99	1.99	1.90
query20	0.02	0.01	0.01
query21	15.37	0.59	0.58
query22	2.47	3.23	2.52
query23	16.94	0.85	0.86
query24	2.81	0.70	1.20
query25	0.19	0.10	0.11
query26	0.47	0.14	0.14
query27	0.04	0.05	0.03
query28	10.97	1.12	1.09
query29	12.61	3.30	3.29
query30	0.26	0.07	0.06
query31	2.86	0.42	0.40
query32	3.24	0.48	0.49
query33	3.02	3.04	3.06
query34	17.21	4.52	4.58
query35	4.66	4.57	4.65
query36	0.67	0.50	0.51
query37	0.10	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 107.72 s
Total hot run time: 33.93 s

@dataroaring dataroaring merged commit 845e74b into branch-3.0 Jan 13, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-46238-branch-3.0 branch January 13, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @sollhui