Skip to content

[opt](Nereids) optimize performance in new distribute planner #44048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
924060929 merged 4 commits into from
Nov 18, 2024
Merged

[opt](Nereids) optimize performance in new distribute planner #44048

924060929 merged 4 commits into from
Nov 18, 2024

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Nov 15, 2024 •
edited
Loading

What problem does this PR solve?

optimize new distribute planner performance in tpc-h, because #41730 made some performance rollback has occurred

  1. fix the wrong runtime filter thrift parameters
  2. not default to print distribute plan in profile, you should config set profile_level=3 to see it
  3. for shuffle join which two sides distribution of natural + execution_bucketed, support compare cost between plans of shuffle to left/right

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 15, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

924060929 commented Nov 15, 2024

run buildall

1 similar comment
@924060929
Copy link
Contributor Author

924060929 commented Nov 15, 2024

run buildall

@924060929
Copy link
Contributor Author

924060929 commented Nov 16, 2024

run buildall

@morrySnow morrySnow changed the title [opt](Nereids) optimize new distribute planner performance in tpc-h [opt](Nereids) optimize shuffle strategy in new distribute planner Nov 18, 2024
@morrySnow morrySnow changed the title [opt](Nereids) optimize shuffle strategy in new distribute planner [opt](Nereids) optimize performance in new distribute planner Nov 18, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit 07ec657 into apache:master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@seawinde seawinde seawinde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. not-merge/3.0 reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@924060929 @doris-robot @morrySnow @seawinde