-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](decimal256) support decimal256 for many functions (#42136) #42353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
182d136 to
70359c9
Compare
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| return result_type; | ||
| } | ||
|
|
||
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'execute_impl' has cognitive complexity of 55 (threshold 50) [readability-function-cognitive-complexity]
Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
^Additional context
be/src/vec/functions/function_coalesce.cpp:85: +1, including nesting penalty of 0, nesting level increased to 1
if (!func_is_not_null) [[unlikely]] {
^be/src/vec/functions/function_coalesce.cpp:97: +1, including nesting penalty of 0, nesting level increased to 1
for (size_t i = 0; i < arguments.size(); ++i) {
^be/src/vec/functions/function_coalesce.cpp:100: +2, including nesting penalty of 1, nesting level increased to 2
if (!arg_type->is_nullable()) {
^be/src/vec/functions/function_coalesce.cpp:101: +3, including nesting penalty of 2, nesting level increased to 3
if (i == 0) {
^be/src/vec/functions/function_coalesce.cpp:106: +1, nesting level increased to 3
} else {
^be/src/vec/functions/function_coalesce.cpp:122: +1, including nesting penalty of 0, nesting level increased to 1
if (!result_type->is_nullable()) {
^be/src/vec/functions/function_coalesce.cpp:124: +1, nesting level increased to 1
} else {
^be/src/vec/functions/function_coalesce.cpp:131: +1, including nesting penalty of 0, nesting level increased to 1
if (is_string_result) {
^be/src/vec/functions/function_coalesce.cpp:133: +1, nesting level increased to 1
} else {
^be/src/vec/functions/function_coalesce.cpp:143: +1, including nesting penalty of 0, nesting level increased to 1
for (size_t i = 0; i < argument_size; ++i) {
^be/src/vec/functions/function_coalesce.cpp:148: +2, including nesting penalty of 1, nesting level increased to 2
if (auto* nullable = check_and_get_column<const ColumnNullable>(*argument_columns[i])) {
^be/src/vec/functions/function_coalesce.cpp:157: +1, including nesting penalty of 0, nesting level increased to 1
for (size_t i = 0; i < argument_size && remaining_rows; ++i) {
^be/src/vec/functions/function_coalesce.cpp:157: +1
for (size_t i = 0; i < argument_size && remaining_rows; ++i) {
^be/src/vec/functions/function_coalesce.cpp:160: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(
^be/src/common/status.h:619: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/functions/function_coalesce.cpp:160: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(
^be/src/common/status.h:621: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/functions/function_coalesce.cpp:172: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t j = 0; j < input_rows_count; ++j) {
^be/src/vec/functions/function_coalesce.cpp:178: +2, including nesting penalty of 1, nesting level increased to 2
if (remaining_rows == 0) {
^be/src/vec/functions/function_coalesce.cpp:182: +3, including nesting penalty of 2, nesting level increased to 3
for (size_t row = 0; row < input_rows_count; ++row) {
^be/src/vec/functions/function_coalesce.cpp:186: +3, including nesting penalty of 2, nesting level increased to 3
if (is_same_column_count == input_rows_count) {
^be/src/vec/functions/function_coalesce.cpp:187: +4, including nesting penalty of 3, nesting level increased to 4
if (result_type->is_nullable()) {
^be/src/vec/functions/function_coalesce.cpp:190: +1, nesting level increased to 4
} else {
^be/src/vec/functions/function_coalesce.cpp:197: +2, including nesting penalty of 1, nesting level increased to 2
if (!is_string_result) {
^be/src/vec/functions/function_coalesce.cpp:201: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(filled_result_column(result_type, result_column,
^be/src/common/status.h:619: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/functions/function_coalesce.cpp:201: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(filled_result_column(result_type, result_column,
^be/src/common/status.h:621: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/functions/function_coalesce.cpp:207: +1, including nesting penalty of 0, nesting level increased to 1
if (is_string_result) {
^be/src/vec/functions/function_coalesce.cpp:209: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t row = 0; row < input_rows_count; ++row) {
^be/src/vec/functions/function_coalesce.cpp:210: +3, including nesting penalty of 2, nesting level increased to 3
if (null_map_data[row]) { //should be null
^be/src/vec/functions/function_coalesce.cpp:212: +1, nesting level increased to 3
} else {
^be/src/vec/functions/function_coalesce.cpp:218: +1, including nesting penalty of 0, nesting level increased to 1
if (result_type->is_nullable()) {
^be/src/vec/functions/function_coalesce.cpp:221: +1, nesting level increased to 1
} else {
^|
TeamCity be ut coverage result: |
BP #42136