Skip to content

[bug](cherry-pick) Fix coredump in aggregation node's destruction #28987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Dec 25, 2023
Merged

[bug](cherry-pick) Fix coredump in aggregation node's destruction #28987

xiaokang merged 1 commit into from
Dec 25, 2023

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Dec 25, 2023

Proposed changes

cherry-pick: #28684

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720
Copy link
Member Author

xy720 commented Dec 25, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 25, 2023

TeamCity be ut coverage result:
Function Coverage: 37.76% (7995/21172)
Line Coverage: 29.46% (64962/220496)
Region Coverage: 28.94% (33423/115504)
Branch Coverage: 24.81% (17151/69132)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b82d6677fec2a02cf308b56e6456624403b4df9_7b82d6677fec2a02cf308b56e6456624403b4df9/report/index.html

@xy720
Copy link
Member Author

xy720 commented Dec 25, 2023

run clickbench

@doris-robot
Copy link

doris-robot commented Dec 25, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.4 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 30.0 seconds inserted 10000000 Rows, about 333K ops/s
storage size: 17164024513 Bytes

@xiaokang xiaokang merged commit b12e3ce into apache:branch-2.0 Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xy720 @doris-robot @xiaokang