Skip to content

[Pick 2.0](inverted index) add lowercase option for inverted index analyzer (#28704) #28948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qidaye merged 1 commit into from
Dec 25, 2023
Merged

[Pick 2.0](inverted index) add lowercase option for inverted index analyzer (#28704) #28948

qidaye merged 1 commit into from
Dec 25, 2023

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Dec 25, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. kind/test labels Dec 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2023

clang-tidy review says "All clean, LGTM! 👍"

@airborne12
Copy link
Member Author

airborne12 commented Dec 25, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 25, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.57 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 30.1 seconds inserted 10000000 Rows, about 332K ops/s
storage size: 17162525610 Bytes

@doris-robot
Copy link

doris-robot commented Dec 25, 2023

TeamCity be ut coverage result:
Function Coverage: 37.75% (7992/21171)
Line Coverage: 29.45% (64929/220436)
Region Coverage: 28.93% (33402/115477)
Branch Coverage: 24.80% (17139/69112)
Coverage Report: http://coverage.selectdb-in.cc/coverage/323a0eefd21892c8669ca88167f259e16007e5b9_323a0eefd21892c8669ca88167f259e16007e5b9/report/index.html

qidaye
qidaye approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2023

PR approved by anyone and no changes requested.

@qidaye qidaye merged commit 0a968f0 into apache:branch-2.0 Dec 25, 2023
@xiaokang
Copy link
Contributor

xiaokang commented Dec 25, 2023

#28704

@airborne12 airborne12 changed the title [Pick2.0](inverted index) add lowercase option for inverted index analyzer (#28704) [Pick 2.0](inverted index) add lowercase option for inverted index analyzer (#28704) Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qidaye qidaye qidaye approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@airborne12 @doris-robot @xiaokang @qidaye