Skip to content

[improvement](jdbc catalog) Optimize connection pool caching logic #28857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Dec 26, 2023
Merged

[improvement](jdbc catalog) Optimize connection pool caching logic #28857

xiaokang merged 1 commit into from
Dec 26, 2023

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Dec 22, 2023 •
edited
Loading

Proposed changes

Issue Number: close #xxx

In the old caching logic, we only used jdbcurl, user, and password as cache keys. This may cause the old link to be still used when replacing the jar package, so we should concatenate all the parameters required for the connection pool as the key.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zy-kkk
Copy link
Member Author

zy-kkk commented Dec 22, 2023

run buildall

@zy-kkk zy-kkk mentioned this pull request Dec 22, 2023
Merged
@doris-robot
Copy link

doris-robot commented Dec 22, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.43 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162352403 Bytes

@zy-kkk
Copy link
Member Author

zy-kkk commented Dec 25, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 25, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.28 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17167938430 Bytes

@xiaokang
Copy link
Contributor

xiaokang commented Dec 25, 2023

#28859

@xiaokang xiaokang requested a review from morningman December 25, 2023 07:43
@xiaokang xiaokang merged commit b381e17 into apache:branch-2.0 Dec 26, 2023
@zy-kkk zy-kkk deleted the jdbc_source_cache branch March 22, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman Awaiting requested review from morningman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zy-kkk @doris-robot @xiaokang