Skip to content

[branch2.0](functions) Fix from_second functions overflow and wrong result #28833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 3 commits into from
Dec 22, 2023
Merged

[branch2.0](functions) Fix from_second functions overflow and wrong result #28833

xiaokang merged 3 commits into from
Dec 22, 2023

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Dec 21, 2023

Proposed changes

Issue Number: close #xxx

pick #28685

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Dec 21, 2023

run buildall

@github-actions github-actions bot added kind/docs Categorizes issue or PR as related to documentation. kind/test labels Dec 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Dec 21, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

TeamCity be ut coverage result:
Function Coverage: 37.75% (7991/21170)
Line Coverage: 29.45% (64904/220372)
Region Coverage: 28.92% (33388/115451)
Branch Coverage: 24.79% (17126/69084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45552fb88e77db2fd1cc2062ac3a9eff0ad378da_45552fb88e77db2fd1cc2062ac3a9eff0ad378da/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.18 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162485754 Bytes

@xiaokang xiaokang merged commit c393006 into apache:branch-2.0 Dec 22, 2023
@zclllyybb zclllyybb deleted the pick_fromsecond branch December 22, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/docs Categorizes issue or PR as related to documentation. kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zclllyybb @doris-robot @xiaokang