Skip to content

[bugfix](topn) fix coredump in copy_column_data_to_block when nullable mismatch #27765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 1 commit into from
Nov 29, 2023
Merged

[bugfix](topn) fix coredump in copy_column_data_to_block when nullable mismatch #27765

eldenmoon merged 1 commit into from
Nov 29, 2023

Conversation

@xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Nov 29, 2023

Proposed changes

Issue Number: close #xxx

return RuntimeError if copy_column_data_to_block nullable mismatch to avoid coredump in input_col_ptr->filter_by_selector(sel_rowid_idx, select_size, raw_res_ptr) .

The problem is reported by a doris user but I can not reproduce it, so there is no testcase added currently.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xiaokang xiaokang added usercase Important user case type label p0_c labels Nov 29, 2023
@xiaokang
Copy link
Contributor Author

xiaokang commented Nov 29, 2023

run buildall

eldenmoon
eldenmoon approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Nov 29, 2023

TeamCity be ut coverage result:
Function Coverage: 37.96% (7984/21032)
Line Coverage: 29.67% (64770/218315)
Region Coverage: 29.12% (33380/114637)
Branch Coverage: 24.97% (17140/68644)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9bbfe7ae3c2ea17b00c6031605ae308959e99191_9bbfe7ae3c2ea17b00c6031605ae308959e99191/report/index.html

@doris-robot
Copy link

doris-robot commented Nov 29, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.31 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162672418 Bytes

@eldenmoon eldenmoon merged commit 5a3a920 into apache:branch-2.0 Nov 29, 2023
@xiaokang xiaokang mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. p0_c reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiaokang @doris-robot @eldenmoon