Skip to content

[minor] add disable swap command #25235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xiedeyantu wants to merge 3 commits into from
Closed

[minor] add disable swap command #25235

xiedeyantu wants to merge 3 commits into from

Conversation

@xiedeyantu
Copy link
Member

@xiedeyantu xiedeyantu commented Oct 10, 2023

Proposed changes

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xiedeyantu
Copy link
Member Author

xiedeyantu commented Nov 9, 2023

@xiaokang Hi, Do we need this pr?

@xiaokang
Copy link
Contributor

xiaokang commented Nov 10, 2023

@xiedeyantu Yes, can you submit a pr for branch-2.0

@xiaokang xiaokang mentioned this pull request Nov 11, 2023
Merged
@xiaokang
Copy link
Contributor

xiaokang commented Nov 11, 2023

run buildall

xiaokang
xiaokang previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 11, 2023

TeamCity be ut coverage result:
Function Coverage: 36.78% (8406/22856)
Line Coverage: 29.30% (68165/232682)
Region Coverage: 27.92% (35231/126188)
Branch Coverage: 24.74% (18027/72854)
Coverage Report: http://coverage.selectdb-in.cc/coverage/72ef6bc2bf5319ed762a14b851ceb589594e693c_72ef6bc2bf5319ed762a14b851ceb589594e693c/report/index.html

@doris-robot
Copy link

doris-robot commented Nov 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.47 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162302661 Bytes

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 14, 2023
@xiedeyantu
Copy link
Member Author

xiedeyantu commented Mar 21, 2024

@xiaokang Hi, do we need to merge to master?

@xiedeyantu
Copy link
Member Author

xiedeyantu commented Apr 6, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Apr 6, 2024

TeamCity be ut coverage result:
Function Coverage: 35.64% (8887/24932)
Line Coverage: 27.38% (72974/266488)
Region Coverage: 26.56% (37723/142037)
Branch Coverage: 23.36% (19224/82306)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fe131415489c29d0a4f48db4035a297316ae8630_fe131415489c29d0a4f48db4035a297316ae8630/report/index.html

xiaokang
xiaokang approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Oct 6, 2024
@github-actions github-actions bot closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiedeyantu @xiaokang @doris-robot