Skip to content

Basic implementation for BetaRowsetReader #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imay merged 6 commits into from
Sep 3, 2019
Merged

Basic implementation for BetaRowsetReader #1718

imay merged 6 commits into from
Sep 3, 2019

Conversation

@gaodayue
Copy link
Contributor

@gaodayue gaodayue commented Aug 28, 2019 •
edited
Loading

This PR contains the following changes

  • implement core functions of BetaRowsetReader
  • make Arena a member of RowBlock2 so that it can be easily reused
  • fixed several bugs in the v2 read path

Future works

  • handling deleted rows in BetaRowsetReader
  • support OlapReaderStatistics
  • add a field in RowsetMetaPB to denote whether the rowset contains ordered segments

imay
imay requested changes Aug 28, 2019
View reviewed changes
@kangpinghuang
Copy link
Contributor

kangpinghuang commented Sep 2, 2019

add a description for this pr.

@gaodayue
Copy link
Contributor Author

gaodayue commented Sep 2, 2019

@kangpinghuang I have updated the description for the PR

imay
imay reviewed Sep 2, 2019
View reviewed changes
kangpinghuang
kangpinghuang reviewed Sep 2, 2019
View reviewed changes
imay
imay previously approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imay
imay approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit f76dad2 into apache:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kangpinghuang kangpinghuang kangpinghuang left review comments

@imay imay imay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaodayue @kangpinghuang @imay