Skip to content

[fix](string function) fix coredump cause by not supported charset of convert function #17032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Feb 22, 2023
Merged

[fix](string function) fix coredump cause by not supported charset of convert function #17032

yiguolei merged 1 commit into from
Feb 22, 2023

Conversation

@jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Feb 22, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

sql select convert('a' using utf8) cause coredump of BE:

Thread 338 "FragmentMgrThre" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f0b2c21a700 (LWP 2865259)]
0x00007fff04f8a015 in __gconv_close () from /lib64/libc.so.6
(gdb) bt
#0  0x00007fff04f8a015 in __gconv_close () from /lib64/libc.so.6
#1  0x00007fff04f899e3 in iconv_close () from /lib64/libc.so.6
#2  0x000055556f92f5a7 in doris::vectorized::FunctionConvertTo::close (this=0x606003f28f50, context=0x6020039fe710, 
    scope=doris_udf::FunctionContext::THREAD_LOCAL) at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/functions/function_string.h:2442
#3  0x000055556db0598d in doris::vectorized::DefaultFunction::close (this=0x607000748f00, context=0x6020039fe710, 
    scope=doris_udf::FunctionContext::THREAD_LOCAL) at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/functions/function.h:524
#4  0x000055556da00b66 in doris::vectorized::VExpr::close_function_context (this=0x619004ca1d80, context=0x606003fad300, 
    scope=doris_udf::FunctionContext::FRAGMENT_LOCAL, function=...) at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/exprs/vexpr.cpp:373
#5  0x000055556da16455 in doris::vectorized::VectorizedFnCall::close (this=0x619004ca1d80, state=0x61c00026c880, context=0x606003fad300, 
    scope=doris_udf::FunctionContext::FRAGMENT_LOCAL) at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/exprs/vectorized_fn_call.cpp:92
#6  0x000055556da26afd in doris::vectorized::VExprContext::close (this=0x606003fad300, state=0x61c00026c880)
    at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/exprs/vexpr_context.cpp:72
#7  0x000055556d9fcff1 in doris::vectorized::VExpr::close (ctxs=..., state=0x61c00026c880)
    at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/exprs/vexpr.cpp:242
#8  0x000055556aa32c9a in doris::vectorized::VSortExecExprs::close (this=0x618000345f00, state=0x61c00026c880)
    at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/common/sort/vsort_exec_exprs.cpp:77
#9  0x000055556aa26dae in doris::vectorized::VSortNode::close (this=0x618000345c80, state=0x61c00026c880)
    at /mnt/disk2/tengjianping/doris-1.2/be/src/vec/exec/vsort_node.cpp:129
#10 0x000055556794b5ef in doris::PlanFragmentExecutor::close (this=0x6170005a35f0)
    at /mnt/disk2/tengjianping/doris-1.2/be/src/runtime/plan_fragment_executor.cpp:676
#11 0x00005555678ce1fb in doris::FragmentExecState::execute (this=0x6170005a3580)
    at /mnt/disk2/tengjianping/doris-1.2/be/src/runtime/fragment_mgr.cpp:258
#12 0x00005555678d6633 in doris::FragmentMgr::_exec_actual(std::shared_ptr<doris::FragmentExecState>, std::function<void (doris::PlanFragmentExecutor*)>) (this=0x627000003900, exec_state=..., cb=...) at /mnt/disk2/tengjianping/doris-1.2/be/src/runtime/fragment_mgr.cpp:497
#13 0x00005555678d8aa3 in operator() (__closure=0x60800014cda0) at /mnt/disk2/tengjianping/doris-1.2/be/src/runtime/fragment_mgr.cpp:721

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test labels Feb 22, 2023
yiguolei
yiguolei approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit dc21fcb into apache:branch-1.2-lts Feb 22, 2023
@yiguolei yiguolei added the usercase Important user case type label label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/1.2.3-merged kind/test usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacktengg @yiguolei