[Feature-8023][Document] Add example and notice about task type Python#713
[Feature-8023][Document] Add example and notice about task type Python#713zhongjiajie merged 1 commit intoapache:masterfrom
Conversation
@zhongjiajie FYi, this pr is WIP. I only fix the python task examples in English dev version in this commit. If things look good, I will fix python task examples in other versions of docs in the following commits. Thx : ) |
|
will task a look tomorrow, is midnight now |
zhongjiajie
left a comment
There was a problem hiding this comment.
Looking good! thanks @EricGao888. FYI you just need to change dev and latest(for now is2.0.3) doc in both EN and ZH doc. we could jus ignore previous verisons
Sure, thx for the comment! BTW maybe we can adopt jinjava or other template lib to generate doc in the feture? I think that may save a lot of work. |
|
Good point, yeah, we already have a plan in apache/dolphinscheduler#6535, section |
|
BTW, we plan to move our docs into main repo. After that we only need to change dev version docs. (in most cases) |
@zhongjiajie I've changed the |
zhongjiajie
left a comment
There was a problem hiding this comment.
docs looking good, but could you change the screenshot to latest in branch dev? We change our UI recently which you can see https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/task/flink.html as example
Sure, the new UI looks cool! |
Have changed the screenshots in dev directory to match the newest UI : ) |
|
I approved the CI running just now |
| - Script: Python program developed by the user. | ||
| - Environment Name: Specific Python interpreter path for running the script. If you need to use Python **virtualenv**, you should create multiply environments for each **virtualenv**. | ||
| - Resources: Refers to the list of resource files that need to be called in the script. | ||
| - User-defined parameter: It is a user-defined local parameter of Python, and will replace the content with `${variable}` in the script. | ||
| - Note: If you import the python file under the resource directory tree, you need to add the `__init__.py` file. |
There was a problem hiding this comment.
BTW, @Tianqi-Dotes could you make a double check about our dev EN document change?
There was a problem hiding this comment.
I find that we have some docs overwrite in other PR
There was a problem hiding this comment.
@zhongjiajie @Tianqi-Dotes Is there anything else I could do here? I mean the docs overwrite stuff, not sure what it is.
|
Thanks @Tianqi-Dotes for reviewing |
@Tianqi-Dotes Hi Tianqi, thx for helping me review the docs in such detail. I've fixed the related language issues and resolved the comments : ) |
|
I will merge it when it finishes the CI, and then will do the doc migration |
@zhongjiajie Cool, I'm looking forward to the doc migration. After migration, it seems easier for developers to contribute to dolphin docs and I'd like to keep contributing to these docs : ) |
zhongjiajie
left a comment
There was a problem hiding this comment.
LGTM, thanks and I will migrate it ASAP
Uh oh!
There was an error while loading. Please reload this page.