[Feature-8024][Document] Add example and notice about task type Flink#688
Merged
zhongjiajie merged 24 commits intoapache:masterfrom Feb 12, 2022
Merged
[Feature-8024][Document] Add example and notice about task type Flink#688zhongjiajie merged 24 commits intoapache:masterfrom
zhongjiajie merged 24 commits intoapache:masterfrom
Conversation
docs: add en-us load-balance.md
docs: add en-us load-balance.md
fetch upstream
zhongjiajie
reviewed
Feb 11, 2022
Member
zhongjiajie
left a comment
There was a problem hiding this comment.
I add some suggestions, others LTGM
Member
|
Please remember to add English version and change dev version too. |
Contributor
Author
I have completed it. |
zhongjiajie
reviewed
Feb 12, 2022
zhongjiajie
approved these changes
Feb 12, 2022
Member
zhongjiajie
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution
Member
|
Oh, we still need to pass CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: apache/dolphinscheduler#8024
I have updated the document of the Flink task, please review it. If there is nothing need to modify, I will translate and update the other relevant files.
PTAL @zhongjiajie