[Improvement][docs] Unit test benchmark specification#165
Merged
davidzollo merged 5 commits intoapache:masterfrom Aug 19, 2020
CalvinKirs:test
Merged
[Improvement][docs] Unit test benchmark specification#165davidzollo merged 5 commits intoapache:masterfrom CalvinKirs:test
davidzollo merged 5 commits intoapache:masterfrom
CalvinKirs:test
Conversation
Member
|
@CalvinKirs Let's invite @dailidong and @qiaozhanwei to review this PR, if there're no opposite suggestions, this can be merged |
Member
Author
Thank you very much for your review |
docs/zh-cn/development/unit-test.md
Outdated
Comment on lines
+41
to
+43
|
|
||
|
|
||
|
|
docs/zh-cn/development/unit-test.md
Outdated
Comment on lines
+32
to
+33
|
|
||
|
|
docs/zh-cn/development/unit-test.md
Outdated
|
|
||
| 即任何环境都可快速执行。 | ||
|
|
||
| 这要求我们尽可能不要依赖太多组件，如各种spring bean之类的。在单元测试中，这些都是可被mock的，增加这些，会加大我们单测的执行速度，同时也可能会传递污染。 |
Contributor
There was a problem hiding this comment.
Suggested change
| 这要求我们尽可能不要依赖太多组件，如各种spring bean之类的。在单元测试中，这些都是可被mock的，增加这些，会加大我们单测的执行速度，同时也可能会传递污染。 | |
| 这要求我们尽可能不要依赖太多组件，如各种 spring bean 之类的。在单元测试中，这些都是可被 mock 的，增加这些，会加大我们单测的执行速度，同时也可能会传递污染。 |
Contributor
|
Please change the title to |
davidzollo
approved these changes
Aug 19, 2020
Contributor
davidzollo
left a comment
There was a problem hiding this comment.
+1
good job
if add more unit test examples will be better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit test benchmark specification